From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C59FC6FA82 for ; Sat, 10 Sep 2022 11:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3DF96B0071; Sat, 10 Sep 2022 07:32:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EE468D0002; Sat, 10 Sep 2022 07:32:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B51E8D0001; Sat, 10 Sep 2022 07:32:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 72AD86B0071 for ; Sat, 10 Sep 2022 07:32:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4085FA0E12 for ; Sat, 10 Sep 2022 11:32:29 +0000 (UTC) X-FDA: 79895962818.22.67DB3F0 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf07.hostedemail.com (Postfix) with ESMTP id C872F4007A for ; Sat, 10 Sep 2022 11:32:28 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id e18so6167227edj.3 for ; Sat, 10 Sep 2022 04:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=oO2f6puxNv2WM0203jHJ9dATLxOnB/EAhNK0gKh1Fco=; b=ZH5YuCofNtiX91aOQ8okF8wGG31vLQnBuGTbsJIxq6skqZDH7RvK+S6Wg/jL8kGMG0 wxALhNndMloVN1pmlZYgbSnkA4WugVPm6xPyUnDyPXtNQrabmBlb3doY3JHFHpEwdDOn UCMlcq27n8LGY/fiI8rrezsaIzsFdm7yeal6QiEIrx2i6u5RSvNr3NejNRbuoylCf6VT 1NmPWSzvA4lzXHfElWpQVZrWn1GOb5l1rdycwSX1lGO4Q9iha+7RREdHfUFuABmzTqNy MS6wyNdM+htzk0aYqzebY8yDNHwmUT2SYl/24SW+F1b30ss1/TkgEA7qVOS7cSXPX2Wb gdkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=oO2f6puxNv2WM0203jHJ9dATLxOnB/EAhNK0gKh1Fco=; b=zGPo5e0NgINXJH5/WfmmaZrrngsEsk+/gI6I2JhC0D9YJ6vqegRaipIDfPCT+YQjPt FAuLB8NcjgYa7A/7GC7rHbEajVjcCvutBXPlko3604Kb/5g/7TlBTeR+0pHVVuXWWI6x PScpD4MpMZMQoMWXJvBr36+Nx1vKWIZRVDcfGZ7rlSP/2GJjnU9hWyfeCjeA07yLVnHy o40CMzM8a7RadtipeDATaXdXYMM2Y/6Nr1mh3ts5eLxfiOGzPGxHL+AoCLaj0dWiUKn6 4qZ01jTmZt+VRl41VEF8wNe5L6lkeGc9GSX/uSJ5QleFdiRhzNu0W8AomiZ3v8Mq4mnc 900A== X-Gm-Message-State: ACgBeo31cdCZ6WVpMcFUTZPJ5umOytIcXTZn1TqFcO4Mo+NPpzI0eUsk mNLQzE0TUwThKcOZiBGyJGfGZA== X-Google-Smtp-Source: AA6agR7ABzhvw0hLX7UM5YEGmj7ooKpj1BWh9U8hMic6ls9gEZTIgOqBBSoD7neml/f66zDsZ4trLA== X-Received: by 2002:a05:6402:280f:b0:44e:ee5c:da6b with SMTP id h15-20020a056402280f00b0044eee5cda6bmr15219418ede.256.1662809547250; Sat, 10 Sep 2022 04:32:27 -0700 (PDT) Received: from [10.41.110.194] ([77.241.232.28]) by smtp.gmail.com with ESMTPSA id g2-20020a17090604c200b00731582babcasm1625186eja.71.2022.09.10.04.32.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Sep 2022 04:32:26 -0700 (PDT) Message-ID: Date: Sat, 10 Sep 2022 05:32:25 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: improve pagecache PSI annotations Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton Cc: Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org References: <20220910065058.3303831-1-hch@lst.de> From: Jens Axboe In-Reply-To: <20220910065058.3303831-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=ZH5YuCof; spf=pass (imf07.hostedemail.com: domain of axboe@kernel.dk designates 209.85.208.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662809549; a=rsa-sha256; cv=none; b=vRd/x9oybJn+Js1lO3LMp/9XVWH3wXn5DOfEoakc6vuNtse9WR8+xqUkQrUu1iqzmXkCjH aNVbEUMD6EK5V71+sMwWb7IYO9VOHIxP9S+9s9lZ5j42JEF9XopYrvWuJLMMLWm9qMVTkA za71OyJHL+H/wamPNYYJZDP2VVCmdz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662809549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oO2f6puxNv2WM0203jHJ9dATLxOnB/EAhNK0gKh1Fco=; b=3L3vi7XqjVqH/z7CFUIPjuz9ao192snPq50y27iU84BniD0NhpI0kh4CXJTZobollyRX6D M6JSC4vMTCqN0SW1PUtKELBBphbyOlk/zz+VEHlkbtn8n+2I8VPA9CFqLJw3KFsE6D02Qy qZLd6j/liksjv5Pv7ZtJ2Z++ZaV0QaU= X-Stat-Signature: s6wu5hx6zzng8xrumyoafct5s877pd7p X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=ZH5YuCof; spf=pass (imf07.hostedemail.com: domain of axboe@kernel.dk designates 209.85.208.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C872F4007A X-HE-Tag: 1662809548-969702 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/10/22 12:50 AM, Christoph Hellwig wrote: > Hi all, > > currently the VM tries to abuse the block layer submission path for > the page cache PSI annotations. This series instead annotates the > ->read_folio and ->readahead calls in the core VM code, and then > only deals with the odd direct add_to_page_cache_lru calls manually. > > Diffstat: > block/bio.c | 8 -------- > block/blk-core.c | 17 ----------------- > fs/btrfs/compression.c | 14 ++++++++++++-- > fs/direct-io.c | 2 -- > fs/erofs/zdata.c | 13 ++++++++++++- > include/linux/blk_types.h | 1 - > include/linux/pagemap.h | 2 ++ > kernel/sched/psi.c | 2 ++ > mm/filemap.c | 7 +++++++ > mm/readahead.c | 22 ++++++++++++++++++---- > 10 files changed, 53 insertions(+), 35 deletions(-) Nice! It's always bothered me that we have this weird layering here. -- Jens Axboe