From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Sahil Chandna <chandna.sahil@gmail.com>,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev,
zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com,
weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com,
yosry.ahmed@linux.dev, nphamcs@gmail.com,
chengming.zhou@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH v2 3/3] mm/zswap: use %pe to print error pointers
Date: Mon, 24 Nov 2025 11:54:58 +0100 [thread overview]
Message-ID: <c7546593-75f7-4248-9986-f89c157a18a1@kernel.org> (raw)
In-Reply-To: <0c00ceedce6e0d9aed35cee5faf15fd9126a1f70.1763796152.git.chandna.sahil@gmail.com>
On 11/23/25 04:04, Sahil Chandna wrote:
> Use the %pe printk format specifier to report error pointers directly
> instead of printing PTR_ERR() as a long value. This improves clarity,
> produces more readable error messages.
>
> This instance was flagged by the Coccinelle script
> (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
>
> Found by: make coccicheck MODE=report M=mm/
> No functional change intended.
>
> Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> Acked-by: Nhat Pham <nphamcs@gmail.com>
> Reviewed-by: SeongJae Park <sj@kernel.org>
> Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>
> ---
Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
--
Cheers
David
prev parent reply other threads:[~2025-11-24 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 3:04 [PATCH v2 0/3] mm: Coccinelle-driven cleanups across memory management code Sahil Chandna
2025-11-23 3:04 ` [PATCH v2 1/3] mm: pagewalk: simplify hugepage boundary calculation using min() Sahil Chandna
2025-11-24 10:53 ` David Hildenbrand (Red Hat)
2025-11-23 3:04 ` [PATCH v2 2/3] mm/vmscan: use %pe to print error pointers Sahil Chandna
2025-11-24 10:54 ` David Hildenbrand (Red Hat)
2025-11-23 3:04 ` [PATCH v2 3/3] mm/zswap: " Sahil Chandna
2025-11-24 10:54 ` David Hildenbrand (Red Hat) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7546593-75f7-4248-9986-f89c157a18a1@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chandna.sahil@gmail.com \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=yosry.ahmed@linux.dev \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox