From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9205C43217 for ; Mon, 28 Nov 2022 13:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1D2A6B0074; Mon, 28 Nov 2022 08:18:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCCE06B0075; Mon, 28 Nov 2022 08:18:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B948C6B0078; Mon, 28 Nov 2022 08:18:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A7A956B0074 for ; Mon, 28 Nov 2022 08:18:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6459F1A017A for ; Mon, 28 Nov 2022 13:18:17 +0000 (UTC) X-FDA: 80182904634.07.E44BF9A Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf03.hostedemail.com (Postfix) with ESMTP id 295EF2001B for ; Mon, 28 Nov 2022 13:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669641495; x=1701177495; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=feh5wIxMdReyTgHXcIIwra+buNVe+nG18fhOngJ00EI=; b=W6PIU8Q96iRz9G6OkKNJm/QvSX/QAfkNjvsguFpXa3CViYcgELbkiTBq rG1SY7/LioKmA5akR5PiSOlO6uZ2Yeiu6ypB4CBELh0Ypizij/12nudGO wlB/DeNv2MBxGySPXmU76U2mvttyEb2viljvnM3bXInwJzAtcNaEreK6A wO9j6EhoHlCH4gb1BnxQRzHDYN77D4Ze8Mpn3I2GZdLDHWvbpZV9QqN9X a6fhAxkP/rzXNsQYK1ugHa4zaZuEv0vJh8Ruk165mJ+PPSsZw9PEmhphg 9qDJf9LFp/cZW80dAwQCljEwMDv3S2nS7aFkHNbzwIU+Dz9lwiVMVU/83 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10544"; a="298184276" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="298184276" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 05:18:13 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10544"; a="593867697" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="593867697" Received: from nroy-mobl1.amr.corp.intel.com (HELO [10.212.209.4]) ([10.212.209.4]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 05:18:12 -0800 Message-ID: Date: Mon, 28 Nov 2022 05:18:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 14/20] x86/virt/tdx: Set up reserved areas for all TDMRs Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <5a5644e691134dc72c5e3fb0fc22fa40d4aa0b34.1668988357.git.kai.huang@intel.com> <5526fedd-fa54-0ad2-f356-94b167e6e290@intel.com> <0ebf26d1ee540b4e082b65c51cabe3327f6d51ac.camel@intel.com> From: Dave Hansen In-Reply-To: <0ebf26d1ee540b4e082b65c51cabe3327f6d51ac.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669641496; a=rsa-sha256; cv=none; b=YD8rLhX+xguoCpcNq9QX+EMPG65F9y4aqJsyDej8Yi1bPUjnOdRvoxyYb9pjjvB8IstZXu l8v8bPmCMyK1XytpiblneRpfTqnZcNgjInljZ+1FNU3EJrIwYG6MvwdJn9VYtDP5DYN/Q7 IIuuXX2SeVm8QhwWHiOaQsC0SwC/bVU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=W6PIU8Q9; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669641496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PQWiiak7y8p91UoHfrQJrU21KisS1c8SD1R5o7HnCaE=; b=UIf1GMLE5RgyYfIJw3bVD9YWjqB4ZcbIEbzAxmWjpSIz8iYLnzdg+WPzUAYwrKGk+RwB2w VRf4jlIvka0Gb9nXwnP5IB4K0BDjtVnDoS0bVw+o3IXwjyr0MGZJTsPbfLrVdgduxyr/85 G90AAOv8sWYkuStoQVuTe/lJ7Gs6N8g= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 295EF2001B X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=W6PIU8Q9; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: pefpx6s7tebnojd1ua8k944kbanjdzq5 X-HE-Tag: 1669641494-458863 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/28/22 01:14, Huang, Kai wrote: > On Wed, 2022-11-23 at 15:39 -0800, Dave Hansen wrote: ... >> /* >>  * Go through tdx_memlist to find holes between memory areas. If any of >>  * those holes fall within @tdmr, set up a TDMR reserved area to cover >>  * the hole. >>  */ >> static int tdmr_populate_rsvd_holes(struct list_head *tdx_memlist, >> struct tdmr_info *tdmr, >> int *rsvd_idx) > > Thanks! > > Should I also change below function 'tdmr_set_up_pamt_rsvd_areas()' to, i.e. > tdmr_populate_rsvd_pamts()? > > Actually, there are two more functions in this patch: tdmr_set_up_rsvd_areas() > and tdmrs_set_up_rsvd_areas_all(). Should I also change them to > tdmr_populate_rsvd_areas() and tdmrs_populate_rsvd_areas_all()? I don't know. I'll look at the naming again once I see it all together. >> but I also get the feeling that 'prev_end' is a crummy variable name. I >> don't have any better suggestions at the moment. >> >>> + list_for_each_entry(tmb, &tdx_memlist, list) { >>> + u64 start, end; >>> + >>> + start = tmb->start_pfn << PAGE_SHIFT; >>> + end = tmb->end_pfn << PAGE_SHIFT; >>> + >> >> More alignment opportunities: >> >> start = tmb->start_pfn << PAGE_SHIFT; >> end = tmb->end_pfn << PAGE_SHIFT; > > Should I use PFN_PHYS()? Then looks we don't need this alignment. Sure.