From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F8CC3601E for ; Fri, 4 Apr 2025 20:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 248126B0024; Fri, 4 Apr 2025 16:57:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D09B6B0025; Fri, 4 Apr 2025 16:57:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0481C6B0026; Fri, 4 Apr 2025 16:57:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D66C06B0024 for ; Fri, 4 Apr 2025 16:57:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 44AE4AC162 for ; Fri, 4 Apr 2025 20:57:19 +0000 (UTC) X-FDA: 83297571798.22.59881E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id E33AD180003 for ; Fri, 4 Apr 2025 20:57:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gswuXfyw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743800237; a=rsa-sha256; cv=none; b=oSoTDxfDRtSWTw0bsSs2eaMvC5OGiYsRQE6OHTwn/hCjtG/9FlbWO7kITgQTgskGSkTlMe NCSaydPLEfXGu32tDezY/Ze/KOU8T5wpwOzonmz7eZ/tSxfO6qfKUst699ml/3ywFmz+cO eFMVgJ77kz/gPcjJwHeiNp6qRxzDyKk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gswuXfyw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743800237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MphuJnClTuz/wgauAZ/+9UOOoNZwVFrAJq5GFOCDfKo=; b=GiUMwvV8UnnY22x97LIWBETbX9/3YDY+tgt+LZ8ODBYjo+rHfWGi7Oy3icKZvsnRj7/WRY tl046qOPtYnDwLJdOeyxsM9puvKjSU++ipDgZlfBhpMOj5HZ8sLlZvaT4vSMnnsEBFdBMF wvZZ2kvy1jHiscE3zldxB0EeL4i8S+0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743800236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MphuJnClTuz/wgauAZ/+9UOOoNZwVFrAJq5GFOCDfKo=; b=gswuXfywXEGk01K8pJJoQJXrEhQwgmi2fzrLHAqr4uI5/HVWqJcJ0a5NIGtjikv0+rvzQS /9cUjHo5aPNj/VUd1Eb1Jd4Sl/AZ1OcbjHPQkwysmAA/uY6MIQ0Wc00GmZxHd0iKxb0vWF lKwbUfI8lF5FZI4dt9wIeKQq6JAPMcI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-eUYI6vWkPNGlzlEgkSKydQ-1; Fri, 04 Apr 2025 16:57:15 -0400 X-MC-Unique: eUYI6vWkPNGlzlEgkSKydQ-1 X-Mimecast-MFC-AGG-ID: eUYI6vWkPNGlzlEgkSKydQ_1743800234 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43bd0586b86so14044725e9.3 for ; Fri, 04 Apr 2025 13:57:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743800234; x=1744405034; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MphuJnClTuz/wgauAZ/+9UOOoNZwVFrAJq5GFOCDfKo=; b=AiaXgQy0XMa0XrRXgVp6UF5zTLNiOxRWEd6cDgvT+gf2qGUqmA0+DY7LCdhcuuCR6r UhWpyaiD49nvVnJLloJTXChbu1WzZN71YgQQEdAbqBmKkFzCLgZmvMZlfUCd9A/0dUyQ hAK+HPPz1ookdGMQn+u++5k5cCV6zWn2EvQjmjxabElHM4cvihi0L8QiQNLRBoc0MVqj YE4uRbsGWjsR9ubMetHnzxTHVXLjy58ypYucOYWE/A6iEUHtnsi6hGU0GgUmi5iSnhRS H6atYP9pDrHOMfwU89d8QsW06VgnWuSA/1cns8DJ07zbbYI542nxvOkVthFOe+1UccRT HIFA== X-Gm-Message-State: AOJu0YxgLEuv0+swwne/+tS5xd0e97Ma8/ONXQteUr8KvHxLNyYtm78f bNFrtongA/v3HtX5W7C23++1mFOGywomLtbI6Lh3cmnJn9mi6sRsmh+7PL9f9421B7U2rtPDmvA BQnBjNGj+NgqPfGh1K3F0oJ93EOSy8cFlrH1Sq7b7u5yo32LRY2myyPZqWw9XWQ== X-Gm-Gg: ASbGnctfuL6TIY578l7PrDW2wmjc6Md4PUKcKtyTlHArBAQyoKyvIMwaEJDBWX7m06x bDuDp5hlbpsHkW5Yn5g2j724hb14JxqKuonnNDmqT4ubUOiiSTFlsKSOMyTgCuyCsMbnpFLnDWW N01UnvZLenzZNx1/XuMtaJZbrs/LJMqnwpDjNOPNNsQ2EEc8sJqjqLI5ZfvkicEFJLkDyiqh0IK rv87zi6sQ5Oz+gcR9DowwNCehAcNtyfRdyFQ6k1c7ih/EvE7M1C0AOf+KeUfNAwXpiJrT7AelwC fMC5Ek1zCQJmdIASx1Cu0NmSbm63RmPcSvMqGBQ9j38wPN0fukxZQfOGdsj56Xu1hIQ5EHzWOa3 aO7edc4CnL0BTq+RNP6ngG0TCY6EWlG4kyNFF8D6JhTY= X-Received: by 2002:a05:600c:500a:b0:43b:ce3c:19d0 with SMTP id 5b1f17b1804b1-43ed0da06f1mr38086215e9.29.1743800234000; Fri, 04 Apr 2025 13:57:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzTanrLml12tr3IDgF64xmkRK9hrhYqlKSSITwWBy2in93k0ucTZ0z5PncEDD99Q7+/SAkdg== X-Received: by 2002:a05:600c:500a:b0:43b:ce3c:19d0 with SMTP id 5b1f17b1804b1-43ed0da06f1mr38086075e9.29.1743800233684; Fri, 04 Apr 2025 13:57:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7900:8752:fae3:f9c9:a07e? (p200300cbc71b79008752fae3f9c9a07e.dip0.t-ipconnect.de. [2003:cb:c71b:7900:8752:fae3:f9c9:a07e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1795205sm59026895e9.30.2025.04.04.13.57.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 13:57:13 -0700 (PDT) Message-ID: Date: Fri, 4 Apr 2025 22:57:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] filemap: Remove find_subpage() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20250402210612.2444135-1-willy@infradead.org> <20250402210612.2444135-6-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250402210612.2444135-6-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eAcubrwYC-hLC56xUJPKsEFfZufi0bzGO5n-YwVMWi4_1743800234 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E33AD180003 X-Stat-Signature: 3iaha9p71etwor3efayk79a6zairmhdd X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743800236-449745 X-HE-Meta: U2FsdGVkX18ZKPiTZP6bcO0dBHS8CyaK5DNsq/AOey6BLPauaEztqX+l1AjhEg1rPxB3lwTwg32sCLruHquIatwl8qtLT4jqq4/ZqtcLtvTFtPRA4Fz6msGpQjQTo9FoplofmQ6HAPN0c+TbOnfOigCi0e3Irzx+B/erso8OVD3aIqcjoSxoGUzRnYuoCbdnwAJeh3WSTFXr88ut0QYbznvBPn/STh+xPQsfuma/IOo0W+IbyICVkQEYIVtDVCvdniJTuqHTShneMFa2DhlRj6dBZcC6UBP7JEspt310t+KMPzeoRSOtNWreyreqH41DvrdgO9GBLYBCIHzDXVg+cRx8fC0PZOodnn4kvWSZ+3ZT3xsQW33I3L6z6y7n+wZsv4FET8/TU0J9TkiXP+riMwhvCXln3vgd2XaMqeVfe6GuGv3LOiAHPdWmbbOVXi/5Fx540yfQStTE9hv2Rhwnq0EvEDvoWUtlD+obyVc1D/EzyD0ii57XTaLeV9gq06FHFLIjaSh8IVUB4ICN21ZdSGqPAUeH/dwSLkLZ9n/MSnE8xz5ws2OJGgngwLI/MKpxZsHTr0Lhh/5s4ZxpDPsiFxONxyMuhr0QbfLj2osQuyrKhyNprbpo8IpWSwAiy7PBmum0RnsYlhI61gjaWEpD9WJg7kS3jNMoZ3M+l69AnCZA43ccA4loSibR/ChDIWJWQdB5dUhcObZqkNm2xdbHOAEb6VvtNWBl9E+4nFJ1XKXoafWRC4Wk9rAxYnMvIHbA5XYDETMV6NWr2wvz+amanAZM9SJ8ccs1ZpiKFVVdanukXAQP8yjAhHffPjxMmyzOrrVeQMmeH+MSnTqx0VQe+PwUqYRbaHvLKRBOEudgkK6swjx06Bg8VBIGuW8ecvJaPnz6LaOwbmDic0WSqSxza9rGpBsy7CjpEKb60lDoveByVryLw/RKoQgtKwK6scNTVu1On4IssJGN0KEfETb mnARUoE+ sdtTlqpjZC1gU0FyNxdJAvC4qvtuJXCa/7CAsfO3HEPgobvP3RE+NSpm9kCxZRrW6OrofndFOPfwz57zoc1HYXE3JhSKw1t+uOHHSk9ELdNNu3Qb1DZNGExzgBcx7DtlPwQpTl4nPg4hL3E8yVZZoehRNX0E/EpkOe5DpXWstXMk7rXnCsTQoGLwTs1eInITocAQzBwsKKtMH1e7uXYcUxyDHd2Y5yGxpMBkuBzmXs2dcqpbzz4g98ypX2QDQ1IQfJrbWHFBcnc/cXPYzylKSb9BF+K06lT06IL9wGka6ZNf1wUNTtTdnuzKQHhCdBJZrvaxb7QdXbWIlErqLzxMRAoFNzluVduE3KiaKF74VxOqx1Tq2vOPr6jNXDp+z4u8pzO092UPeqL3OQhrhyFXt1ZY14cokoG2druexdnua2aCwWskdRrd0aotla/8Gb6dR19sFUk2cs4RadrjgDE6aeOwuO+qt4NbIL9mtlUOT+9AZTizhhavdXcckpDtxWoVog8hCAY1HFK7th3+6M1tKH6Xkiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.25 23:06, Matthew Wilcox (Oracle) wrote: > All users of this function now call folio_file_page() instead. > Delete it. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index cd4bd0f8e5f6..0ddd4bd8cdf8 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -945,19 +945,6 @@ static inline bool folio_contains(struct folio *folio, pgoff_t index) > return index - folio_index(folio) < folio_nr_pages(folio); > } > > -/* > - * Given the page we found in the page cache, return the page corresponding > - * to this index in the file > - */ > -static inline struct page *find_subpage(struct page *head, pgoff_t index) > -{ > - /* HugeTLBfs wants the head page regardless */ > - if (PageHuge(head)) > - return head; > - > - return head + (index & (thp_nr_pages(head) - 1)); > -} > - > unsigned filemap_get_folios(struct address_space *mapping, pgoff_t *start, > pgoff_t end, struct folio_batch *fbatch); > unsigned filemap_get_folios_contig(struct address_space *mapping, Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb