Re: [PATCH 5/8] filemap: Remove find_subpage()

[David Hildenbrand <david@redhat.com>]

On 02.04.25 23:06, Matthew Wilcox (Oracle) wrote:
> All users of this function now call folio_file_page() instead.
> Delete it.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   include/linux/pagemap.h | 13 -------------
>   1 file changed, 13 deletions(-)
> 
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index cd4bd0f8e5f6..0ddd4bd8cdf8 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -945,19 +945,6 @@ static inline bool folio_contains(struct folio *folio, pgoff_t index)
>   	return index - folio_index(folio) < folio_nr_pages(folio);
>   }
>   
> -/*
> - * Given the page we found in the page cache, return the page corresponding
> - * to this index in the file
> - */
> -static inline struct page *find_subpage(struct page *head, pgoff_t index)
> -{
> -	/* HugeTLBfs wants the head page regardless */
> -	if (PageHuge(head))
> -		return head;
> -
> -	return head + (index & (thp_nr_pages(head) - 1));
> -}
> -
>   unsigned filemap_get_folios(struct address_space *mapping, pgoff_t *start,
>   		pgoff_t end, struct folio_batch *fbatch);
>   unsigned filemap_get_folios_contig(struct address_space *mapping,

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb