From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C29C021B3 for ; Mon, 24 Feb 2025 01:19:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5B186B007B; Sun, 23 Feb 2025 20:19:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE3FC6B0083; Sun, 23 Feb 2025 20:19:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B84CC6B0085; Sun, 23 Feb 2025 20:19:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 969996B007B for ; Sun, 23 Feb 2025 20:19:15 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 46BA0A0DE9 for ; Mon, 24 Feb 2025 01:19:15 +0000 (UTC) X-FDA: 83153079870.02.D6C5760 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf25.hostedemail.com (Postfix) with ESMTP id E3732A000C for ; Mon, 24 Feb 2025 01:19:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740359953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJoGiBuKF25a7MExpr04P4fn/FslL++84ML9B+UF3jo=; b=SjAunCVpE4GVbBUdcPhWqtflH/CqJ0hX0H4OhWwo1IZ1mlefeFscn9lZVisHJQ5OXxyyuh wEGibTO18Yeh7V4uF5Pv5+MKQTFIiVy3Wl1iH0UvNjGvgHDbE1yCSnpIDoA40CTdcMxqox Rb1lAWIEAnS95H8KJ42QtzKVaPwaYQE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740359953; a=rsa-sha256; cv=none; b=oe8o+U2FFUl1xOQw64Ao2btwQNXfLgPANtrgheY04PXAUi2zMDH01g4zsV04to04iCG5US MEzooOnlYfJlyTy7lYqytAFKZZj2gQf5W9VUMStUcWEIlRR7TNnr6Tr9ns4LjuqM0O9XYp e/Mudt/YZbxcBeYMk4xfJPcRibU1BCY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4Z1ND35YXTz4f3js1 for ; Mon, 24 Feb 2025 09:18:43 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 872251A058E for ; Mon, 24 Feb 2025 09:19:05 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP3 (Coremail) with SMTP id _Ch0CgBnB8IJybtnlgKiEg--.53879S2; Mon, 24 Feb 2025 09:19:05 +0800 (CST) Subject: Re: [PATCH 1/6] mm: swap: avoid losting cluster in swap_reclaim_full_clusters() To: Kairui Song , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250222160850.505274-1-shikemeng@huaweicloud.com> <20250222160850.505274-2-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: Date: Mon, 24 Feb 2025 09:17:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_Ch0CgBnB8IJybtnlgKiEg--.53879S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KF4kKF4Uur1fJF1kCFW8tFb_yoW8Ww1xpF 93K3WDCFs5tryDKF12vwnFg34Y9r48KFy5JrWaqw1Skr98ur1SkrZrKr4rZayDur1kt34D ZF1qg3W7urs0va7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyCb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF 7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UWHqcUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Queue-Id: E3732A000C X-Rspamd-Server: rspam07 X-Stat-Signature: 4yw894eaxjcpnqhm879ekoq8p97we67b X-HE-Tag: 1740359950-669306 X-HE-Meta: U2FsdGVkX1/rRdz1Z9Myav286NwC07XWlWsksgQFVCKZyzEweqGRfX8Oacdwygi6gKrStooaHIcOdteSoiNto3AjqmfZagKp7oHbqddsMx98IBI2hLfWsgkYRreXoNpyOcfwTF6px1kgV2S6cWLHFJpaxrEPnbq8zKnuS4JU4Y+QWX/k7IxrQR555QRFr+lSLbO1n/9btFOdCNbeQF50CwC44u3MnyWC7u5292/H46G/KUe1+Wv3AjHSV5iSy3w4AFc8BptJBM5SuP1KFyNuL74R9t1YPVS5EHiLu2y8+9pt7MDjxVdYj7RkyTpphVgVCxELI0bFlBoa2j9w/nouv3IZnrF4r/+OisCeuS4RR79IJWkKReoEUaT6NdWuUopzO28QtLV6cwwdUO6sFtoMOBOeN8282eA9NGNT9+9gkNvR/0jxy0+MY70CA6jXzAkwHx/GszrrCUhA15xt4Xt0qbdX5orNJ33UbqqlPF1A7sn28cNpgMqjjF8vvQDWvmC1wANcQ/+1niYWNzYZDwWabv82RQmi6LWf2edCXJznNS5xfWvkwd9RJGGo5X090Rmrnd/mwWBDP5uxkq5URXImwOwRlD0qCc/btxp2LFolhyyAB6pHaQXLr9FWP7T82r7zdH6QnHUzsc9iDe2ctRAETyUsP2ogM7CBrtIqPL5uDhm2oLgXVroiW5VFDEUtb+G9HfYmpPSBXZT+7sOUel/miXdY8Y2HE5rd1sk1wGvUzy3PBQT2XZep9S7b5n6kjl8xOu1HpCrtA673Jf7Mku6ZIDX9VQ89TSPSIvFApGSjI91YkrJ0OHOESCfodR8pza8wmrqu9vUfkHFwltWLt5vjixvLr1PZU50GqcHY3CQZxd4e1rzjuRB6C48ZPcgg/UgNdHEkjLP+CZWc8vnh4rJhr/SLuVBCkeuggX5zILH6MphF/NTWfXQkYMrBg0Iw+g6yUCNAeo82E1ZNYaO9ut/ WOzlFgH4 KL+z1LS9Y3+w7cHUZz6WRY3z8s9wrWPsDQvSaskqBc9lR1SwDOMhWOW1qigUr2ou/vcuTsVKYsG7RDyASUbi6uM5Qd6njfKd8zjwz7tDF+ZIhIRya30i3s4AMmqLKEy78/hcFgIy2x+n0haBwjJmci9r7u6rH/g5xhXRC272xBENwWMSQgphDAeBUv/v78FEhIvKS2IqDHUeDHcSuQuJjECor+wjwIUnCr80Bp8DxY+3Bx9I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 2/23/2025 1:19 AM, Kairui Song wrote: > On Sat, Feb 22, 2025 at 3:12 PM Kemeng Shi wrote: >> >> If no swap cache is reclaimed, cluster taken off from full_clusters list >> will not be put in any list and may not be reused. Do relocate_cluster >> for such cluster to fix the issue. >> >> Fixes: 3b644773eefda ("mm, swap: reduce contention on device lock") >> Signed-off-by: Kemeng Shi >> --- >> mm/swapfile.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/mm/swapfile.c b/mm/swapfile.c >> index 34baefb000b5..e5f58ab86329 100644 >> --- a/mm/swapfile.c >> +++ b/mm/swapfile.c >> @@ -861,6 +861,10 @@ static void swap_reclaim_full_clusters(struct swap_info_struct *si, bool force) >> offset++; >> } >> >> + /* in case no swap cache is reclaimed */ >> + if (ci->flags == CLUSTER_FLAG_NONE) >> + relocate_cluster(si, ci); >> + >> unlock_cluster(ci); >> if (to_scan <= 0) >> break; >> -- >> 2.30.0 > > Thanks. A little nick pick, "losting" is not a word, I think you mean "leaking". > > And BTW maybe it's better to describe the result of this leak in a bit > more details, "cluster leaking from lists" and "will not be reused" > looked a bit scary at a glance to me. But realizing it's full > clusters, they will be moved back to a list if any slots on them are > freed, so the worst result is inefficiently reclaiming of HAS_CACHE > slots, we didn't really lose these clusters. > > We do need to fix it though. So other than the commit summary and > message nitpick: Thanks for feedback, I will improve commit summary and message in next verstion. > > Reviewed-by: Kairui Song >