From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC9FC433F5 for ; Sat, 16 Apr 2022 01:47:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52A8E6B0072; Fri, 15 Apr 2022 21:47:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E2416B0073; Fri, 15 Apr 2022 21:47:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39EFE6B0074; Fri, 15 Apr 2022 21:47:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 2BD556B0072 for ; Fri, 15 Apr 2022 21:47:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id E8A2780754 for ; Sat, 16 Apr 2022 01:47:39 +0000 (UTC) X-FDA: 79361055438.24.8DBE398 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf02.hostedemail.com (Postfix) with ESMTP id ECEC580005 for ; Sat, 16 Apr 2022 01:47:38 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KgGKf1Z11zYd67; Sat, 16 Apr 2022 09:47:34 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 16 Apr 2022 09:47:35 +0800 Subject: Re: [PATCH v2] mm/memory-failure.c: skip huge_zero_page in memory_failure() To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Andrew Morton CC: Xu Yu , "linux-mm@kvack.org" , "osalvador@suse.de" References: <497d3835612610e370c74e697ea3c721d1d55b9c.1649775850.git.xuyu@linux.alibaba.com> <20220412130102.024bf04f99baa2206772b423@linux-foundation.org> <20220415061645.GA3364289@hori.linux.bs1.fc.nec.co.jp> From: Miaohe Lin Message-ID: Date: Sat, 16 Apr 2022 09:47:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220415061645.GA3364289@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: ECEC580005 X-Stat-Signature: cz1o5xekan434so3erhnuhp1pnxtfgrm Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-HE-Tag: 1650073658-908637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/15 14:16, HORIGUCHI NAOYA(堀口 直也) wrote: > On Tue, Apr 12, 2022 at 01:01:02PM -0700, Andrew Morton wrote: >> On Tue, 12 Apr 2022 23:11:01 +0800 Xu Yu wrote: >> >>> Kernel panic when injecting memory_failure for the global huge_zero_page, >>> when CONFIG_DEBUG_VM is enabled, as follows. >>> >>> ... >>> >>> >>> Reported-by: Abaci >>> Suggested-by: Naoya Horiguchi >>> Cc: Miaohe Lin >>> Cc: Oscar Salvador >>> Signed-off-by: Xu Yu LGTM. Thanks. Reviewed-by: Miaohe Lin > > Thank you for the patch. > > Acked-by: Naoya Horiguchi > >> >> Thanks, I added a cc:stable to this. >> >> If anyone could suggest a suitable Fixes:, that would help the -stable >> people. > > The problem was existing from the origin of memory_failure, so the following > Fixes: tag looks fine to me. > > Fixes: 6a46079cf57a ("HWPOISON: The high level memory error handler in the VM v7") Thanks for your Fixes tag. But huge zero page is not even introduced in that commit. So maybe Fixes: 4a6c1297268c ("thp: huge zero page: basic preparation") which introduced huge zero page will be more suitable? Thanks! > > Thanks, > Naoya Horiguchi >