Re: [PATCH v2] mm/memory-failure.c: skip huge_zero_page in memory_failure()

[Miaohe Lin <linmiaohe@huawei.com>]

On 2022/4/15 14:16, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Tue, Apr 12, 2022 at 01:01:02PM -0700, Andrew Morton wrote:
>> On Tue, 12 Apr 2022 23:11:01 +0800 Xu Yu <xuyu@linux.alibaba.com> wrote:
>>
>>> Kernel panic when injecting memory_failure for the global huge_zero_page,
>>> when CONFIG_DEBUG_VM is enabled, as follows.
>>>
>>> ...
>>>
>>>
>>> Reported-by: Abaci <abaci@linux.alibaba.com>
>>> Suggested-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
>>> Cc: Miaohe Lin <linmiaohe@huawei.com>
>>> Cc: Oscar Salvador <osalvador@suse.de>
>>> Signed-off-by: Xu Yu <xuyu@linux.alibaba.com>

LGTM. Thanks.

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

> 
> Thank you for the patch.
> 
> Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> 
>>
>> Thanks, I added a cc:stable to this.
>>
>> If anyone could suggest a suitable Fixes:, that would help the -stable
>> people.
> 
> The problem was existing from the origin of memory_failure, so the following
> Fixes: tag looks fine to me.
> 
> Fixes: 6a46079cf57a ("HWPOISON: The high level memory error handler in the VM v7")

Thanks for your Fixes tag. But huge zero page is not even introduced in that commit.
So maybe Fixes: 4a6c1297268c ("thp: huge zero page: basic preparation") which introduced
huge zero page will be more suitable?

Thanks!

> 
> Thanks,
> Naoya Horiguchi
>