From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3516BC4345F for ; Thu, 18 Apr 2024 12:00:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3D5C6B0095; Thu, 18 Apr 2024 08:00:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AECCC6B0098; Thu, 18 Apr 2024 08:00:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9901F6B009E; Thu, 18 Apr 2024 08:00:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7B2F76B0095 for ; Thu, 18 Apr 2024 08:00:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2DCA7A2300 for ; Thu, 18 Apr 2024 12:00:06 +0000 (UTC) X-FDA: 82022509212.26.BC28082 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C71CA100006 for ; Thu, 18 Apr 2024 12:00:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UI8hMjtU; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713441603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LATllXZlJk+cYDGqNM/88KIOt+R2i5kafJXKmW3NbsE=; b=g22VeCosi+7AzOOe2L3bZzwz/tPkoKT6vuyVL6XkKjh3yf75qaZvyHNISUaSEXfyfZLMZ4 V6bDyPHARVa/Opt96QXlPD7WpYvaIK9BVifyC6/Zg7rAiiGirq4uoYSunNh3kSpZTyITXm jVh4HWYGaLjMVRgaKlAFS6j3SDZu1s0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713441603; a=rsa-sha256; cv=none; b=ebYT0EHDSKiJn1aC1Zm2wti+a7zyK1W8mF1mCLhH6jtNW1Me5uDHBYtKrmokGy8foCnk0+ /N1hOJ1iK4bEjK8NOfh/cRVm4hU9qXE9fXay1Vfc328/4ei2QVqgH/Wic9acWzEKPe1UZh vLBlr1JvFyisA2UYMQdaEBN6jN1/3jw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UI8hMjtU; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713441603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LATllXZlJk+cYDGqNM/88KIOt+R2i5kafJXKmW3NbsE=; b=UI8hMjtU53U9j5QftDi9Gf0ezvhi/CGc1PXdThTtgrOcEkDVHQ4oU8+POto0Etm/CEGUB0 HYm+UzlLFwPOqNvLGqVMkiXw80m4hG6xwm8RPMeUGcD5+7vQ1fFUEnT2pWMTHD50K7uu3w TxDgPmA0jHxotKVALlgNF1p4k6UpIu0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-P5cA2DQ_OD2tbn3pxRkhug-1; Thu, 18 Apr 2024 08:00:01 -0400 X-MC-Unique: P5cA2DQ_OD2tbn3pxRkhug-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41895b0a62cso6637995e9.2 for ; Thu, 18 Apr 2024 05:00:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713441600; x=1714046400; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LATllXZlJk+cYDGqNM/88KIOt+R2i5kafJXKmW3NbsE=; b=Zb4Y3pMs7m+j/pqoIzcFdiPKTlZIrIl2bgsZgzaUnVzsh35rZDC8EO0j8IPJ0T4L2M VTFUFuOam4asqJ+77Rz8eJZKzwtiMKJqLhFCcwDZzKx17PMLbU59f6PD7vmEOei6+etO jWgSOCqORZC87bP3c5+pcLoGdFpeXKSE2Va0KryenPxAx6QQbtuAKBspDmve+2Dywthg b07iraounKKgHovfsMv/TToGYCuEOEt9krcwTT5IOVEDnJbCImIe1fucbSq84TAqAnaO t91dW01q+wY5d0K+azMqkAUXPY/MJskj7jW8f4V73sDwBU6zWg3Iu8FoNFiO5iIwBWCw mAXw== X-Forwarded-Encrypted: i=1; AJvYcCVWpNwVhNyLIN9qEEQCuVMXppCyivsSLdLuUdM8EkeX8z7EA/OqXVe/w30dmiTTLNcuReYE7oo+NYpyC3lxA3pmU4s= X-Gm-Message-State: AOJu0YyBTcHqyq3yqI9QMNj1u7fynU6EmYPRC/1dPoRKug2vNio2hyVp 4/Tuv3Dc+IsNtZCiDnoZKev3dKa3m4akCFzyeLtJE0sldeWt+Wy9Y4aScJxVFTvaHRLnwBV3064 NWMUvPAZR4UCzOmepDR5MtyYHVSuU74qRax20Ozz111pp15fd X-Received: by 2002:a05:600c:354d:b0:418:f1d7:7029 with SMTP id i13-20020a05600c354d00b00418f1d77029mr713908wmq.6.1713441600515; Thu, 18 Apr 2024 05:00:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnU8PmTVYrjDUGIjLqcCgvjQnviIRRH7CDLJMwLooRGQ1pi28F9NTAUg+fX6jjd6oRIWufJg== X-Received: by 2002:a05:600c:354d:b0:418:f1d7:7029 with SMTP id i13-20020a05600c354d00b00418f1d77029mr713887wmq.6.1713441600121; Thu, 18 Apr 2024 05:00:00 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id fl7-20020a05600c0b8700b00418ed02cd58sm1387257wmb.3.2024.04.18.04.59.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 04:59:59 -0700 (PDT) Message-ID: Date: Thu, 18 Apr 2024 13:59:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 3/4] mm/memory: add any_dirty optional pointer to folio_pte_batch() To: Lance Yang , akpm@linux-foundation.org Cc: ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240418105750.98866-1-ioworker0@gmail.com> <20240418105750.98866-4-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240418105750.98866-4-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C71CA100006 X-Stat-Signature: hcsztb9uhusmcwqpie3nz5ci175fbeb6 X-Rspam-User: X-HE-Tag: 1713441603-649842 X-HE-Meta: U2FsdGVkX1/eJiM5ejlvAl+2eIPQS59nu7U8VLgWBskMKBMSTWnDw6DGtQXvOIZQ5lVpQkGVIqgNyJklplxY99o8mJrzuG9RWuL+yUKKKP6bbQpY7UNXTr/VEwNZa3A4pI3qzzKT11AnOZcMid9EW4AeyO5Jhp5TZkqOdtv0NAmK38/nyFGx03x5rjWC0562fRNjZQlLsCcky6VsiAWF22RcKaOXFrupdsPWit1eDMsItxd8k4DlPba5CZPEw0/f8qX3S57RhAGT/z/ydrpWpOc/w9JkmjmgvMnOTX6SgQbmdH7ag/FcMLXKbKTGDivjSBmfPwIpvPWZ6twswATpR+0B+PMajM9NbKkFZAYQzk52L49DEaqFmMlsSB5xPgxObcSaQbIPgLgUN4eBKj6SUTI0gfP0debwKOSLhjR+2bPh0Ax3SNd1CMfG2F2pWOh35XCZzZQlqkGcAbQrJCzfQaySMSmz3vF2Y7k6cbigsK+Tsdfsib7JykSJdHwQa3OF0YhxFAGyik/69IoxLSqrAm7bC2fu3BAieP20DJKqius0W21Zx/gAxz6XGbiIOnZBaQ824W2qQ9H9miEE6DPmEwL7ht+wQbkElqE2EQelg27Cjo+lbfh/Up8O37I3D3fX1Qu6FUbE3jkWbazZKxSTeCb96CEIMJH2L8wn2+zSjWe5wSf++bl9c1JTWDK3F7q8nGz+R5p3eMOBlOwFX8Cx/YigPrczZOSr445A/kZ8pIYYz0QPZ62DfvfM23NntawJ8JN6J7RdLpr9vudi6POv2y3FV/KIHkDvhIl9Ej+vO7bKb1MAiWJDgDxvI7P/Sospzoad1JYrS+T2hcnVKWp9iXQ6FMbICkBB4Nd403ewiq+nCWONWu/4feZpZA1dFP6PibdXol+KRfNcfU8v4Qg3XX80FnQndCESHKW/NySq3TCG3d+tjx7njURCQa1HwqsvmfZJm3cCYN7TMqyOH4I JS7tTrqr iz6CLDeo7h9yx17pLSnqycUcuqjFVwyNl+G7P6sPiq2xhTANHszn77viaFH2uHjbznOqC2L5XSeU7xs1DVN0WIN6THgk4jX4J/U7fX/3eVNkTaOWEWMC6684HQivOhyg/n2/eTvd29QIGOdDs/TDqq/3tv7kA5NiVHtbCgaEn4tLagq8iCkHl4XiTaEEES7WX69nrGMyturlQjus9lvsYj+FIxHlINk79zlD2WAI1xoWlKIjvVFmFBNAPC/PsuDZsdM1yKYz/sdgQ8R0DEPw83xLFXCZYgNpIWLw7soqU2ObzsCyFQDVK8ETLB+oa8unOYvJYvpDaYPTn0zNfNqsaJVRxmH5vEjjvGoztOTxr2qfmLVA4IttgBydqBrsi+0jV9DHexJmf6hTROiZToPOSuv6Yfh0zasVDq41yiHPIvMF4bvNcx7MqvTaR5uywQ80b27WOvlEk6nFCUpeQ0SAuuGhmu4l8XyN5WoLg/vE1fic3dVxxa8UanPXd1lWoo5wu1ugxLVr56g4JGhI09TdBrxCsCzuUzxGqKcv8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.24 12:57, Lance Yang wrote: > This commit adds the any_dirty pointer as an optional parameter to > folio_pte_batch() function. By using both the any_young and any_dirty pointers, > madvise_free can make smarter decisions about whether to clear the PTEs when > marking large folios as lazyfree. > > Suggested-by: David Hildenbrand > Signed-off-by: Lance Yang > --- > mm/internal.h | 12 ++++++++++-- > mm/madvise.c | 19 ++++++++++++++----- > mm/memory.c | 4 ++-- > 3 files changed, 26 insertions(+), 9 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index c6483f73ec13..daa59cef85d7 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -134,6 +134,8 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) > * first one is writable. > * @any_young: Optional pointer to indicate whether any entry except the > * first one is young. > + * @any_dirty: Optional pointer to indicate whether any entry except the > + * first one is dirty. > * I was also wondering if we should make that function return a pte+nr_pages, instead of only nr_pages, and then simply have the function, based on new flags, merge data into the original PTE. But let's do that separately. Acked-by: David Hildenbrand -- Cheers, David / dhildenb