From: David Hildenbrand <david@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-mm@kvack.org,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Laurent Vivier <lvivier@redhat.com>, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH for 4.19-stable 00/25] mm/memory_hotplug: backport of pending stable fixes
Date: Thu, 16 Jan 2020 10:35:42 +0100 [thread overview]
Message-ID: <c70b45f3-2559-6d3f-4ce7-ebf3d1df4c40@redhat.com> (raw)
In-Reply-To: <20200116092618.GA84509@kroah.com>
On 16.01.20 10:26, Greg Kroah-Hartman wrote:
> On Thu, Jan 16, 2020 at 09:59:44AM +0100, David Hildenbrand wrote:
>> On 16.01.20 09:54, Greg Kroah-Hartman wrote:
>>> On Thu, Jan 16, 2020 at 09:42:51AM +0100, David Hildenbrand wrote:
>>>> On 16.01.20 09:34, Greg Kroah-Hartman wrote:
>>>>> On Wed, Jan 15, 2020 at 04:54:59PM +0100, David Hildenbrand wrote:
>>>>>>>
>>>>>>> And why would 4.9 and 4.4 care about them?
>>>>>>
>>>>>> The crashes can be trigger under 4.9 and 4.4. If we decide that we do
>>>>>> not care, then this series can be dropped.
>>>>>
>>>>> Do we have users of memory hotplug that are somehow stuck at those old
>>>>> versions that can not upgrade? Obviously this didn't work previously
>>>>> for them, so moving to a modern kernel might be a good reason to get
>>>>> this new feature :)
>>>>
>>>> That's a good point - but usually when you experience a crash it's too
>>>> late for you to realize that you have to move to a newer release :) It
>>>> used to work before 4.4 IIRC.
>>>>
>>>> (one case I am concerned with is when memory onlining after memory
>>>> hotplug failed (e.g., because the was an OOM event happening
>>>> concurrently) - then memory hotunplug will crash your system.)
>>>>
>>>> But yeah, I am not aware of a report where somebody actually hit any of
>>>> these issues on a stable kernel.
>>
>> Just to clarify: I can reproduce them of course :)
>>
>>>
>>> Ok, let's start with 4.19 and 4.14 for these for now. Should make
>>> things easier, right?
>>
>> What do you mean with "start with"? Drop this series and not do the
>> backport, meaning people should switch to a stable kernel > 4.19 if they
>> don't want surprises on memory unplug?
>
> No, I'm saying I want to take this for 4.19, and 4.14 if you have it.
>
> But your original series you sent needs to be fixed up, I can't take it
> as-is for the authorship reasons.
Got it, will fix that up and resend!
Cheers!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-16 9:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 15:33 David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 01/25] mm/memory_hotplug: make remove_memory() take the device_hotplug_lock David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 02/25] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 03/25] mm, sparse: pass nid instead of pgdat to sparse_add_one_section() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 04/25] drivers/base/memory.c: remove an unnecessary check on NR_MEM_SECTIONS David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 05/25] mm, memory_hotplug: add nid parameter to arch_remove_memory David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 06/25] mm/memory_hotplug: release memory resource after arch_remove_memory() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 07/25] drivers/base/memory.c: clean up relics in function parameters David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 08/25] mm, memory_hotplug: update a comment in unregister_memory() David Hildenbrand
2020-01-15 15:38 ` Greg Kroah-Hartman
2020-01-15 15:41 ` David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 09/25] mm/memory_hotplug: make unregister_memory_section() never fail David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 10/25] mm/memory_hotplug: make __remove_section() " David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 11/25] powerpc/mm: Fix section mismatch warning David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 12/25] powerpc/mm: move warning from resize_hpt_for_hotplug() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 13/25] mm/memory_hotplug: make __remove_pages() and arch_remove_memory() never fail David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 14/25] s390x/mm: implement arch_remove_memory() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 15/25] mm/memory_hotplug: allow arch_remove_memory() without CONFIG_MEMORY_HOTREMOVE David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 16/25] drivers/base/memory: pass a block_id to init_memory_block() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 17/25] mm/memory_hotplug: create memory block devices after arch_add_memory() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 18/25] mm/memory_hotplug: remove memory block devices before arch_remove_memory() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 19/25] mm/memory_hotplug: make unregister_memory_block_under_nodes() never fail David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 20/25] mm/memory_hotplug: remove "zone" parameter from sparse_remove_one_section David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 21/25] mm/hotplug: kill is_dev_zone() usage in __remove_pages() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 22/25] drivers/base/node.c: simplify unregister_memory_block_under_nodes() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 23/25] mm/memunmap: don't access uninitialized memmap in memunmap_pages() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 24/25] mm/memory_hotplug: fix try_offline_node() David Hildenbrand
2020-01-15 15:33 ` [PATCH for 4.19-stable 25/25] mm/memory_hotplug: shrink zones when offlining memory David Hildenbrand
2020-01-15 15:39 ` [PATCH for 4.19-stable 00/25] mm/memory_hotplug: backport of pending stable fixes Greg Kroah-Hartman
2020-01-15 15:54 ` David Hildenbrand
2020-01-16 8:34 ` Greg Kroah-Hartman
2020-01-16 8:42 ` David Hildenbrand
2020-01-16 8:54 ` Greg Kroah-Hartman
2020-01-16 8:59 ` David Hildenbrand
2020-01-16 9:26 ` Greg Kroah-Hartman
2020-01-16 9:35 ` David Hildenbrand [this message]
2020-01-16 14:32 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c70b45f3-2559-6d3f-4ce7-ebf3d1df4c40@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mm@kvack.org \
--cc=lvivier@redhat.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox