From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE41C4345F for ; Tue, 30 Apr 2024 17:45:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2F4F6B00C8; Tue, 30 Apr 2024 13:45:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDEF96B00C7; Tue, 30 Apr 2024 13:45:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA7336B00C8; Tue, 30 Apr 2024 13:45:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AD1026B00C6 for ; Tue, 30 Apr 2024 13:45:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 74DF11608D4 for ; Tue, 30 Apr 2024 17:45:14 +0000 (UTC) X-FDA: 82066924548.02.3378D39 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf27.hostedemail.com (Postfix) with ESMTP id C675D4000B for ; Tue, 30 Apr 2024 17:45:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=C5MCou+I; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714499112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pybzdGcdEs63Bij7DWZmHPl3clx+Ov+QZxJvlEZLe1g=; b=kkhYEp0bnF+Qekn9EPrIoz4/J5CXoaRb4jf09QEUVzp4HnhaG1pmluW13SJhwOqQFomukm NoJcw8AZlWnDVgkiDluswrqdezBRSPHV5T5gYBoFILmWB3o0VYxecDkNrkoNid81nvmSvm U/WoUbWRjvw9mwX3RIxjvonmqViC/Mw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=C5MCou+I; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714499112; a=rsa-sha256; cv=none; b=fRXROu82r6aTQ2/WASLsIS/OHVXfnmH5lw139W3c0PcphOOgGNMIrIyb4Yf2+MzcUJnG5D XHfUeKVexnHEpFbcv91TPbdx5TkBPv2P3iN0ILVo2MqnYHBxUTIFLVf8uPRBPgBt8Mb4cL qVIuRlS2W14jcX10Koyg7HP2Uo67WXI= Date: Tue, 30 Apr 2024 10:45:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714499110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pybzdGcdEs63Bij7DWZmHPl3clx+Ov+QZxJvlEZLe1g=; b=C5MCou+Ib5hMMFkCmrDrgwVBFWJbmii5S72vI/X86+3XIb/SCBgGBWAn6Dbs4KQkBB7hbp DqHW8ACmPg7WVtGNqRJJwRHuXiqsbM8rZtmMDV4r3j3aCMIhEq6Mm/0RZ2lZB3J42ZL1CM lc7Gzxh3xMJ/g/TdeH0eWMYsBrTlAv0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "T.J. Mercier" Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/8] memcg: reduce memory for the lruvec and memcg stats Message-ID: References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-5-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Stat-Signature: w3h4m18a1u84dq9nmjahgmwpqgc7qirs X-Rspam-User: X-Rspamd-Queue-Id: C675D4000B X-HE-Tag: 1714499111-104166 X-HE-Meta: U2FsdGVkX1/Yn/UGgkkOLXni4zXjLWboEFemJ2dg3Rl/jLTyZVB7cols20g9u40r9QkzM6hr/rS7rbhOlq3+OjTMLvX0NzOEeX4EJKPofHlycrUupBJgjh+34K9L9AAkb6paEC4p2t1glcbE1YEROiaVdaxjJs1tp4/EoUk/DKciyjAH+GrzMayp2rF3Bs2Y1eD9LcVXgAo4pZTbiVUrE6zOFdPzTJ4MAQSA/RI7XPmNIxrj+EXvo4/oSzGPl3l/zMVFqI/NBx8r/nrtdmYLtcLuFqqpfcI46z+7qp8IvA/VrKKYZ4xtEDQwWSQyGJxbLzqQQSUb2aQoSYRvyt4f5Iz2YjJdGaWw3BAN4AVwgVe1JQsIid0EA9IqDJaBn6f0FPifeloslamKFyZatJnmjbWCcfSIKX7Uk0nAJRHbtTvgHl42sHAZ+fu60/BrM+ja0R1iL/xqPCd2kaz+Sbmb8YAVrxMsF2lJhjZVANSUMTWEDk06nOEhLzpSBL9hpwyrTnH74dsKSQhxSxdaEPIVDz7/davPIRmoqeecH52igTHXdl598rYITfNVnWtdZkVcOpbXH2Lj7zIPQTWvYfuvj2Cc1gVeSMM3KEgwZ82G7fqIovGhSauZVeDpbNoooXx5z4xB+0i9GsWaKL8zKSz3qsT8h0S8r8RUy7klleHbv3/DMhIapxI5/eVZzpM9yheEgt9N7O091HiEpn3oLEq6E8N/3S1uH1iwdEnlebUHGE9MgBNiyovy5NPTO7gfRJr/huJvHXlortGHI6DuGkNhhWatdcYMNB5fYqrdWD0M0BU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 10:30:51AM -0700, T.J. Mercier wrote: > On Mon, Apr 29, 2024 at 11:06 PM Shakeel Butt wrote: > > > > + > > +static inline int memcg_stats_index(int idx) > > +{ > > + return mem_cgroup_stats_index[idx] - 1; > > Could this just be: return mem_cgroup_stats_index[idx]; > with a postfix increment of j in init_memcg_stats instead of prefix increment? > The -1 is basically for error checking but I will do a followup patch to initialize the array/indirection-table with -1 and remove the subtraction from the fast path. Thanks for the review.