From: Shakeel Butt <shakeel.butt@linux.dev>
To: "T.J. Mercier" <tjmercier@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Yosry Ahmed <yosryahmed@google.com>,
kernel-team@meta.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/8] memcg: reduce memory for the lruvec and memcg stats
Date: Tue, 30 Apr 2024 10:45:06 -0700 [thread overview]
Message-ID: <c6hxrlzj7ycrcodkmq4hrbxvdpcqet2wvckjit3xeewxjkavwp@zb2uxoxeqs6p> (raw)
In-Reply-To: <CABdmKX0jGpZ4VSvQrLDB9ntLEb-tJTWFEfVLC5ukkZDi1CK2yQ@mail.gmail.com>
On Tue, Apr 30, 2024 at 10:30:51AM -0700, T.J. Mercier wrote:
> On Mon, Apr 29, 2024 at 11:06 PM Shakeel Butt <shakeel.butt@linux.dev> wrote:
> >
> > +
> > +static inline int memcg_stats_index(int idx)
> > +{
> > + return mem_cgroup_stats_index[idx] - 1;
>
> Could this just be: return mem_cgroup_stats_index[idx];
> with a postfix increment of j in init_memcg_stats instead of prefix increment?
>
The -1 is basically for error checking but I will do a followup patch to
initialize the array/indirection-table with -1 and remove the
subtraction from the fast path.
Thanks for the review.
next prev parent reply other threads:[~2024-04-30 17:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 6:06 [PATCH v3 0/8] memcg: reduce memory consumption by " Shakeel Butt
2024-04-30 6:06 ` [PATCH v3 1/8] memcg: reduce memory size of mem_cgroup_events_index Shakeel Butt
2024-04-30 8:33 ` Yosry Ahmed
2024-04-30 17:29 ` T.J. Mercier
2024-04-30 6:06 ` [PATCH v3 2/8] memcg: dynamically allocate lruvec_stats Shakeel Butt
2024-04-30 17:29 ` T.J. Mercier
2024-04-30 6:06 ` [PATCH v3 3/8] mm: memcg: account memory used for memcg vmstats and lruvec stats Shakeel Butt
2024-04-30 8:34 ` Yosry Ahmed
2024-04-30 17:30 ` T.J. Mercier
2024-04-30 6:06 ` [PATCH v3 4/8] memcg: reduce memory for the lruvec and memcg stats Shakeel Butt
2024-04-30 8:41 ` Yosry Ahmed
2024-04-30 17:37 ` Shakeel Butt
2024-04-30 17:41 ` Yosry Ahmed
2024-04-30 17:49 ` Shakeel Butt
2024-04-30 23:00 ` Shakeel Butt
2024-04-30 23:07 ` Yosry Ahmed
2024-05-01 0:50 ` Johannes Weiner
2024-04-30 17:30 ` T.J. Mercier
2024-04-30 17:45 ` Shakeel Butt [this message]
2024-04-30 6:06 ` [PATCH v3 5/8] memcg: cleanup __mod_memcg_lruvec_state Shakeel Butt
2024-04-30 17:31 ` T.J. Mercier
2024-04-30 6:06 ` [PATCH v3 6/8] mm: cleanup WORKINGSET_NODES in workingset Shakeel Butt
2024-04-30 17:32 ` T.J. Mercier
2024-04-30 6:06 ` [PATCH v3 7/8] memcg: warn for unexpected events and stats Shakeel Butt
2024-04-30 6:06 ` [PATCH v3 8/8] memcg: use proper type for mod_memcg_state Shakeel Butt
2024-04-30 18:09 ` T.J. Mercier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6hxrlzj7ycrcodkmq4hrbxvdpcqet2wvckjit3xeewxjkavwp@zb2uxoxeqs6p \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tjmercier@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox