From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 757EBC25B06 for ; Mon, 1 Aug 2022 11:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 735316B0071; Mon, 1 Aug 2022 07:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E52D6B0072; Mon, 1 Aug 2022 07:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 585D88E0001; Mon, 1 Aug 2022 07:37:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 46A446B0071 for ; Mon, 1 Aug 2022 07:37:33 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1814C1A09C7 for ; Mon, 1 Aug 2022 11:37:33 +0000 (UTC) X-FDA: 79750823586.07.6C72B73 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 640F51200E4 for ; Mon, 1 Aug 2022 11:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659353852; x=1690889852; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=H/cNs/T6KxOCSuS/MaY/NqlNQR3n2uQf3nDlTJr6XOE=; b=fLEkbyT+1CsnxBXJEnTrE8C0RZrYm9foo5rqj1gdvCszWBeextIQhzCj 4aiX4MhJ5HxUXt+yOgwgBfW6BPFaumhkIlhzwz1Tf8T3Cm2/Yw9ZtqIEC Y2KAAW4BJOATN/RmrfswBFzIKYQkbINWLrl7rIpL9C5OVGH1k7lBdQf95 k=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 01 Aug 2022 04:37:31 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2022 04:37:31 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 04:37:30 -0700 Received: from [10.216.43.100] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 1 Aug 2022 04:37:28 -0700 Message-ID: Date: Mon, 1 Aug 2022 17:07:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext Content-Language: en-US To: Pavan Kondeti CC: , , , , References: <1659330397-11817-1-git-send-email-quic_charante@quicinc.com> <20220801052848.GB18790@hu-pkondeti-hyd.qualcomm.com> From: Charan Teja Kalla In-Reply-To: <20220801052848.GB18790@hu-pkondeti-hyd.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659353852; a=rsa-sha256; cv=none; b=f8qfht1VvAVuS8R+X5Z2TvSiUvmOyRUgzhQZClr6sSC70YxCeNeeYsor1qTMyqMv7UULMQ eEDE4slTT4uDIr9xaYTlvB3ftTjf3hP7kd9tltv4kEiHH6qtXlgAJt2DcB1nhXH+qsCQxf 0A4bCOJWiRdCRhqNO3xv26XdAkVudlw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=fLEkbyT+; spf=pass (imf29.hostedemail.com: domain of quic_charante@quicinc.com designates 129.46.98.28 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659353852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H/cNs/T6KxOCSuS/MaY/NqlNQR3n2uQf3nDlTJr6XOE=; b=W8nqobDpnWGf/k+1TjVJPbkWrdrkpD4o2Sq/yQXjLlPRv/vFLQ4RkNcS0wPAgDcqePWbu2 vey+pkEoqLXIYM5UYvOWFCrMYdjXIrVArFVQFe6yzJMvh/ip8avqyabyjMGsGSC4ACbcw0 FO/+EXw4qx0q67CkKK6z/wf0o/vbZ+s= X-Stat-Signature: zkiu8t9r7fbeqionnr1qhjf6pbja6df5 X-Rspamd-Queue-Id: 640F51200E4 X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=fLEkbyT+; spf=pass (imf29.hostedemail.com: domain of quic_charante@quicinc.com designates 129.46.98.28 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Rspamd-Server: rspam03 X-HE-Tag: 1659353852-235171 X-Bogosity: Ham, tests=bogofilter, spamicity=0.015233, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks Pavan for the comments!! On 8/1/2022 10:58 AM, Pavan Kondeti wrote: > On Mon, Aug 01, 2022 at 10:36:37AM +0530, Charan Teja Kalla wrote: >> Remove unused variable 'nid' in offline_page_ext(). This is not used >> since the page_ext code inception. >> > Just to be clear, should we say "drop nid argument from offline_page_exit"? IIUC, drop is something we use if it ever considered to use earlier. Remove is when we are completely getting rid of it. Anyway, since it is just terminology and there are already some tags on this change, I will let Andrew to take the decision and if he decides, will give V2 with changing the commit message and collect all the tags. Thanks, Charan