linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Charan Teja Kalla <quic_charante@quicinc.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: <akpm@linux-foundation.org>, <david@redhat.com>,
	<mhocko@suse.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext
Date: Mon, 1 Aug 2022 17:07:24 +0530	[thread overview]
Message-ID: <c6c8f2b3-fe19-f6e1-4540-89d395b82ea8@quicinc.com> (raw)
In-Reply-To: <20220801052848.GB18790@hu-pkondeti-hyd.qualcomm.com>

Thanks Pavan for the comments!!

On 8/1/2022 10:58 AM, Pavan Kondeti wrote:
> On Mon, Aug 01, 2022 at 10:36:37AM +0530, Charan Teja Kalla wrote:
>> Remove unused variable 'nid' in offline_page_ext(). This is not used
>> since the page_ext code inception.
>>
> Just to be clear, should we say "drop nid argument from offline_page_exit"?
IIUC, drop is something we use if it ever considered to use earlier.
Remove is when we are completely getting rid of it.

Anyway, since it is just terminology and there are already some tags on
this change, I will let Andrew to take the decision and if he decides,
will give V2 with changing the commit message and collect all the tags.

Thanks,
Charan


  reply	other threads:[~2022-08-01 11:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01  5:06 Charan Teja Kalla
2022-08-01  5:28 ` Pavan Kondeti
2022-08-01 11:37   ` Charan Teja Kalla [this message]
2022-08-01  8:47 ` Michal Hocko
2022-08-01  9:07 ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6c8f2b3-fe19-f6e1-4540-89d395b82ea8@quicinc.com \
    --to=quic_charante@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=quic_pkondeti@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox