From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E81CCC71136 for ; Thu, 12 Jun 2025 15:36:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89D686B008C; Thu, 12 Jun 2025 11:36:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8758C6B0092; Thu, 12 Jun 2025 11:36:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 765806B0093; Thu, 12 Jun 2025 11:36:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 579BC6B008C for ; Thu, 12 Jun 2025 11:36:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0F02AB9792 for ; Thu, 12 Jun 2025 15:36:45 +0000 (UTC) X-FDA: 83547151170.05.D1F221E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 986594001A for ; Thu, 12 Jun 2025 15:36:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L/OBEGdZ"; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749742602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j6FlpRtQvUpUW4eY/0JVT6f8fEwPoGbC3/HdECX0jnY=; b=JpCkvRrBxEL2IyPIoV+t2ksnJOjGgTQ0L5DrPFmr0glSfkTa/p3sSUL+itWyhCJu0LB/us vJFoCljBhP84btbuOdf1I2S3NF0cmWPByatFQaSZK7mpZyINnIgTXSKbrrWXc6d0nrR50Q FOn6Qr/JLczEjJrgYifZn/yO4P0K0xQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L/OBEGdZ"; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749742602; a=rsa-sha256; cv=none; b=dss8X7/eR9WYQyQMp6DasSlV0LWDEKQSu9i3bm6MVaZed7Eu8rVP6MWvU0OVZT1LQB3kDo BOugoYLlpsFajbq7Ckedi328xcLj7GjQ2TQysGZpOrhgGtBn2b0p/Tlq9vqLyDt5x/FTEP MlrtPHBt5ArlykpPET25fDSFeSqtd/g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749742602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j6FlpRtQvUpUW4eY/0JVT6f8fEwPoGbC3/HdECX0jnY=; b=L/OBEGdZMgnTaI2wHJecKRZh/rhJ7Ok31AxRT9O6v3qsw4Ali17mSR4EIzDfLDoSUCqAG0 pg5Rz3qQv6cZsVFKCU6szxdmxBJFd6SmeUSypMz6U0kJSpBr/UeU9/fwBO2o82vay7qYvt sETtot6aGVkr+7zIvPO2h+1NG1u38Fo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-M2eScs3BPjKVRimmL704bg-1; Thu, 12 Jun 2025 11:36:39 -0400 X-MC-Unique: M2eScs3BPjKVRimmL704bg-1 X-Mimecast-MFC-AGG-ID: M2eScs3BPjKVRimmL704bg_1749742598 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4e9252ba0so707628f8f.0 for ; Thu, 12 Jun 2025 08:36:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749742598; x=1750347398; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j6FlpRtQvUpUW4eY/0JVT6f8fEwPoGbC3/HdECX0jnY=; b=BwYoPghWwTDjddrxwFZGOlDoNiPOd+IEdzX67dum/RpKdIxnzCyk9yM4/TMg9JHuFb +4xYV8MR+Xh7UZ/4qmwADYNQKrxbLqASOP70XuTHfsOoa9yvwdOU4vYAI/OP9Ogi7zW3 /KmNAz8vT7vDXpdMBXAA907amze3hs2Ktoi55s2I91h9tXvLlTy5/UA4DeB/Yg/lZDz2 nqTRFPYPQ0EwFYlJ3hYBDkN84sTZASXNuyjLc2FTxryIspL8IP+M1Al1iH79fqXXAfRM BI3l2P4qtCFvefZSEJ1EStvrtevZfvQm9PMDFoIzTPI08UOu47FcFNqCpriTw42hTosc w4Tw== X-Forwarded-Encrypted: i=1; AJvYcCWMfaxvsGusAMW2xnv1V0l1s0Ucu7Mh2qdCDOPK++uuA5vhjOgY2bPK+MlmdeZoSuIqvrN3VAZNxw==@kvack.org X-Gm-Message-State: AOJu0Ywqt5OYw1jiATOSQNVIsrLkyWrA0zuUeSPpBy7z18mOBE8bZuGm o+14OBICo9Ybc3+BBupyxMoPnNBKKpFDbAfyFyFZisu+W7s2nLAipbioYQoLf6OOEXfmKFhC2Ct bO9FbUAemrFiW8vFfnrVdnjyFS2NkeKBVCe7OKZ24B4pOjXLaqpAj X-Gm-Gg: ASbGncvlTJlrIamb1hhYEzOeFVYoGyFY09NwFRkCJO2+63F11EU+fT/OazA/YinOqLG p9BzpPOtDo43azIkv5cpx6UwOWJJxeRSe1sGIsLHj4zP3jpEIViN7Bllo/bR8X/Io+t1m2d+i8b dLjo2xwbhcsX8mSM0/0KWCQ6GdkChbNf/pB49+Mxc8kxhFl/zbK/zSgsvH+qY5xocmtWLgR+zun 5HKbVBA9hcbWXBsBA6vu4weCLMoGuy2C7CBS43G9UteoL6B8hLN8Fnuy+jXe0YRtwmJsIyGsRe/ Zq4nsxzx61JPWsR3k/kQ/XbLbjVWYx4mrF1VRJXR6zLYMfgo7WBw4cqFo2gNz2651pb2dakSAWn jZalvpj961nwJqe9SfP/lMceoP3gZw7pNeZAIsLykIiw7HFenKA== X-Received: by 2002:a05:6000:250d:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a560748c21mr3810543f8f.2.1749742597922; Thu, 12 Jun 2025 08:36:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOfhHJckHdYmyAgxwpqTeZ7FZww/fQGcBhftw9Ckx1CdxgEKuklHbnz03HaXMemBKSqLkt2w== X-Received: by 2002:a05:6000:250d:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a560748c21mr3810526f8f.2.1749742597569; Thu, 12 Jun 2025 08:36:37 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e253f64sm23645205e9.27.2025.06.12.08.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 08:36:36 -0700 (PDT) Message-ID: Date: Thu, 12 Jun 2025 17:36:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador , stable@vger.kernel.org References: <20250611120654.545963-1-david@redhat.com> <20250611120654.545963-2-david@redhat.com> <02d6a55b-52fd-4dae-ba7a-1cccf72386aa@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <02d6a55b-52fd-4dae-ba7a-1cccf72386aa@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ViToZGAbEJOfWza-lOdI4V-xjfxYbNMXMlVmtN37b30_1749742598 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ywf3ubfpf7ejrnj3ys74o81cft4fekwr X-Rspamd-Queue-Id: 986594001A X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749742602-390496 X-HE-Meta: U2FsdGVkX19mEr2aQuS9mvVUkHTOjFNuUXvlH3XCqdH/zENaT1YWm+dpVOrc0VcjK3kDyBuGHYJpTyOpO36LMIqruUo/qE+ivtHioT9TfC7QzQvpY6CbPQIdw0BUhyxy4XZPCZ4vaXnkd9ZWj6X4jBs9W15CYZIQXrHqthlEsNtUVEGjrI0M+XvmD7IfU8vaSdarFNdOaLslc2tgiYpj326Jde9WH3i/hRFPMxPvkW3cvZjW4cMX+/YEcJ45Bx8Cj+Qji8/cFB8GGvJZj5uK4v/FpYsAE6Xi2rW/Hx86T649ehOGeZvwZiATnBJ8qgA69MXY9xcqrmG6Ne+7jISykrR/yaHvJhvQ3SGUI24lIOqheiIAhA1a8gX4k6n+H8TVpYakpixOjW0e0dn3l6ZqcPL9GsoILgSqzEmpv45NQGJe98Kk75fYUlhodqgJbTzMPizsbDNIiDmAYn8jTOsnAaIR3VpiFfM/nnT/HXW575vVGD9KqR+JjHRSYLbKBc4VrnwD5ChB5xcSizH6U8Mmc4eXUBadZZE+lqy2B5TxE/ZNS1tiEUwJiZIe3PQR0V2KDgLzhLPZGqaFD1BZdcLYXmWqxOOu2mZttl9J3v94VdX2ZKO4bcPoZ7zuyZavp/W4AANhN9NC4bSfnOu/y9rqRkTgxqyFwA9rm1RiSrlHH0nVWnx0+AYeeLfbFoVt8XWnnalk7+5VbcEHMszXuLKKS34pbnAldmi7OKWhLNyFNm9ybzN7INgymF8KdCccweHTSpAqOIqbNG/gH3YvwGddyDz0acSeCEYvRSionY8dTKtnngd2U5rDW9dfyMsFtZmu//5QRmK0YYbAOlGfaGr1XIY3iZFGUX2c1fjjAQuIgvPkkefvOwoHjCXjGmyadrC/gmpY4+e4D0Q0dIL0T2BNbFeX60rHI6cJYFm6vqDRDz4fDPzvl6Zjo7DTkhQQjTEVOBpl345csuKMfl9M7iJ eedJwfvK YyU1MocJKzSWVjJMz8c/lHOGJtDcekL3PPrLI5S/hjLbhe46YhnscorxmLZm6qKcWCZ34s0jcW6w8IhR6iBuYwV6PvdB/emHum/8HpQY/AxIndIkEkWPvs8PdGwFowvYnEToVhTKH3yOABRADLNDgd4ztFaAlRgnFuHyStjO9MlmAId9AkZ1XFpmScYCEKVEX/4lFQ2+lyLkk4cJHI3okE0fzdeVtXo1axXNWTNdmZMEsH6B5ByEP0sv4ZRLwZX+WwMN7miJQ/oY8nu3qZi88/xXRWQR6HTwXEEgZRIYvK7mqSx/OgOWZf3Yfm6uvSlL8v5Peq9s374JCnlCkOBf2LqVmfiwlJfVPAy2xhi9EvTECXGGVdKwxCK0IOc7BFyazdXEFJaAgTIJhtdnZ4bzSy/iM2ZbYDVZr49i3v7KBxJzyIn3vWycC3tCVhCNcJdLBn74zgt6eNfQ62w/Iztt9TPkTs/f/fgPV9+NaAuS/l1lMQhshT10Emqal8P+UzJcraNRJLqHeXIKJMjg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 17:28, Lorenzo Stoakes wrote: > On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: >> We setup the cache mode but ... don't forward the updated pgprot to >> insert_pfn_pud(). >> >> Only a problem on x86-64 PAT when mapping PFNs using PUDs that >> require a special cachemode. >> >> Fix it by using the proper pgprot where the cachemode was setup. >> >> Identified by code inspection. >> >> Fixes: 7b806d229ef1 ("mm: remove vmf_insert_pfn_xxx_prot() for huge page-table entries") >> Cc: >> Signed-off-by: David Hildenbrand > > Nice catch! > > Reviewed-by: Lorenzo Stoakes Thanks! What's your opinion on stable? Really hard to judge the impact ... -- Cheers, David / dhildenb