From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E231C369AB for ; Mon, 21 Apr 2025 20:53:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46FFD6B0008; Mon, 21 Apr 2025 16:53:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41E5B6B000A; Mon, 21 Apr 2025 16:53:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E6C46B000C; Mon, 21 Apr 2025 16:53:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0BE316B0008 for ; Mon, 21 Apr 2025 16:53:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04EC2140EB7 for ; Mon, 21 Apr 2025 20:53:46 +0000 (UTC) X-FDA: 83359252494.15.AFA5C6B Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf23.hostedemail.com (Postfix) with ESMTP id 0452B140006 for ; Mon, 21 Apr 2025 20:53:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="x2cmEz/y"; dmarc=none; spf=pass (imf23.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.175 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745268825; a=rsa-sha256; cv=none; b=oRHgTNIfI2UUAbFgAETpEF03zG2DYupDV52VO9oauYLfhzrBvC1l0vpxW83JGM76jD0GkK Kn6g5cmRe+7bRaQ0j9D3xCHeYubRZMTn34LPhyz3jqI/0GT1cpgnhR6dkmBMeNtRNLB+br 381OlrNim3OuLmUjl1iF8PfLQlG8YGY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="x2cmEz/y"; dmarc=none; spf=pass (imf23.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.175 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745268825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGyMbdplm0VqgEXwZTM797av09Qdwt4xl1Ent3Qyi/Y=; b=GrIxYMtoG/lXdIBUHXkPPoSxAqMlPKoOxCExgEp25q3MpH/XAA+JI8NUF6sO14cy8SozxL g2R/B1P929o1sr12ld/mefcugIskrHr7YHN9+zBjxdwbtr3ok5i3OiF2zBKyc7Pqa4rMuU WDNjHk8Vs4HsLdEqAEhgkDheYsWKeFc= Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-3d8e9f26b96so28718655ab.1 for ; Mon, 21 Apr 2025 13:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1745268824; x=1745873624; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XGyMbdplm0VqgEXwZTM797av09Qdwt4xl1Ent3Qyi/Y=; b=x2cmEz/y9hBNL2rUIwJXI3KcSaa5IwFlOgXPwbQCma698ijcK9ykcJeZWeNcApSW/K /gDUrJcDg7nX9dXZLvb00Of1hpdWpMKRcXsrp4gh6Li3O2I3pKB3PyBLmWrSRoRKBI5f 57vGKQcfHwdGt5znwC3x5XgCZ7eLNc5fbuUGJgTeJ1+6hXms3KXL7Vx0Y4qdBD12Yw3q PDxPZn3RoweegVcbIIwEw4XUp9dKqWUuLJApXjCyIcekC0uvDskyVJptoMX3M3E5akFh yCZwWOv/L9JmuUp8YR0tmUMJSzlw5wUu4DeTBCKPmz3Ed9JmfKdUm9Ak/lD2eXsYKJYo bBiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745268824; x=1745873624; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XGyMbdplm0VqgEXwZTM797av09Qdwt4xl1Ent3Qyi/Y=; b=TkbOkn5gjY5+umL6h014z43gjHGrDKDRlOdq3IJMbn/BPpqBNqao3g9/6TTvYX0q3X u4g82PivVPdc+YBEmXik6SvDIqBMFZZ7Vz9RZTM0gT1O7lcUaqpYXx4HChLvuFw+0KAm no9a0SKc5JdENQ2Ke5wc3qa76feKxxTmH6SJmNjdvGBuEP/lWmbqtq6jWcnY8hKWaZdv 4C9caVgvAesGrZPuLbLBXnBElLgVGwtlhvTCg6fBlQJ3vs/u7lKbBbTIABXeh/HzhYS4 4k8vsdDzpA7OWxwjCNIbk5kZCxWu7cjMuHp/RaNcmEZBF1N1rlS5wZro9EUv67/gMK4D Y0XA== X-Forwarded-Encrypted: i=1; AJvYcCUYvYWDcbuaCIKgv+gBR1meyXsEwPvVG2OZX+rsGDs/zxp2qJuzR8uyo243eGCztrnCPj4tk3P85g==@kvack.org X-Gm-Message-State: AOJu0Ywxxak7h2BMx3MrIqaCDzGA9A6XZgEFLzcNGOHzN5kxTP5MrmYE 6P55I5KobfA2Mtzx0Pg/ukT1U0+ig1i3AFQaI/HnBxNjCYx+849yuGcyx3YLJHQ= X-Gm-Gg: ASbGncuZODDfOW0Z0WcMJr5kY1owedxxAFYYVgfbmYsimtIsco4+nJcUtNpu0O4ucXZ RFDNxjGHUKiKoQBwaYMPP7ca5fw5KIzwJfmw+P+Ht87K0HU+zDVH3+4+y48ff2Cpf+tViw3vyPd 9sggYFBZzBBVKlwz/nC129zFEB9LLSRaQhzhOdvMPRQHIxHIsgikllNe1kt6l8NGTvCArS8q9Np oB8eds2ASiwjKSFj/XYbg+emfEkxvR0aMjPWbbTjrPS0mszZvTgqP2YQqwfo1Lh/bXJAPicrdXp +pwKNshN/9AUMSb7qcHZMlLjd8m+eCucIgvvxdqtynpOHzI= X-Google-Smtp-Source: AGHT+IHvDgGfgDUOOapB200WZpV48HaZ8dVbhYH++As1bmXpZNufg6G1tVLq51Z1vXwqN7Cc8UQGrQ== X-Received: by 2002:a05:6e02:3002:b0:3d8:20a3:5603 with SMTP id e9e14a558f8ab-3d88eda87bfmr139248725ab.2.1745268823944; Mon, 21 Apr 2025 13:53:43 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d821d1d700sm19572275ab.12.2025.04.21.13.53.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Apr 2025 13:53:43 -0700 (PDT) Message-ID: Date: Mon, 21 Apr 2025 14:53:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHSET V2] block/xfs: bdev page cache bug fixes for 6.15 To: "Darrick J. Wong" Cc: cem@kernel.org, hch@lst.de, shinichiro.kawasaki@wdc.com, linux-mm@kvack.org, mcgrof@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, willy@infradead.org, hch@infradead.org, linux-block@vger.kernel.org References: <174525589013.2138337.16473045486118778580.stgit@frogsfrogsfrogs> <8cb99c46-d362-4158-aa1e-882f7e0c304a@kernel.dk> <98e7e90e-0ebe-4cbc-96f3-ce7f536d8884@kernel.dk> <20250421205116.GF25700@frogsfrogsfrogs> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250421205116.GF25700@frogsfrogsfrogs> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0452B140006 X-Stat-Signature: ob97rjmfnwjmecx7xr44bkw6r9z9gd1m X-Rspam-User: X-HE-Tag: 1745268824-747979 X-HE-Meta: U2FsdGVkX18rSsL7nNRJzoSstrAcxmRZt1Xj1Tk7zWaFhNpgVEEd1tGqqMD+mn8ggzJnNdTJFhmBdXp8myPSLfn6HnXQygJNYToALFDIJhwsoNxYXyGoZloERzQhLb7bsn7aKmyW8blo0BXR3xPW/vdRVmRdI5X0vSUgYtnUufOaJZLHe31E9RqHUGbGsDDEiiUB5ZXd5uYUgSv4piIK6c46FT4riHn5IjrIb5oSM6Lnk8LXqaH3qx+GBn6O5isjEdsdcB08lCX6LyM37FQ+CXLDAvhEXfBg3gR30EDn8UkkoIlY3SwzS5z5z+FdXcpW0MUzGZMzfYtnBP2zMpoGA88rCVhueyXj3NXYer9+9KUm/R2cPf8u4X1alWBeF93NZyjMuVhAXJHZGuv13yV6BqeUVXlFa88WIX5sJ/XJiWQ4PD6iH6WfpaYG/u1N/70juKHERt1qoGKz/hAQD5pdVpN+tanHqmfwuwqd2KlOKWHaRi5ph49frVgl/3x8Ma347UagnT5j/VGNrCvnxfQKWm0NhPIUSUl3YuOiMuE5gEFpnZo4m9/QEHI+1+QQ2JW/gwjgs2YOTnVZFGVeNBOT1HOh9RbHfqFjb6aGFJUaSCSza1pADHUX0wnWUsixi7ZeIesnOqnMg64t8iwhFXb+vaiisccCEjz8N+JB7/V1CqDAiSbZKN9+taCOGJmQpnoCmV5LmjSHuYp9RTf1kK9rjMb08ifmfdB/6YCyusBgHmNrUXOqltUekOKO/1LXQ5+sEkVoyBR/ZTjlJiUO786UpWWGrby6VL8PGGuphF/IKGccnFPdzNkBVOxWZfeOZSUh3QeNpMPTPOQK8K7rU074rFPT/rcay91Ffq6zMD7ZzVQ/jYTUaszWROmsCAUII487batOoTUIsZoV01PkSKqgw0tU2vs7KxohpX/x7wvidUOCxgSgahRDatsIYlUxa9RZ9Dlgb1t9AWxEWHcOCaS 0KCnWcui TFzSnPDdYPSTH/caRZIdg6Pam3YxU9dodH/RFcb79EMpClGLelob3vE1Iq3fFFjpMrMID9iBRDYU++SOesEfug9pmubR8C2UGPckksTGQJff5L42pN69epMa166N/x864VqP3R9H0qqJ4501YLwPnH7Bs0ZvTHyxZlAWsMS8Btf1pVGvtSscBtndhvbm+9e+qBlUo3wdfhjvJkr3UngKvqumaDvodgSwswSiwMblwaZg7VkjUJbgbfP9yFDmyEFT9QLHiQkmkuwhf2/fG0u/MtVHB2lVBmzrEcS1jjdnd+arIXVkQ9zCV2gROGd4Vn1AIbQleIvFiEqRbZEWHhMZbBs29HuPwwEMFwSOg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/21/25 2:51 PM, Darrick J. Wong wrote: > On Mon, Apr 21, 2025 at 02:26:54PM -0600, Jens Axboe wrote: >> On 4/21/25 2:24 PM, Jens Axboe wrote: >>> On 4/21/25 11:18 AM, Darrick J. Wong wrote: >>>> Hi all, >>>> >>>> Here are a handful of bugfixes for 6.15. The first patch fixes a race >>>> between set_blocksize and block device pagecache manipulation; the rest >>>> removes XFS' usage of set_blocksize since it's unnecessary. >>>> >>>> If you're going to start using this code, I strongly recommend pulling >>>> from my git trees, which are linked below. >>>> >>>> With a bit of luck, this should all go splendidly. >>>> Comments and questions are, as always, welcome. >>> >>> block changes look good to me - I'll tentatively queue those up. >> >> Hmm looks like it's built on top of other changes in your branch, >> doesn't apply cleanly. > > Yeah, I'm still waiting for hch (or anyone) to RVB patches 2 and 3. Maybe I wasn't 100% clear, but what I mean is that patches 1 and 2 don't apply to the upstream kernel, as they are sitting on top of other patches that block block/bdev.c in your tree. So even if acked, they can't go in as-is. Well they can, I'd just have to hand apply them. Which isn't the end of the world, but the dependency wasn't clear (to me, at least) in the sent out patches. -- Jens Axboe