From: Jens Axboe <axboe@kernel.dk>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, hch@lst.de, shinichiro.kawasaki@wdc.com,
linux-mm@kvack.org, mcgrof@kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
willy@infradead.org, hch@infradead.org,
linux-block@vger.kernel.org
Subject: Re: [PATCHSET V2] block/xfs: bdev page cache bug fixes for 6.15
Date: Mon, 21 Apr 2025 14:53:42 -0600 [thread overview]
Message-ID: <c6bcce15-647c-4de8-aa01-6cd3ec5bf904@kernel.dk> (raw)
In-Reply-To: <20250421205116.GF25700@frogsfrogsfrogs>
On 4/21/25 2:51 PM, Darrick J. Wong wrote:
> On Mon, Apr 21, 2025 at 02:26:54PM -0600, Jens Axboe wrote:
>> On 4/21/25 2:24 PM, Jens Axboe wrote:
>>> On 4/21/25 11:18 AM, Darrick J. Wong wrote:
>>>> Hi all,
>>>>
>>>> Here are a handful of bugfixes for 6.15. The first patch fixes a race
>>>> between set_blocksize and block device pagecache manipulation; the rest
>>>> removes XFS' usage of set_blocksize since it's unnecessary.
>>>>
>>>> If you're going to start using this code, I strongly recommend pulling
>>>> from my git trees, which are linked below.
>>>>
>>>> With a bit of luck, this should all go splendidly.
>>>> Comments and questions are, as always, welcome.
>>>
>>> block changes look good to me - I'll tentatively queue those up.
>>
>> Hmm looks like it's built on top of other changes in your branch,
>> doesn't apply cleanly.
>
> Yeah, I'm still waiting for hch (or anyone) to RVB patches 2 and 3.
Maybe I wasn't 100% clear, but what I mean is that patches 1 and 2 don't
apply to the upstream kernel, as they are sitting on top of other
patches that block block/bdev.c in your tree. So even if acked, they
can't go in as-is. Well they can, I'd just have to hand apply them.
Which isn't the end of the world, but the dependency wasn't clear (to
me, at least) in the sent out patches.
--
Jens Axboe
next prev parent reply other threads:[~2025-04-21 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 17:18 Darrick J. Wong
2025-04-21 17:18 ` [PATCH 1/3] block: fix race between set_blocksize and read paths Darrick J. Wong
2025-04-21 17:19 ` [PATCH 2/3] block: hoist block size validation code to a separate function Darrick J. Wong
2025-04-21 17:19 ` [PATCH 3/3] xfs: stop using set_blocksize Darrick J. Wong
2025-04-21 20:24 ` [PATCHSET V2] block/xfs: bdev page cache bug fixes for 6.15 Jens Axboe
2025-04-21 20:26 ` Jens Axboe
2025-04-21 20:51 ` Darrick J. Wong
2025-04-21 20:53 ` Jens Axboe [this message]
2025-04-22 1:19 ` Darrick J. Wong
2025-04-21 20:57 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6bcce15-647c-4de8-aa01-6cd3ec5bf904@kernel.dk \
--to=axboe@kernel.dk \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox