From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA8AC433EF for ; Tue, 26 Apr 2022 16:13:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF8406B0073; Tue, 26 Apr 2022 12:13:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA7CA6B0074; Tue, 26 Apr 2022 12:13:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6F136B0075; Tue, 26 Apr 2022 12:13:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id C74336B0073 for ; Tue, 26 Apr 2022 12:13:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8A4C4269EE for ; Tue, 26 Apr 2022 16:13:54 +0000 (UTC) X-FDA: 79399526388.15.12674F6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id C852B4004C for ; Tue, 26 Apr 2022 16:13:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E8AB41F380; Tue, 26 Apr 2022 16:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1650989632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fepc2oLMPvkExB4fn/i4OKfIvMt6S6PP9V70SD2F7kU=; b=wS+JSk5j+c0FTM36Co61iaBnZ8JHEsNpqXK7cqHDhBcbQfxbF7hg3KoObU3e4Kw/pfi5ku 3RK1CrBqiPGMKL7Ccv4q1ia0QrO1GKfT+T5ljYxvM6QqdaWhz4XyJTZgHAciI4XUvRUZVD xaVzQOXrIOG/rSs3ZAMiuLUflmNX/Bs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1650989632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fepc2oLMPvkExB4fn/i4OKfIvMt6S6PP9V70SD2F7kU=; b=M5mxhJCILPqO9yQAXPCFVhsXea/nT0ctWg8rt5zDpf1I0GP0hYMT00TbUR7T6u/YGPqZtS w33Oc+1i2mGQVrBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B841B13223; Tue, 26 Apr 2022 16:13:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IKbVK0AaaGK0egAAMHmgww (envelope-from ); Tue, 26 Apr 2022 16:13:52 +0000 Message-ID: Date: Tue, 26 Apr 2022 18:13:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 07/23] mm/slub: move kmalloc_large_node() to slab_common.c Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Marco Elver , Matthew WilCox , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220414085727.643099-1-42.hyeyoo@gmail.com> <20220414085727.643099-8-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20220414085727.643099-8-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: zcayooogo1x6siqmcesb4gu7kza67qkh Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=wS+JSk5j; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=M5mxhJCI; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C852B4004C X-HE-Tag: 1650989629-166055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/14/22 10:57, Hyeonggon Yoo wrote: > In later patch SLAB will also pass requests larger than order-1 page > to page allocator. Move kmalloc_large_node() to slab_common.c. > > Fold kmalloc_large_node_hook() into kmalloc_large_node() as there is > no other caller. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Vlastimil Babka > --- > include/linux/slab.h | 3 +++ > mm/slab_common.c | 22 ++++++++++++++++++++++ > mm/slub.c | 25 ------------------------- > 3 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 6f6e22959b39..97336acbebbf 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -486,6 +486,9 @@ static __always_inline void *kmem_cache_alloc_node_trace(struct kmem_cache *s, g > > extern void *kmalloc_large(size_t size, gfp_t flags) __assume_page_alignment > __alloc_size(1); > + > +extern void *kmalloc_large_node(size_t size, gfp_t flags, int node) > + __assume_page_alignment __alloc_size(1); The usual :)