From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A625E77179 for ; Fri, 6 Dec 2024 08:45:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A60C46B01F1; Fri, 6 Dec 2024 03:45:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A10CC6B01F3; Fri, 6 Dec 2024 03:45:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B1956B01F4; Fri, 6 Dec 2024 03:45:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6726D6B01F1 for ; Fri, 6 Dec 2024 03:45:03 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 20598AF7CD for ; Fri, 6 Dec 2024 08:45:03 +0000 (UTC) X-FDA: 82863898068.20.A92BB33 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id A4B73140011 for ; Fri, 6 Dec 2024 08:44:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JotCSAB7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BfH1nutg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JotCSAB7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BfH1nutg; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733474683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tb8uI57vA4swAfU9ooVXXbspnSjer2Hc6kVaFnBNXnc=; b=KeX8GcJd/MSkXcX7h5W6Hix/FnsNtKa9w2j2AuUdxp1jK4cKw+cuvAsF+Kp5Io4ODJ++gj u3InjsW3xU2YQhDls7qbvK6RLc0aqPxfP8WmldicTjYc8VHcq0DERrXU34eKud1mjMxnDW 5js9/A/Y+/ltNIkybWaupfN9ii/gRIc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JotCSAB7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BfH1nutg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JotCSAB7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BfH1nutg; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733474683; a=rsa-sha256; cv=none; b=5dmNmxQrvip+wrqNw7GUylmWg151a2rtrtPCdGJL72IBcnKgEAqRbAppRI0i8u/1DU0Md2 tW+yIe/uig6GDHhz2+UdTSOyhLjB39IP/OgM6SZ1EuL+jAgDK9C3IJ3i0bJVDX0ar+I4T/ 6kVirHXWEAd3AgOE5eQNULN/P01FxDE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 06B7D21182; Fri, 6 Dec 2024 08:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733474699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Tb8uI57vA4swAfU9ooVXXbspnSjer2Hc6kVaFnBNXnc=; b=JotCSAB7aVmk2QTwcK/nHG2Khyg6hx4UAq4IRxWO7UzH+gZSzGg0wVj4EcJ9+bJltP7iIg gZaN8PgYVxPfF7qFDeO0tgcXXUIQYodHx6+i99boWPEcT0CxblY/sVwYQgVrfNiptFBndo aH0bxaj8+Jp2rYcnbic6UNEgBACUNJM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733474699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Tb8uI57vA4swAfU9ooVXXbspnSjer2Hc6kVaFnBNXnc=; b=BfH1nutgaHiKt5hP6DKYDYb+dFh3YcnjlUOQTr+RIO2UY9h7qnN7oDBfvktZewAEBErgBl rALMglahQ1f5R3CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733474699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Tb8uI57vA4swAfU9ooVXXbspnSjer2Hc6kVaFnBNXnc=; b=JotCSAB7aVmk2QTwcK/nHG2Khyg6hx4UAq4IRxWO7UzH+gZSzGg0wVj4EcJ9+bJltP7iIg gZaN8PgYVxPfF7qFDeO0tgcXXUIQYodHx6+i99boWPEcT0CxblY/sVwYQgVrfNiptFBndo aH0bxaj8+Jp2rYcnbic6UNEgBACUNJM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733474699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Tb8uI57vA4swAfU9ooVXXbspnSjer2Hc6kVaFnBNXnc=; b=BfH1nutgaHiKt5hP6DKYDYb+dFh3YcnjlUOQTr+RIO2UY9h7qnN7oDBfvktZewAEBErgBl rALMglahQ1f5R3CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E19A7138A7; Fri, 6 Dec 2024 08:44:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1mekNIq5UmecfgAAD6G6ig (envelope-from ); Fri, 06 Dec 2024 08:44:58 +0000 Message-ID: Date: Fri, 6 Dec 2024 09:44:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next] mm: don't try THP align for FS without get_unmapped_area Content-Language: en-US To: Kefeng Wang , Andrew Morton Cc: "Liam R. Howlett" , Lorenzo Stoakes , Jann Horn , Christophe Leroy , Rick Edgecombe , linux-mm@kvack.org, Yang Shi , David Hildenbrand , Ryan Roberts References: <20241206070345.2526501-1-wangkefeng.wang@huawei.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241206070345.2526501-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A4B73140011 X-Rspam-User: X-Stat-Signature: 8tzpjttpsud46gpzk811fxad7443gh6q X-HE-Tag: 1733474689-93154 X-HE-Meta: U2FsdGVkX1/CaM0VcHgsXOyjTVsRlpqgWMigrw1q56BGEjdyU2+FSSTaG8eSfwqnOqTQYJorp2QKTH4lGupFj9oFucm4hoQpiwt7+24J9HvZ77Lo35HJawHscf1Z1xuKYa4jaGCfZMDWpD0FzGrDKIAd+ivck3BYcRXfRsjz9pBZ6/mDgMWXpdu3V0eGNyhWc1nBVJK1VbiwvXs2hHdxwIrUmAnfUEpsIv7UXG4jaZrOnDWgHyvXcjXMg0hHK4n3C8wNcJWxwGx8xvlVrIBTYLAbFzm0k18fvaKQtCo4YQ1bkggpDON7dGnEo0w9lOiemXL2j7czarEqfqvqgDoxvEs3ibGnFeOO+4tlfdoLe6JU86nDxtg/g2++376bG3sF1WOhmNI41EUKRvDhRMGfwW3+1tDuc8NIH7QGrFuq7XGYfYxUSP+92UayC4guDIYVUksi3oe9FlXxScfomZpEW3HG3PtGZ+CNTKD4cQorIiXdfyX4GrJg42OsFIREQpNsWdLO7ecZSkfB3MocpXLkKewYrhbf1yT7UDXcVULiTlGFO5pmoX5id3lkcQ4obaKc2K8FT/6mBcc2p7maRTefJ4umTggCrp0uC4T+U2V5nqHxhi/pYp+sOS4wE31ZTMesYbneLm/XbdlKxSOn86+HrtFfjnvFc5cxGaver6M6qMXbs42dV8v6nTauScpcIeH+C6vRLutn09LVYFf0cb1Wzt8F92/CH/Q40Ige5eBx0c8yibVQr3Ms8I8pRaALBO7chk8XRMMeZRqFdTXqjvaIuEDk0wf4GXjcPfykeLs9S1FimOQShyyH5m8LjjxOSOGdiSPC51AYoURwQ5V5nX9n6bnBVBu7zqMM5iesn1gYBQjX7SP65Orfdn+iUm0hiLh8r9nMQdbRvjoS+JuVCw0C1KCP71YMoPo+oCepVJGuz4pL39Q43MFjLzJJo6rbAtNN4rp+2BhctFyQ/l9w8Kj 94X5x12J MH8dxqxeDVCnwnhvlZEe/COpQb17a6h5JnWlrZTrNw+GNOi5/csWJ9chEZDMyykH6V0hnE4Rt7t7ymeKxJB14O2hNOM1Wfd3ASHMCDFoCyUgWxs0dCFeBM/5S0GW01wyQF5U8HiD7XUaTmNdS0tDW6Yo+L1oYYhOFVYPh/pdYgrTkUFOkpe/t50vop1vfSyFsoW5jBL22MveyfPoMz7StL6B538xs/xS1dkVKVQdtnWBaMtuhu8hiNmRRW9FnZABK+JWF+o/TXIfeUu5fCYiLMeGZhG/wXFzXn3OCgHaEyequgJ++GAE+Bz5VINu5MOKiCW59s0XFtcNLERblRdARrwujdFXmIjV0YVDw8zK0tSRRZDU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/6/24 08:03, Kefeng Wang wrote: > Commit ed48e87c7df3 ("thp: add thp_get_unmapped_area_vmflags()") > changes thp_get_unmapped_area() to thp_get_unmapped_area_vmflags() > in __get_unmapped_area(), which won't setup get_area for anonymous > mappings, but it leads to always try THP align when file ops without > '.get_unmapped_area' callback too as the get_area is NULL. > > Since commit efa7df3e3bb5 ("mm: align larger anonymous mappings on > THP boundaries") only want to enable THP align for anonymous, adding > !file check to fix it. > > Fixes: ed48e87c7df3 ("thp: add thp_get_unmapped_area_vmflags()") > Signed-off-by: Kefeng Wang Yeah, well spotted. Cc stable as we did for the others? Reviewed-by: Vlastimil Babka > --- > mm/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 1c6bdffa13dd..b373486bd1c6 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -782,7 +782,7 @@ __get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, > > if (get_area) { > addr = get_area(file, addr, len, pgoff, flags); > - } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) > + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && !file > && !addr /* no hint */ > && IS_ALIGNED(len, PMD_SIZE)) { > /* Ensures that larger anonymous mappings are THP aligned. */