From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED30CFD30C for ; Fri, 11 Oct 2024 10:00:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A90D6B0095; Fri, 11 Oct 2024 06:00:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 033516B00AB; Fri, 11 Oct 2024 06:00:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC6546B00AD; Fri, 11 Oct 2024 06:00:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AD75C6B0095 for ; Fri, 11 Oct 2024 06:00:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADD3DAC40A for ; Fri, 11 Oct 2024 10:00:32 +0000 (UTC) X-FDA: 82660877040.13.AB6E5A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 438FC100026 for ; Fri, 11 Oct 2024 10:00:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZC+xulml; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728640701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vp7dthPwN3lu06VHKMw+C4LzgRyUSe/x2FuqZhLQAIg=; b=awsgirPj0aSErOhe9OVU+rHFRIn2aViSb9tsO8HnB0Gq9vwqjTIpiuNz6A2V29Co6D1XRa nIO1TvV1lb2MxzGbMORrcuU0pRqSfJZbj6XcX2yub/fggjd2Zb9xCu/zHuWiDCfW7PYS1U 8k7jsJYQBhZiE4l7tRNkfQ4150T0CU0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728640701; a=rsa-sha256; cv=none; b=aRQLZgEbyfxoGXssi29F/mzQkQm9NpMt7K8sN18NDj6n2BqtsZ4+ZMOqXcVUU8QEZHDx/+ fESStBWdkAux19SHGm/V/hok+ZuUdFwZY6FOY7dIH4Yj2FajAdWMRIDghAh5hw7gpDZbbu Nuk0jDQ6ocKo7eKWCQF31Tq+S55+WdI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZC+xulml; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728640838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vp7dthPwN3lu06VHKMw+C4LzgRyUSe/x2FuqZhLQAIg=; b=ZC+xulmlBprxYEdSlmBsP0xoMxdmBddPI+l4L5HMdnOzGaEIwJiWPC2wCXnNz5HRhiuvc9 QdALDhE3cLfk2U76mEmegagHhiRRLUgfSrxA2YMObiY6mehW+DQiGuXjnZNJ9GQOgNeKnr SvbkzsFY+KfcSDwnrbDmBqE2SzAN1uo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-cFQlqzo2O0qCY5_mryTsug-1; Fri, 11 Oct 2024 06:00:33 -0400 X-MC-Unique: cFQlqzo2O0qCY5_mryTsug-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d5116f0a6so523449f8f.0 for ; Fri, 11 Oct 2024 03:00:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728640832; x=1729245632; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vp7dthPwN3lu06VHKMw+C4LzgRyUSe/x2FuqZhLQAIg=; b=UM5w1x6Mc7AGqtayvtjG6JtTuFlRn+XJHithUngnY6/TVZkCTRIQqNObjZIPmMmLpZ Ph4uV908GNslk/KjlQFE3aWp4APIoC1oOdZ4El2r9fLy6Z6wQ/CbslfhMaO2RqX4tjv5 lQ6qRt5K8lEjaJmE3kLUAhmw/pULdjG86iMG+dJHX2fnhazZ/F1fhLwlQ7Bq014Qm39+ Jy/oyW0okM2F0Mdu4VKKSo3wDYZX7rEF4Kt/A4WH1A08fqUqMVGr3MXsu8IT+8Ey7eN9 49DIpdU9RBR/Fa5X6Oj0g3LU1I3ynL2uuhX6s1ByJZn/4oKqmnuDigy+/+YfCED/bgn4 28Kg== X-Forwarded-Encrypted: i=1; AJvYcCWCGRDJdCFlCF/jXy6zPJ0sVict5lowJFiPOrdz6CuG1hVwpRE4LaCmwmj/wzOP0ZvUmMvbh6IMaw==@kvack.org X-Gm-Message-State: AOJu0YwvZTBLXukO8Cn60ox1xO4bJkwBjJU5N7QFpn9raa6psVCz3wlK jxZZnfp33FtLdn6A4IDCu2CNjw7jRAJup+W9PAl1SiVaPa7aWD0suIpXl3sVKgZJ0G5OyvivPD9 53WZ/PZGlXOMFKBbMp62MOoIqHmdGUHramnPBnXNh75lUShvQ X-Received: by 2002:a5d:5cd0:0:b0:37d:4ebe:1646 with SMTP id ffacd0b85a97d-37d552cab54mr1168551f8f.48.1728640831938; Fri, 11 Oct 2024 03:00:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbM9oge1PUngV8GjZ3bUCxCNxjTujjg7KG+/MpD9Zs3v1DwnQ/4T7rCkThqwxskv8TJ8t+1g== X-Received: by 2002:a5d:5cd0:0:b0:37d:4ebe:1646 with SMTP id ffacd0b85a97d-37d552cab54mr1168535f8f.48.1728640831552; Fri, 11 Oct 2024 03:00:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:9100:c078:eec6:f2f4:dd3b? (p200300cbc7499100c078eec6f2f4dd3b.dip0.t-ipconnect.de. [2003:cb:c749:9100:c078:eec6:f2f4:dd3b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b2780c1sm3575915f8f.0.2024.10.11.03.00.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 03:00:31 -0700 (PDT) Message-ID: Date: Fri, 11 Oct 2024 12:00:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: huge_memory: add thp_vma_disabled() To: Kefeng Wang , Andrew Morton Cc: Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Matthew Wilcox , linux-mm@kvack.org References: <20241010061024.1846220-1-wangkefeng.wang@huawei.com> <20241010061024.1846220-3-wangkefeng.wang@huawei.com> <726cddb9-b6b3-46fb-9ef4-a29ef2360de2@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 438FC100026 X-Stat-Signature: w1pkyokfqas4izs45fq1sdzwgczf51zb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728640836-674051 X-HE-Meta: U2FsdGVkX18V2xuZG1hZu+PUKwvgN3obATWTFPNnrIxauysdYhdSJC9Vl5KHSCcoPFfEQrkLheK1O6JSZi3RRNceH+JgjHwvbowbTNRdJGETSy8nVTr7RNlI8FZzcQ2GQuDhmgbsE2t2awYj9OQNJkDv8WdlETXKe1v0K4Lq4mSDrYzKVyTMpRvh0x8WLc+sqQuN8ONTbyDmiAilTDxgMc9SZhoO0T1lF99uyJ2ojKRS0QO9x3ZlEy5BuUktjtQlumBX1rEO9a33qeFswBbkkBGHg3/fA1sZHEuib4aQVI3F6EAq4OYe4huwGtXRjdQaUJ8NR3mF1/6IRrrbC2UYx/6fO2GooZ+sQWCY4xszgpkxViy70UFWC8LWDz3iEW2TAPYP+if3fX+4eFdb2vZJ0NB9LsIcxYx4e7xNqRSj4RnxhsXL2tsjcQS08ekpv6KggqzWmaUnhg3UneBuB0Gk59GIsVajX7r8Z34BuqHEKT6b/mVOm+I8WW5NkG6VfcG5J8mJgg8wbuwOgIMcVxxiPbscCYGmXkvLAqwLVDX6JaeIgFG3PzHGEbiOHxno4RlV20tJQ+B+59+JBZtIFgOaTFwZimzrPaXjBLlF0ghbw2XklixFKMQuMVbaLrGUkz/dpj4U5cAAEL+E6N1P24lhj6nrTNxVf/MDKgtmwZLJk5XG0Rl21c3DvcVqRP6IZTeq0SbRaiH7dzatjnKlXnORWklc6Ad87xwOJAn/5UdNqDzOLFckg6KLnnOTSFW7fCORY95Whgn1y6NvSkmXdjfV3mshloDIHAo3TgxkZqPjJdQuMN+AXn2GmYlwBukGBdNqwM0leKN1l6cRo2jebRSYgHniWUda70MC6gEqPglLuObzYi2dfHkL7Xx9NByeWKcTQue/XNhqwTASH84zCb9mE6Xf3ja3Xm/rwfhzEk9YyzjswSMxEaf1+2RSdK4NddCB5jdvpBsI79hVLGvv3dv 1yjf1eZA FebTbmDte1fPaHaDugxRfE94yKxNKaa3ksP7q6XDYBwRHOgjCv4nLJojQK3KSWth2QdkY25fUB1n0VGF8fDCMVEui19KAJP63gw0n58koxKEO5w2D/z9LDq88+vHvo3lw3Whqk2fTshuOdtBMbLpP7/GpWptniYCKLOnVF3CsQIDellzQQKC5pktO+ccENohRO1X931DPCRnZFT8xnM75+hWE1wyWPa7yvruSoGcPhHkL/xxMw1bxTqlTVAQV+nfjrHE5827b1w9FAe1dg0NE1dsgzZn4/dyN2HwWBYdKADZaKBm0Yd4d1nFudHIczpDDS5OiiBVD5ic3cvA+KRb4yh+QezDo/SQARHMH31BYm/Pfkp9sBfTkHQyjeb/gP3fvXqjtosIbKXF1oTOCsz2iehlmVIjW6F5d6qD5XsEhcACgttLW1I6R4X8Bo86Um3atiTEOuCOAyFwmGYwUO7586lIuzPrD+XyqZtRFmwfJ5jiLs2YlTsgzv6SPmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.10.24 02:40, Kefeng Wang wrote: > > > On 2024/10/10 22:53, David Hildenbrand wrote: >> On 10.10.24 16:41, David Hildenbrand wrote: >>> On 10.10.24 08:10, Kefeng Wang wrote: >>>> Add thp_vma_disabled() helper to shared by shmem_allowable_huge_orders() >>>> and __thp_vma_allowable_orders(). >>>> >>>> Signed-off-by: Kefeng Wang >>>> --- >>>>    include/linux/huge_mm.h | 19 +++++++++++++++++++ >>>>    mm/huge_memory.c        | 13 +------------ >>>>    mm/shmem.c              |  7 +------ >>>>    3 files changed, 21 insertions(+), 18 deletions(-) >>>> >>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>> index 795df660efa5..d77891332b35 100644 >>>> --- a/include/linux/huge_mm.h >>>> +++ b/include/linux/huge_mm.h >>>> @@ -309,6 +309,25 @@ struct thpsize { >>>>        (transparent_hugepage_flags &                    \ >>>>         (1<>>> +static inline bool thp_vma_disabled(struct vm_area_struct *vma, >>>> +                    unsigned long vm_flags) >>>> +{ >>>> >>> >>> I might need a patch like this for an independent fix, and the more I >>> look at this the more I hate the separate vm_flags and the optional vma >>> argument. > > Yes, it is a little strange when made this changes, a separate vm_flags > and another vma argument, most vm_flags is just vma->vm_flags(madvise is > a special case). > Yes, we should be able to handle the madvise stuff in a better way (simply check after the vma->vm_flags where modified). >>> >>> Let me try to improve things. >>> >>> Long term we can get rid of the vm_flags, it just needs some madvise() >>> massaging. >> > > Thanks for your improvement, it is more accurate. I will include that in my next small fix-series and CC you. -- Cheers, David / dhildenb