From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9E9CF6495 for ; Sun, 29 Sep 2024 09:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 770836B0180; Sun, 29 Sep 2024 05:37:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 720E06B0183; Sun, 29 Sep 2024 05:37:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E7578D0002; Sun, 29 Sep 2024 05:37:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 40F816B0180 for ; Sun, 29 Sep 2024 05:37:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B08A01618DD for ; Sun, 29 Sep 2024 09:37:53 +0000 (UTC) X-FDA: 82617274026.20.B33C414 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf12.hostedemail.com (Postfix) with ESMTP id D6E1D40005 for ; Sun, 29 Sep 2024 09:37:51 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RIFGmh1e; spf=pass (imf12.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727602506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UI3JnvNxoordn6WEYDEb5d80WQsWt5pSs8xiHh3j060=; b=P9CzPQRV/Bw0rIM3J1APANlAkbd5C/KOgetvuEROIz6eufDA4RybwRztKtwgki+MaeDCZD tUjzvJ9F4A0TR16Nos7P9UiuwiiPRS5G+v9r+82pJHbhxXorJvOkb46aLYUwfBmYCsImzd r3J9/dPZEy8SptO7/bWWZ5ZoIMuExms= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RIFGmh1e; spf=pass (imf12.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727602506; a=rsa-sha256; cv=none; b=rc1l9XKB0Ev5GDnmxUfrbT3fHLM9AwAsXuGuf2h7uL/QY+j0CCqRW8n0V69GowUmCvQlUD S5/APWxA+vx7X5NJ0a3m760rwxzQdQ2+YIFUkOdYP9Eeb91YMdnfciyZOXZQQuWLkge7pT AbVs/BvFbTi+ozt4MdfN4/Vouf7XW90= Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-7db1f13b14aso2954583a12.1 for ; Sun, 29 Sep 2024 02:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727602670; x=1728207470; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=UI3JnvNxoordn6WEYDEb5d80WQsWt5pSs8xiHh3j060=; b=RIFGmh1e4HYmaib12O4j2mQ+OKo4JqJnZ/b1l4jyEoozaoZTpeFedtxeTXNLVgNzTt T65NAx6x/6L22qfW17z+uLQhdpcABbXS4smjyFOBZqeoO+7HplpChXFM4ddxD4dqlpUh 7XCsHBlNC0exsvoc5z1ji0Q5GjvnyfZ8jl5NH6PxW59vCed6ihOX1A4RGqgHyCjH0w+Z SVbqs8mTTbLiMgoSsjSyVVNyRgakkoERJQ43ubZhPKjqxDWINHTwfuvPiQ84l1HNx374 vNFmwlScdftyYWTHiBd/CQhCIrq95//YtCSHreiD8dw+ZQCEEACMzEO/pRqofzQxnwxd Q/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727602670; x=1728207470; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UI3JnvNxoordn6WEYDEb5d80WQsWt5pSs8xiHh3j060=; b=cjHzsEmgAqofxMXgiZikKblEBqqxZC0JvFNUdmEzqjYFQzeBwI7/vG/652WzpjOo5O IS432q8/14rAyOj8JTqU8fSGP0ztf6q3O9nE1qXGH3u960Os2Hz8wgFhmWsK+iAVgAhY wnFq2WvtUBi1/dS49VYByDPj2iMLYiJn6KZFzWO4vmaNZ/9v3rHbBHHbyESbnloUv0WK HCb7qjLMlMGnxaCjo65QJPnSvAjhwzyfK1UCSlyEYk4QNYKzbl0vJ6i9d1mQBqp+DG9H ghEmGESU1jLso+20/wEyKlJT5xpakUN9CHO6PfEt3hDT6zNks8OpTF4G+1N1ZIDWS3ls C2tw== X-Forwarded-Encrypted: i=1; AJvYcCXAm6d3alLIenQBqt0e+zb0w9Q5MJRTfK+3MF2qHARssKB62Zriv4o1T0jov3HQoGwAaLJTGmL8cQ==@kvack.org X-Gm-Message-State: AOJu0YwE9mb7VYqkYjhH2Tx30QjQ054JVnX40BAv5EgbaNzZmf6RnJfv wkJ+ykNeZSWSnkpDe2xj6rBSStaLYNuGLeziUskybQzs4h9sGtkV X-Google-Smtp-Source: AGHT+IGlIri+CO3nO7SHxYS35QDjVZ1ed/TCsk0eNd1dMV/4gMLjT42I+WIsw+2rLAY8Xe2G636KQA== X-Received: by 2002:a05:6a20:cf8b:b0:1d2:e81c:adc0 with SMTP id adf61e73a8af0-1d4fa7b53bemr13375412637.46.1727602670436; Sun, 29 Sep 2024 02:37:50 -0700 (PDT) Received: from [192.168.0.235] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264bebedsm4292766b3a.85.2024.09.29.02.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Sep 2024 02:37:49 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading From: Eduard Zingerman To: David Howells , Leon Romanovsky Cc: Christian Brauner , Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Date: Sun, 29 Sep 2024 02:37:44 -0700 In-Reply-To: <2808175.1727601153@warthog.procyon.org.uk> References: <20240925103118.GE967758@unreal> <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <1279816.1727220013@warthog.procyon.org.uk> <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> <2808175.1727601153@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D6E1D40005 X-Stat-Signature: 3hhhshpnuzw6r3wxfyob4ph4oghsg9mt X-Rspam-User: X-HE-Tag: 1727602671-319339 X-HE-Meta: U2FsdGVkX18aL2A9V1iURWQj8pBv0McZ/nBxhwKE1zLhJRDyHxwIv1ByYJcmPqI5G+MJLpmAEK86N2fuMgvilgnR3VbzE6AOgX+oVadoJ+gjbkrLwgIOhNvdq+Ph4RTTcITReCmm/5r9QFgnBgQm7pntiCalD2KNhhKElVw1F/FTsSGDuM4R5LAD05XSTcRbbehfpLoJRu53QK/yXMSV6HS50OE5F3hDTmR1WuGpyFgZZkF+r528UykoLZkSag4gCD4dVqEhHxMCUaS5OlVFBGzsX3eGcwd1AIJzDlOBgxm4VYkmAizjRIVw84mT03c87f2KgJwHQdNUCaU4dRIGc9CuFmYMpl+TU6/etuRIZo66wcdKzyJIcm+IukaxxgRkdLUshrGIVs7nU2Qpp0EftZoN8aXpMC1lGrx60EUtBndtDphQ2oYPwnde3SDaZNdVeTvWTnY8iUKEftuU6Bozj0zpOd/f9hDJts6dX0CDYyL1QGWDTkqYI4/dUGUE17WdYFq94D3HDe2/zEKWUiANewy8fhan76aLF3j+btMYlqOpKdczSXy6f+D4yoda2XDaAm1Bp8M7X16TYaxM8ITkuRy1feOrYsQeXKN11KvDZ6uA4I4uZoSPsCGewuL8eo7W4sn25B9qlYcsutAd3M4TPQaQ88yKofflwGqdN763xrctIeuVU5bXEoR1dYug5k6Ac635qMquiYUek3LXr6WlZe2ziEZMCfIr3We6Ul23/+4MrR9fk4PW8dqigqlTiA/mNfLco/cJfnF2huSEHZADNkVFrTW2VVdDP8+4Sqju2quBP1eR3iF++5xdogEVFMuy7PJFVWDIIoWpEJIV/0nbPbdGhD2FZgG1MCb/dn8gzrFtqTD1s84JNZPgeg7wuyhbKcrLdJvpGwPNGqRZBGws/B43QGoy5sRN50YMxhMtixJ5SjB47ZjJs7v33qLqgJ2Vw9XSNvv0vVvZrrwNoNu krPNjErT hI0GI016Dy4uv9u/psUqq1C9ZQjfgBO/joh/DoHZgkmdUFfyYfT+6Ujs4r5QdNXT1Ik7wd4hCjpFM9DBW2gP/BexgAMMh+MsTfcww+J2E2t900HruAzpAuFKf2yLnUenWQ21EgoxtPWdGUn2ljO42MPqIDR9sWiGzaDCE5VMZ9IlIlWXI952/XWDP17jDlj8j4EJSSmrdHlJXUNSxRxkz1nBLh5U1zgAeT2NmwcAyq5S8zHp0WBy5bGPhqX+O6VWVj1esuuzlpFMP2o/33FyCRKh0df3vPc7uxzRs7g7qUa8osrYvYDpycZsYecGLHoAmDjvUBFLaboFURZakDMJm1EeGVss7YIHyHWEaRs/m75U/Q/fxRMJ20jAaazBAjoq1/MS6PMRvoIxzEZMoNBUlMOnzD4PR00BJ3OMB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000745, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 2024-09-29 at 10:12 +0100, David Howells wrote: > Can you try the attached? I've also put it on my branch here: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log= /?h=3Dnetfs-fixes Used your branch: fc22830c5a07 ("9p: Don't revert the I/O iterator after reading") dmesg is here: https://gist.github.com/eddyz87/4cd50c2cf01323641999dc386e2d41eb Still see null-ptr-deref. [...]