From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FA5C433DF for ; Wed, 20 May 2020 20:58:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C03220829 for ; Wed, 20 May 2020 20:58:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oApF1TVR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C03220829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2B2E380008; Wed, 20 May 2020 16:58:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23CEA900002; Wed, 20 May 2020 16:58:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12BB980008; Wed, 20 May 2020 16:58:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id EBF03900002 for ; Wed, 20 May 2020 16:58:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A48881277 for ; Wed, 20 May 2020 20:58:06 +0000 (UTC) X-FDA: 76838309772.11.cars64_29a7dd7709b19 X-HE-Tag: cars64_29a7dd7709b19 X-Filterd-Recvd-Size: 7130 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 20:58:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=HmORzFgJsw2gobisfpG85fyWX0Xl/xkk6FY89pOspJs=; b=oApF1TVRKA2+DrcKnsfjlOlsPd WrQOGEcfoAsvB8KXscjWTOGhki2QZNt3o0dxxoHfaEsWrVfSdpmHG38TAKNjOhmmnNuQ/SQd7U4aE yHyBtxssLlbnCvMpcUzJjaMNxu/x24LjDcmaDE1lL7kv7v7ITwL2cDtuZzJ4n7y2p8iH0rdusK1Ej qhrzmEB9YWhTOUbXpKHi9bH1rE1ILJe0nVbdntNjlpSkafkRmySG3UA/rXpCowuOKUjY44HmBb0qm i3DrUznQSYZSZJH0oaEQHNncfepSMqtWZDe3uY8TKw7MJBkUxZ7IjUHmAQX458te0OWM4ddvC36Px oUDqd9ag==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbVmt-0003aT-A1; Wed, 20 May 2020 20:58:03 +0000 Subject: Re: [linux-next:master 10679/10701] arch/x86/mm/pgtable.c:427:2: warning: variable length array 'u_pmds' is used To: kbuild test robot , Mike Rapoport Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List References: <202005210343.GBNjOjOX%lkp@intel.com> From: Randy Dunlap Message-ID: Date: Wed, 20 May 2020 13:58:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <202005210343.GBNjOjOX%lkp@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/20 12:56 PM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8 > commit: 0e19fc1c40bd7516d5a30a459db4f49d48910847 [10679/10701] mm: consolidate pgd_index() and pgd_offset{_k}() definitions > config: i386-randconfig-a005-20200520 (attached as .config) > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3 > reproduce: > git checkout 0e19fc1c40bd7516d5a30a459db4f49d48910847 > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot > > All warnings (new ones prefixed by >>, old ones prefixed by <<): > > arch/x86/mm/pgtable.c: In function 'pgd_alloc': >>> arch/x86/mm/pgtable.c:427:2: warning: variable length array 'u_pmds' is used [-Wvla] > pmd_t *u_pmds[MAX_PREALLOCATED_USER_PMDS]; > ^ >>> arch/x86/mm/pgtable.c:428:2: warning: variable length array 'pmds' is used [-Wvla] > pmd_t *pmds[MAX_PREALLOCATED_PMDS]; > ^ > Yes, I also reported this on linux-next of 20200518 (but I didn't copy Mike on it). > vim +/u_pmds +427 arch/x86/mm/pgtable.c > > 1db491f77b6ed0 Fenghua Yu 2015-01-15 423 > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 424 pgd_t *pgd_alloc(struct mm_struct *mm) > 1ec1fe73dfb711 Ingo Molnar 2008-03-19 425 { > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 426 pgd_t *pgd; > 184d47f0fd3651 Kees Cook 2018-10-08 @427 pmd_t *u_pmds[MAX_PREALLOCATED_USER_PMDS]; > 184d47f0fd3651 Kees Cook 2018-10-08 @428 pmd_t *pmds[MAX_PREALLOCATED_PMDS]; > 1ec1fe73dfb711 Ingo Molnar 2008-03-19 429 > 1db491f77b6ed0 Fenghua Yu 2015-01-15 430 pgd = _pgd_alloc(); > 1ec1fe73dfb711 Ingo Molnar 2008-03-19 431 > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 432 if (pgd == NULL) > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 433 goto out; > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 434 > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 435 mm->pgd = pgd; > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 436 > f59dbe9ca6707e Joerg Roedel 2018-07-18 437 if (preallocate_pmds(mm, pmds, PREALLOCATED_PMDS) != 0) > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 438 goto out_free_pgd; > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 439 > f59dbe9ca6707e Joerg Roedel 2018-07-18 440 if (preallocate_pmds(mm, u_pmds, PREALLOCATED_USER_PMDS) != 0) > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 441 goto out_free_pmds; > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 442 > f59dbe9ca6707e Joerg Roedel 2018-07-18 443 if (paravirt_pgd_alloc(mm) != 0) > f59dbe9ca6707e Joerg Roedel 2018-07-18 444 goto out_free_user_pmds; > f59dbe9ca6707e Joerg Roedel 2018-07-18 445 > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 446 /* > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 447 * Make sure that pre-populating the pmds is atomic with > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 448 * respect to anything walking the pgd_list, so that they > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 449 * never see a partially populated pgd. > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 450 */ > a79e53d85683c6 Andrea Arcangeli 2011-02-16 451 spin_lock(&pgd_lock); > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 452 > 617d34d9e5d832 Jeremy Fitzhardinge 2010-09-21 453 pgd_ctor(mm, pgd); > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 454 pgd_prepopulate_pmd(mm, pgd, pmds); > f59dbe9ca6707e Joerg Roedel 2018-07-18 455 pgd_prepopulate_user_pmd(mm, pgd, u_pmds); > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 456 > a79e53d85683c6 Andrea Arcangeli 2011-02-16 457 spin_unlock(&pgd_lock); > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 458 > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 459 return pgd; > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 460 > f59dbe9ca6707e Joerg Roedel 2018-07-18 461 out_free_user_pmds: > f59dbe9ca6707e Joerg Roedel 2018-07-18 462 free_pmds(mm, u_pmds, PREALLOCATED_USER_PMDS); > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 463 out_free_pmds: > f59dbe9ca6707e Joerg Roedel 2018-07-18 464 free_pmds(mm, pmds, PREALLOCATED_PMDS); > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 465 out_free_pgd: > 1db491f77b6ed0 Fenghua Yu 2015-01-15 466 _pgd_free(pgd); > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 467 out: > d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 468 return NULL; > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 469 } > 4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 470 > > :::::: The code at line 427 was first introduced by commit > :::::: 184d47f0fd365108bd06ab26cdb3450b716269fd x86/mm: Avoid VLA in pgd_alloc() > > :::::: TO: Kees Cook > :::::: CC: Ingo Molnar > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > -- ~Randy Reported-by: Randy Dunlap