From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A2BC7EE30 for ; Thu, 26 Jun 2025 16:39:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BB186B0099; Thu, 26 Jun 2025 12:39:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 961616B00A4; Thu, 26 Jun 2025 12:39:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829566B00A5; Thu, 26 Jun 2025 12:39:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6B1236B00A4 for ; Thu, 26 Jun 2025 12:39:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 21BDF1402FE for ; Thu, 26 Jun 2025 16:39:46 +0000 (UTC) X-FDA: 83598113172.17.920F0D9 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf23.hostedemail.com (Postfix) with ESMTP id BF6DF140004 for ; Thu, 26 Jun 2025 16:39:43 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=broadcom.com header.s=google header.b=adysGryi; spf=pass (imf23.hostedemail.com: domain of florian.fainelli@broadcom.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=florian.fainelli@broadcom.com; dmarc=pass (policy=quarantine) header.from=broadcom.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750955984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kiB7sElStizaKuG4ZG0mE7ZHh4hndYmdW5MwoUlLuUc=; b=hPp99AyYLLzeafeK9uW2sYA+S8Qc9eRNgXgcICvXBLBDzRnxLKTtK5+3ipYb+9xp+HMC0D fkySj2TDJ67wZTQw7VrPfELabiO4JWz5C9E7o0K1myZ8KOvPR7PvP528x0hrI7mAp47RPb RoHr6rEb+oZKNcKnuAlxxg3ma96D4LA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=broadcom.com header.s=google header.b=adysGryi; spf=pass (imf23.hostedemail.com: domain of florian.fainelli@broadcom.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=florian.fainelli@broadcom.com; dmarc=pass (policy=quarantine) header.from=broadcom.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750955984; a=rsa-sha256; cv=none; b=oZT2wvLHrFZ3+WVvsK49RkvAs8gmw6jtqZbOA4sm05/TrBeqbTS0lEAcnogRpqDuGg3gJ+ zIOTu8PYJtWl2jXq/SQRUCTjAswgT47ANF+9+0goovOFJ2ax6h2Kdby2JPBw8ZFibreYCz zhFN8eEywMqaP3NoJ7nABpuvd8ZhzZE= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-af6a315b491so1045278a12.1 for ; Thu, 26 Jun 2025 09:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1750955982; x=1751560782; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=kiB7sElStizaKuG4ZG0mE7ZHh4hndYmdW5MwoUlLuUc=; b=adysGryi66hwVzpus4K6KMvXcMEjCaNoM6xY16vkQO52WRd5VDnefhXAT3v/x7LPgy 8RpUqSa86nwS5fsKlhqYB02VFkWPA5edc1H452H/IvL/Xu08Lf6IFj7w66eKGf6x5mIC CdptV5xMh4jbDKhMykQu9np96EYxqqyXmRi3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750955982; x=1751560782; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kiB7sElStizaKuG4ZG0mE7ZHh4hndYmdW5MwoUlLuUc=; b=wgp208VI2C7Kug9f9Jc6QsSE/xNDuvAR0ELfv2akvQ12FsOW6o0+A0x4W26Kq+k0Jo TD0tnj6MANLtQc6Zs3L04IyMySHJB7Uqhlrog1uYVznufQLSCMl1yyN9BjLMm1JRaow8 8ByiYf2pttzrkiIQjdEihXLr/H12+2nj6+LB5fQ6JPb/5g3vA5+S1/xnKVHblVFLULHv wBHFrrZzgAp99ZGThKuiLDoLet7PAAiP3N+FFnwx0qHTNbQkPjPiZVYopmJwsRUnNBcx AC3BSN/MbY506lfgNXkpayZKGP0huVn6U0Blt7/xam85qQKBcYDYBpW2hJEz0zWl8B4J tw3w== X-Forwarded-Encrypted: i=1; AJvYcCVEMz57LFRQi7fCrTXzTDArEpt7ZbcjCr6SIxZhxyaWPqiOl1BnqSA7aYxC27D4PWGuFgQnXLzrug==@kvack.org X-Gm-Message-State: AOJu0Yy8rUeMiu8gHTo6NOtV3kg50BqXyTGKrzxRcGergELe2vLR4WcN hdmbXsfA2tJ80VhrKH6drq53soHxKJuZS7+0vqNrYg+a41h/BBBzDfLcjW/HdGmTBA== X-Gm-Gg: ASbGncvOwxkjL9KvvJp3J0d9Kz6tmS7ZKCvq4bRJodWr0LIbUva7oNu65UWjTajhEB5 lkwJsXS4i/hozjdsxDF+rvwJEatbOG2Gl2p2EmcJQqdbt/i0tVMMdD3Dq1Xa7yAF8T0UwIu5vD5 ku4doITgSYLuhc7OsIs2mLjTGsHkCR/YgUWVk8kTz3uiVK7msYnk3VRDgaWxT5y90BHcyoA+dqK /ejk/rgKk3YMEDPYAtqmRuiczf3as2Q0bTmg090W5PK7E3+27+uGRimlJtCod1Af7isvaQd74sV SN6GyJTRsc48uxrruf88DIxd5qG3Bz/q0AVxYZJqir5RNRTMrJCh+LFFXURXUgAbkaMuPXQrYmB nXY7tW+oWd05/H0LjTV+bxEgWkaywGjuSJSl/ X-Google-Smtp-Source: AGHT+IHEodYyA0JwEfIYPoh2/MM1Lu2s8aF4hU27hBW/g0OK17fBGh6vDcMzM6wG4s7dCi1eZ9/MNA== X-Received: by 2002:a17:90b:2e87:b0:314:7e4a:db08 with SMTP id 98e67ed59e1d1-315f2675fc7mr12720722a91.18.1750955982382; Thu, 26 Jun 2025 09:39:42 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-318c13921fdsm209101a91.10.2025.06.26.09.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 09:39:41 -0700 (PDT) Message-ID: Date: Thu, 26 Jun 2025 09:39:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/16] MAINTAINERS: Include GDB scripts under their relevant subsystems To: "Liam R. Howlett" , linux-kernel@vger.kernel.org, Jan Kiszka , Kieran Bingham , Michael Turquette , Stephen Boyd , Dennis Zhou , Tejun Heo , Christoph Lameter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Ulf Hansson , Thomas Gleixner , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Kent Overstreet , Anna-Maria Behnsen , Frederic Weisbecker , Alexander Viro , Christian Brauner , Jan Kara , Uladzislau Rezki , Matthew Wilcox , Kuan-Ying Lee , Ilya Leoshkevich , Etienne Buira , Antonio Quartulli , Illia Ostapyshyn , "open list:COMMON CLK FRAMEWORK" , "open list:PER-CPU MEMORY ALLOCATOR" , "open list:GENERIC PM DOMAINS" , "open list:KASAN" , "open list:MAPLE TREE" , "open list:MODULE SUPPORT" , "open list:PROC FILESYSTEM" References: <20250625231053.1134589-1-florian.fainelli@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BF6DF140004 X-Stat-Signature: zy9azkpmoixu64b8qiji3h1jcbht9h7c X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1750955983-289039 X-HE-Meta: U2FsdGVkX1+QwMVuGMXG5bTZpT96HWM1MN3eH4K+Ew1br1GatwD6ZX956bDd4Q3ZOde57wf2A1lkvv/mZYYce7OWCii2QOTTJ/owCqgO9VQUTNE7qPSDS/y9gtXOOamxn+wyfviAtcj7QTXKbrh2GOltjksZ08DLy+YrJXQY4n8tlhr9otpS91oJ93HF0516Rs6BzzA42DDfplvrstvfDJFjGtvCb++4fKjMGPNIrJKbdm8fUo5nXvqDLM7EjOBG6gWTt1ExX+rMJjVKQv95VG08NpaUGRrXFhAvhHaBlipHw+64hzAA53ptpJHZooYTwVp91VhNBy8L+AuVAk4G/An6srkxGCU9er/cusOaFmYIL/NIt5oF+xVuvvdBwvIUHMdXePy9BGDMtCTTxONU9ZUDLnk8WWJifYEAHO6qp2Z03o+W2R0cyaT1BCJMOarM2kFtV1+ub83tg+UeMs2UkpSb8MNU757jYgbdV5so6QpHgqWI/62WLHw4T6M8lJFY6wkNu102BJf6ZqtUu9xgjZhjXqftQrECy1wuKpBc6SMQA+bk1bYZVFwwmaZk90RfaA6J1STv1Rk+c/RPf2LE4ZQKZLyxCLbrFjdQaeZKjeOXu3doO8CXNiY+uupECfwE2ry8mdJs3nP3q70V+nmMi3984jL8BUZ9svLuqoAUNVswSA/LyaTvkL707obienLTX9+kY14ZRYtGfg+oejpd14G6y85v5pqExy3K8bi5TatFKsXsR02qfpaLUeT5e3hFB2QKw8ICSSNQFQqgy2Tz93EwK07Y/2vheX+/frytdepTvZw0gZEb6kOfNsUv5ciygeaM09K636m5FfumCDmA31omJIrprfx4FHL+z6UwSxrvf5Svw3r7sJqf1pNttXPPR1z+DwPNPkPYJaIQYisw4I9/fu9ch62Wm+7Ej2RNoGTlqlxCI2UscBhjIoxtbSw3LoIhHiN4auuUPeVFSMT 2H9e3J94 BPqb7U7Dis8AN4IYw5iS5ORVrNKP+hZ3Ys+wA4cqG57TosIU99vpnPic+SHdV3C9c/w9X0ZRVOho46OHSXL6D/skZfsOkpQ1WujbOiGiKq7iOX32pFlRi2UIKFdPS4iSekAk7qm8KOhulWPR84OUX0n6+etqS3/XFFx8tyL+yirvWsDVt0Io9HmFOfqGqVeBqFgcOVh8POT084STprNrNudl3+Vxnys8lPVeBBFowutCzJVS1DV2Z7DEkte8A7VUuXB7F8c9gYoaLnjKfrrKoz2RP135Hx/ETDdgvFNAbjJUqe6MA/Hl7GEd2QaEKukMgD5J7ledGMfm43GtX8LXl6VzlAwtNs5Ln4CjdCpzRzFDHRaGHOFYrOG7fUZVhXyhkc5q9LmUrRR+fu8UQwq40Q9faEDtXibJFgQO9czV2uSO6RRgqM40DYMLYdTd5031uyPQIR1qNz/qfFfvJQx/4r3cpQT5wBmNLvMtH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/26/25 09:17, Liam R. Howlett wrote: > * Florian Fainelli [250625 19:13]: >> Linux has a number of very useful GDB scripts under scripts/gdb/linux/* >> that provide OS awareness for debuggers and allows for debugging of a >> variety of data structures (lists, timers, radix tree, mapletree, etc.) >> as well as subsystems (clocks, devices, classes, busses, etc.). >> >> These scripts are typically maintained in isolation from the subsystem >> that they parse the data structures and symbols of, which can lead to >> people playing catch up with fixing bugs or updating the script to work >> with updates made to the internal APIs/objects etc. Here are some >> recents examples: >> >> https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/ >> https://lore.kernel.org/all/20250619225105.320729-1-florian.fainelli@broadcom.com/ >> https://lore.kernel.org/all/20250625021020.1056930-1-florian.fainelli@broadcom.com/ >> >> This patch series is intentionally split such that each subsystem >> maintainer can decide whether to accept the extra >> review/maintenance/guidance that can be offered when GDB scripts are >> being updated or added. > > I don't see why you think it was okay to propose this in the way you > have gone about it. Looking at the mailing list, you've been around for > a while. This should probably have been posted as RFC rather than PATCH, but as I indicate in the cover letter this is broken down to allow maintainers like yourself to accept/reject > > The file you are telling me about seems to be extremely new and I needed > to pull akpm/mm-new to discover where it came from.. because you never > Cc'ed me on the file you are asking me to own. Yes, that file is very new indeed, and my bad for not copying you on it. I was not planning on burning an entire day worth of work to transition the GDB scripts dumping the interrupt tree away from a radix tree to a maple tree. All of which happens with the author of that conversion having absolutely no idea that broke anything in the tree because very few people know about the Python GDB scripts that Linux has. It is not pleasant to be playing catch when it would have take maybe an extra couple hours for someone intimately familiar with the maple tree to come up with a suitable implementation replacement for mtree_load(). So having done it felt like there is a maintenance void that needs to be filled, hence this patch set. > > I'm actually apposed to the filename you used for the script you want me > to own. Is there a different filename that you would prefer? > > I consider myself a low-volume email maintainer and I get enough useless > emails about apparent trivial fixes that end up causing significant > damage if they are not dealt with. So I take care not to sign up for > more time erosion from meaningful forward progress on tasks I hope to > have high impact. I suspect you know that, but I don't know you so I > don't want to assume. That seems entirely sane and thanks for being explicit about it. > > Is there anything else you might want to share to entice me to maintain > this file? Perhaps there's a documentation pointer that shows how > useful it is and why I should use it? It can be as simple as spawning a QEMU instance: qemu-system-x86_64 \ -s \ -cpu "max" \ -smp 4 \ -kernel ~/dev/linux/arch/x86/boot/bzImage \ -device pci-bridge,id=pci_bridge1,bus=pci.0,chassis_nr=1 \ -drive file=debian.img,if=none,id=drive-virtio-disk0,format=qcow2 -device virtio-blk-pci,scsi=off,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 \ -nographic \ -append "root=/dev/vda1 console=ttyS0,115200 mitigations=off" \ -net nic,model=e1000 -net tap,ifname=tap0 and in another terminal running GDB with: gdb vmlinux -ex "target remote localhost:1234" -ex "lx-interruptlist" to obtain a dump of /proc/interrupts which is effectively a replacement for iterating over every interrupt descriptor in the system. > > Right now, I have no idea what that file does or how to even check if > that file works today, so I cannot sign on to maintain it. > > If you want to depend on APIs, this should probably be generated in a > way that enables updates. And if that's the case, then why even have a > file at all and just generate it when needed? Or, at least, half > generated and finished by hand? As it stands today that is not happening, there is zero coordination and people who care about GDB scripts just play catch up. But you raise a good point, if we are to do that, then we should be able to target C/Rust/Python/whatever, that seems like a bigger undertaking and I am not clear whether the kernel community as a whole is looking for transitioning over to something like this. > > Maybe this is the case but scripts/gdb doesn't have any documentation in > there, there's no Documentation/scripts or Documentation/gdb either. > > Can you please include more details on the uses of these files? Failing > that, perhaps you could point to any documentation? See the two commands above, those should give you a good environment to play with the various GDB scripts which are all prefix with "lx-". Thanks! -- Florian