* Re: [PATCH] mm/vmstat: Utilize designated initializers for the vmstat_text array
[not found] <20250602092351.3807465-1-kirill.shutemov@linux.intel.com>
@ 2025-06-02 9:48 ` Christoph Hellwig
2025-06-02 9:58 ` Vlastimil Babka
1 sibling, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2025-06-02 9:48 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: Andrew Morton, David Hildenbrand, lorenzo.stoakes, Liam.Howlett,
vbabka, rppt, surenb, mhocko, hch, linux-mm, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/vmstat: Utilize designated initializers for the vmstat_text array
[not found] <20250602092351.3807465-1-kirill.shutemov@linux.intel.com>
2025-06-02 9:48 ` [PATCH] mm/vmstat: Utilize designated initializers for the vmstat_text array Christoph Hellwig
@ 2025-06-02 9:58 ` Vlastimil Babka
1 sibling, 0 replies; 2+ messages in thread
From: Vlastimil Babka @ 2025-06-02 9:58 UTC (permalink / raw)
To: Kirill A. Shutemov, Andrew Morton, David Hildenbrand
Cc: lorenzo.stoakes, Liam.Howlett, rppt, surenb, mhocko, hch,
linux-mm, linux-kernel
On 6/2/25 11:23, Kirill A. Shutemov wrote:
> The vmstat_text array defines labels for counters displayed in
> /proc/vmstat. The current definition of the array implies a specific
> order of the counters in their enums, making it fragile.
>
> To make it clear which counter the label is for, use designated
> initializers.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-02 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250602092351.3807465-1-kirill.shutemov@linux.intel.com>
2025-06-02 9:48 ` [PATCH] mm/vmstat: Utilize designated initializers for the vmstat_text array Christoph Hellwig
2025-06-02 9:58 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox