From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DA9CEBF7D for ; Fri, 27 Sep 2024 07:18:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 162236B00AB; Fri, 27 Sep 2024 03:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 113866B00AC; Fri, 27 Sep 2024 03:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF5266B00AD; Fri, 27 Sep 2024 03:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D08976B00AB for ; Fri, 27 Sep 2024 03:18:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4421E140B2B for ; Fri, 27 Sep 2024 07:18:44 +0000 (UTC) X-FDA: 82609665768.11.46CE204 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf24.hostedemail.com (Postfix) with ESMTP id 0E8B5180006 for ; Fri, 27 Sep 2024 07:18:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=U2vy34JQ; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf24.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727421505; a=rsa-sha256; cv=pass; b=TyFilU02XFBPplgwcb5PAMyn6BYxKys6F1fIu2s/xu0TZfU40uKr7lV9VBd2aohTWpcB3C TD5ZfTF22/jLpTrjVIqdJrm1EtIZSUbNq9IeoDd7wzLGdx3dhdLDUM6X+MWh5GQSzkqKx/ IsHqkX+T3kvvctkt3Xne1EysAAUsC04= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=U2vy34JQ; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf24.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727421505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OZoOJ7FFoWBjXTxUkPEkVF50xBuMiQ15qbPQ4pw88b0=; b=FoShHXMqvvUVR6jw1HHR/nxpD/gubbYGqy4YyAgfZVckgX6vF2Eh5x1wpSAWY6Rozc4q1J Uy1dc3lq1GM5Hjv/6MZhQiElglUV/8N7tj2DEqK9XBdJT1/qQRjLf25RpZDn8RnPfdpYBP m1Q/T4qEtr/23WJ8jFgeBp4fs4ZMDoQ= ARC-Seal: i=1; a=rsa-sha256; t=1727421513; cv=none; d=zohomail.com; s=zohoarc; b=nyYys2/SLVe4ILzQ4Z4oARBkJA4twlQ0czZK9OEuKbTI5unw//id4FpyEQiiqInogpFiNRR5q15epQ4tfqc88CBe1p4tkoKRNvH+jVQSgZ2MqQ88+tar8vIqHyKism2sw7x2OmgkADnE7tKs00UE2Qr7l+gI1cM2KpuKDZNGzcw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727421513; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=OZoOJ7FFoWBjXTxUkPEkVF50xBuMiQ15qbPQ4pw88b0=; b=hup1fxNXnP/f7CioKOP4EHCCnOzdaBmye5246noA9OmCCTvTxQBv7R002LBf4nmwt0wLyf3UV07jMlK+/JLpMuwKKsvaLMuF82pZYTHgl744p2AJmKUJ0HyPya/jJ1Gy6toHNEGk7DL52kQc1HPgKSVgBTUtKZEury1itfOpdsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1727421513; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=OZoOJ7FFoWBjXTxUkPEkVF50xBuMiQ15qbPQ4pw88b0=; b=U2vy34JQ4kNMTMXjECSF5m51vperTqgqqFtSIKNFiowHAXI+PnL8CNA4GnUhE8Pa hL6o6jBk+VC34FCKmpVgSi4IobU0GrX59l5rpLg0teTUrdI3MJNvSGHtcyhAYwFpU0E TbDYzvRG9mouC+Dv7mZAGRd/djXu1JDWpY5dOb3s= Received: by mx.zohomail.com with SMTPS id 17274215120251.441391906584954; Fri, 27 Sep 2024 00:18:32 -0700 (PDT) Message-ID: Date: Fri, 27 Sep 2024 12:18:24 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Kees Cook , Mark Brown , Przemek Kitszel Subject: Re: [PATCH] selftests/mm: Fixed incorrect buffer->mirror size in hmm2 double_map test To: Donet Tom , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= References: <20240927050752.51066-1-donettom@linux.ibm.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240927050752.51066-1-donettom@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Rspam-User: X-Stat-Signature: zpb6ezz7m8j19i5zadah3ysc4y7a1thh X-Rspamd-Queue-Id: 0E8B5180006 X-Rspamd-Server: rspam02 X-HE-Tag: 1727421521-869114 X-HE-Meta: U2FsdGVkX1/HFJZEDSqqYx7pObPGzsAy18KudKNe2Pvqm4tIVG0ZS2zqZQri81acz2BXk6IPT7lsvij/qCYiDwQnFijTT7mdL58uDQ4vdPsJtN0Y1ttcQp3JdhVr5WLJvIDBdAVwWuMJfjrGhnxmfyGnUzU2Azuo9IbMx/3nxHOJPsvD7lMcjcpHznuJYZYd6cuuAK9QLrFvDMHWrLxwzvWUM0EpmjLfIG9zvOKqjPuTwEFYchd6ITwqX/j7/mXH8rNESDorCfkCtHpghd/x3JtrfStrCrmZCqsXyMK5pDI1/3ZFsD5lI7XQ0gafYcHSWmuZyZTuQVwlm6KCWHJYtuG5VShgJJtn+QDuRkaZNxVXKU/TG9QXIE9/O1sGCJp35KPWQL387H+4g2y1npIa6U4m5wURfUJXBuomwGZie/jmXkvMRCVsXxf/CcAjXQVTdsJnlxQ4hUE80g5x7CwSVFYxAfGEKw95knDhZksuS3A1MlxjFxbaB8PFrNuxaE0F2nbxiDeERH7fd3E94vl50E9X+XEB/Emj/+7g6wWmN6xfruBcW1JDP0Xt8j5rDE4E9ZHB1earUV3Uz0+3FJjdoPKHyhHXnUnb/uxInaojleWlL8NBHWfJs8xkRoRiIkNzZ+qL3grwd7LIr94LDxFOQynGcfUN02QZjpE+01XPofIhqoFVTH6KTsmDIq0HZZgKB6pgK08vGHT/TILGovB60+qHE6ll8f9vmblLr2fx0NvvDb7xBf8VivpK/Zkoa9E5xPBrYtU2S52YL2LB8VXgo+S2wwUUzswj4DwOn7Axx7iUSqmTrNlHZoz3t4pqYfAa4ppBXzpFODkOQAKgxpCz4PrV4qfN4nClVjhaDxGo//IvFRnH4ZHe0M2Gx3mZ+ukEvFLi6ddyeDpd9A7bfM5nF/BhS1nzdiNUwQSG50RbmfehkLFYlGx46I1dvhN64oE0vIQuPtsjsB1z90IiUGx MZSBRB6Y r8imWONwpxzPR79Q31yaf1nDVpSrFuM30GWWcfW1eZKcDs36+uG8gG2Zf6KRJK1h7JsxCa9IHjSAigg0vKuKqqb/2A/qrdfAJ5v46hba6r5pE3lax79GSlvpv7dlFw3szLRdkSr4Z+dMVAcgDMm3cNfFhuwbQdl3C7hCXBqkauC4/6H6lA2M6677HqbWIQrsD9p6NS6v5zINa7w1iuNd2fSj9FWYJdexnwOjpXaOP9HpoBXOJSyormjsAxF6ufEKlFy1gI2j/0KHQwXC46LRijy4d52mMMwY4A5CW4N8cVo7pMOn2E31y94Vu+5XqUdx21j7UobTHV4M6t6UquoohpuGnniAnH0HGZw0JUDGx8vhC404m6l1l1QBbrWuSqgb30Tuxt/htjHeMYPQKaZu8/t/7YDx8HMMIwSoUgZIQV74oF1/ZrMOUz760H5Jcea3xO7a8OkyM/yQkpAV9m/dkUjv57Kx08Ygbob11oVa/aP+AnvMSY6GR571iO3YOU3qHL+NvObIOVFsyZcY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/27/24 10:07 AM, Donet Tom wrote: > The hmm2 double_map test was failing due to an incorrect > buffer->mirror size. The buffer->mirror size was 6, while buffer->ptr > size was 6 * PAGE_SIZE. The test failed because the kernel's > copy_to_user function was attempting to copy a 6 * PAGE_SIZE buffer > to buffer->mirror. Since the size of buffer->mirror was incorrect, > copy_to_user failed. > > This patch corrects the buffer->mirror size to 6 * PAGE_SIZE. > > Test Result without this patch > ============================== > # RUN hmm2.hmm2_device_private.double_map ... > # hmm-tests.c:1680:double_map:Expected ret (-14) == 0 (0) > # double_map: Test terminated by assertion > # FAIL hmm2.hmm2_device_private.double_map > not ok 53 hmm2.hmm2_device_private.double_map > > Test Result with this patch > =========================== > # RUN hmm2.hmm2_device_private.double_map ... > # OK hmm2.hmm2_device_private.double_map > ok 53 hmm2.hmm2_device_private.double_map > > Signed-off-by: Donet Tom Please add Fixes-by tag. Other than this, LGTM Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/hmm-tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c > index d2cfc9b494a0..141bf63cbe05 100644 > --- a/tools/testing/selftests/mm/hmm-tests.c > +++ b/tools/testing/selftests/mm/hmm-tests.c > @@ -1657,7 +1657,7 @@ TEST_F(hmm2, double_map) > > buffer->fd = -1; > buffer->size = size; > - buffer->mirror = malloc(npages); > + buffer->mirror = malloc(size); > ASSERT_NE(buffer->mirror, NULL); > > /* Reserve a range of addresses. */ -- BR, Muhammad Usama Anjum