From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF0CEC2BBCA for ; Fri, 28 Jun 2024 08:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 862D26B009E; Fri, 28 Jun 2024 04:02:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 812C56B00A0; Fri, 28 Jun 2024 04:02:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4406B00A1; Fri, 28 Jun 2024 04:02:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4F06F6B009E for ; Fri, 28 Jun 2024 04:02:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CD90481AAE for ; Fri, 28 Jun 2024 08:02:32 +0000 (UTC) X-FDA: 82279555344.20.62D03F1 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by imf13.hostedemail.com (Postfix) with ESMTP id CC7F32001E for ; Fri, 28 Jun 2024 08:02:30 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=yoseli.org header.s=gm1 header.b=aPGykAbC; spf=none (imf13.hostedemail.com: domain of jeanmichel.hautbois@yoseli.org has no SPF policy when checking 217.70.183.200) smtp.mailfrom=jeanmichel.hautbois@yoseli.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719561734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=povzLeWMcm0Vr+oxJjg+n3lyuGtUiX5IMQUewJORvg8=; b=7+FlakdDoY91LVirDRiWDzGLRJp53KsSvi/2WG3MmVIO22IyzE/KSLSlsSeRfbXRXUJN8o ir2YbkbMhCyoQrBPVasEzlrTnbZXmHe3eu6dxsmbWwjQni/IiZmOPrqq4nEhRn6qEhp48C D33/blP+oXRKCaqRTzOHkDyy0gjDxac= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719561734; a=rsa-sha256; cv=none; b=n1nL8ZOuznolrwKvoVoXdkvnIC6QWNePhAQbM4Rb4lmlTDKhCm9DqAIDUPs3T5c35YB8kP JXCvnlkal9p4t1t3bwuMcOcDv45d+eFaUgahKjguExGToMHoNr46SGrceiPmn+yeNEzDQs vKy2YHlssOC1qHYAV6pF8m/rVpmk5U8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=yoseli.org header.s=gm1 header.b=aPGykAbC; spf=none (imf13.hostedemail.com: domain of jeanmichel.hautbois@yoseli.org has no SPF policy when checking 217.70.183.200) smtp.mailfrom=jeanmichel.hautbois@yoseli.org; dmarc=none Received: by mail.gandi.net (Postfix) with ESMTPSA id 5E99A2000B; Fri, 28 Jun 2024 08:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yoseli.org; s=gm1; t=1719561749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=povzLeWMcm0Vr+oxJjg+n3lyuGtUiX5IMQUewJORvg8=; b=aPGykAbCjKdxjXVHTPa2zjNt1mpHVXaOh3YxukN2bVgqQYUDZN26yeeqYus9z8kZfcRvzG fEWLNR4VnjDRS1HW6IGaU4dhbpFyE60gkkbee3al2XG9dwYmh6IEfXXBl1x1oHP06ePe9y ic2OhQlQhB8TjisZ1mENyeUza6DudoT7CNVy2CXtH+UPNC9z+6zKtE51M+iGfOfN2zTgGa Hh0beaQYt3SqzZzf7cz7CyNZIk1WgHeBgia+I5ONoK0OQXrqOEeXj9CXRKF7V+WerLcmDL MMFNy/cp9F6bPNfs0GLaOt+ugeDYQwKkAi4JykVcPXBlR+dkcG7u15cxXwo1Aw== Message-ID: Date: Fri, 28 Jun 2024 10:02:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: m68k 54418 fails to execute user space To: Michael Schmitz , linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org Cc: Greg Ungerer , Geert Uytterhoeven , Christoph Hellwig , wbx@openadk.org References: <735e19b6-3747-417f-ba5b-1a7da137a3a3@yoseli.org> <7fb2988d-ab89-405f-8cf1-edcdd2196376@gmail.com> <57879ac8-eaf5-48f1-b4ef-6619d9108440@yoseli.org> <64c30829-499d-fb48-16ee-891f8d8c443a@gmail.com> Content-Language: en-US From: Jean-Michel Hautbois In-Reply-To: <64c30829-499d-fb48-16ee-891f8d8c443a@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: jeanmichel.hautbois@yoseli.org X-Rspamd-Queue-Id: CC7F32001E X-Stat-Signature: nmwun94khizmmp1rrq91fhzgox9by3oc X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719561750-402304 X-HE-Meta: U2FsdGVkX1+VEFe/kAOT7uOo/BXU9iYmkoYbhEygQrVy9YIQDuGQOzKVTm7ovaQuJeAVs2EygA3QXIJrL9hqfSkDAeVTqgWogicSfNIRcb163GwWjSwEeHbAKmoAWXs/cGKLTH69n56DTjoOkRyW7tJLHIAy4/rSgs8K8tdm17HuUmQ98gLArcw5OcHWozxRbFBlOk+rjNIdVprqVGFQ/lCGjtI8QeFC7K8tLwQIG+ar33z+Q9RndM0fiH1ueVYmc7jYR90xzltjuzJuHzyxdMQMBOCgUAp2IP2vfRiSlDr4H2T2dPE2n3gRid6IqfpVic3yhaO9Sup6c8tLcVHDsQBSw3T1o14+wo5NiIIK2OgouewHOlBrXGBlRLN8ql7U41ZEtVH8AqlTWvBfr5tzhkjXAq4u102f92Ne7HEWze+ih+h8DANRqxdB4h1tgzNnU4hsaZZqSkxeQqA9NBNGMp1ZnOqTpYogk6lSkqLOhM2uYgEcPXuB//rarfoq8+CKk39xg8OxSKQo3hBQ5PFu4ZGopoHyHv62+GFps70xszpvWuNknoCn5L9Ia6I/xxqkvJ5tjlm/47SOVkHN1L+H47fcovLFuegrm6EeslkBBl/R+Nrm3YDXOd7f9IptYQzfzIes742evKFygtrqZjDIzwJpxu2guzTqES8j7B2ni2KCBDu21vAR4+hX4mJIGNBhlVePx1WWYLTvZcRBiejCXht6MLdikQGW3JprXCWguf8JYCOibEhzZI4iCvqceRNo9QTYzczV2SrF1P4gDipvlr8LQdTxHW9eU72qrI1HskGrvbMT1OGVrvzzQhIq3TmSQ5/6nkeSCKB5EpOWvfuLfRlHReO163+IGEtuuEgNmd8Ihkgn2HxZlz4YAWEPlJAsPHGMxDUBhsYCkvsoCnhzmH2PnIQBN2JfqoFiYK/Jd+7ndLjCVTf836e40wDnb1igR6BSUQ3DHJyMAanRWEk RLuzI9jO 21q0QmlYpl+AzMEmmjzNRw4uxOpaBHxNpzaK30s4+Q/YNsf1EWFD4uDCnxuFZZZQNMZ0GS7amDREpjCS0F6K+ErF02rCBD6uL4c9IVzW2PeQdDbNZJQtDAoVUHUyiVX+T0sxmC6Y7+jBq4djzZmkYGWdEcGrFt4dGu2+c X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Michael, On 28/06/2024 09:48, Michael Schmitz wrote: > Jean-Michel, > > Am 28.06.2024 um 19:24 schrieb Jean-Michel Hautbois: >>> I forgot to take into account that libraries are loaded only the >>> binary starts executing. Can you print the same map dump in the exit >>> syscall code path? That ought to show all loaded libraries at that >>> point. >> >> Thanks for your suggestion ! >> I changed it a bit, and I added a call in do_exit() as suggested. When >> executing ls I get: >> >> bash-5.2# ls -l >> load_elf_binary: Dump memory for ls (31): >> mmap: 60000000-6001e000 r-xp 00000000 00:00 178 /lib/ld.so.1 >> mmap: 6001e000-60022000 rw-p 0001c000 00:00 178 /lib/ld.so.1 >> mmap: 70000000-700c2000 r-xp 00000000 00:00 28 /bin/busybox >> mmap: 700c2000-700ca000 rw-p 000c0000 00:00 28 /bin/busybox >> mmap: bfc1e000-bfc40000 rw-p bffde000 00:00 0 [stack] >> >> do_exit: Dump memory for ls (31): >> mmap: 60000000-6001e000 r-xp 00000000 00:00 178 /lib/ld.so.1 >> mmap: 6001e000-60020000 r--p 0001c000 00:00 178 /lib/ld.so.1 >> mmap: 60020000-60022000 rw-p 0001e000 00:00 178 /lib/ld.so.1 >> mmap: 60022000-6002c000 r-xp 00000000 00:00 193 /lib/libresolv.so.2 >> mmap: 6002c000-6002e000 r--p 00008000 00:00 193 /lib/libresolv.so.2 >> mmap: 6002e000-60030000 rw-p 0000a000 00:00 193 /lib/libresolv.so.2 >> mmap: 60030000-60032000 rw-p 60030000 00:00 0 >> mmap: 60032000-6015a000 r-xp 00000000 00:00 185 /lib/libc.so.6 >> mmap: 6015a000-6015c000 r--p 00126000 00:00 185 /lib/libc.so.6 >> mmap: 6015c000-60160000 rw-p 00128000 00:00 185 /lib/libc.so.6 >> mmap: 60160000-6016e000 rw-p 60160000 00:00 0 >> mmap: 70000000-700c2000 r-xp 00000000 00:00 28 /bin/busybox >> mmap: 700c2000-700c4000 r--p 000c0000 00:00 28 /bin/busybox >> mmap: 700c4000-700ca000 rw-p 000c2000 00:00 28 /bin/busybox >> mmap: 700ca000-700ec000 rwxp 700ca000 00:00 0 [heap] >> mmap: bfc1e000-bfc40000 rw-p bffde000 00:00 0 [stack] >> >> When I call it a second time, I get: >> >> bash-5.2# ls -l >> load_elf_binary: Dump memory for ls (33): >> mmap: 60000000-6001e000 r-xp 00000000 00:00 178 /lib/ld.so.1 >> mmap: 6001e000-60022000 rw-p 0001c000 00:00 178 /lib/ld.so.1 >> mmap: 70000000-700c2000 r-xp 00000000 00:00 28 /bin/busybox >> mmap: 700c2000-700ca000 rw-p 000c0000 00:00 28 /bin/busybox >> mmap: bfb5a000-bfb7c000 rw-p bffde000 00:00 0 [stack] >> do_exit: Dump memory for ls (33): >> mmap: 60000000-6001e000 r-xp 00000000 00:00 178 /lib/ld.so.1 >> mmap: 6001e000-60020000 r--p 0001c000 00:00 178 /lib/ld.so.1 >> mmap: 60020000-60022000 rw-p 0001e000 00:00 178 /lib/ld.so.1 >> mmap: 60022000-6002c000 r-xp 00000000 00:00 193 /lib/libresolv.so.2 >> mmap: 6002c000-6002e000 r--p 00008000 00:00 193 /lib/libresolv.so.2 >> mmap: 6002e000-60030000 rw-p 0000a000 00:00 193 /lib/libresolv.so.2 >> mmap: 60030000-60032000 rw-p 60030000 00:00 0 >> mmap: 60032000-6015a000 r-xp 00000000 00:00 185 /lib/libc.so.6 >> mmap: 6015a000-6015c000 r--p 00126000 00:00 185 /lib/libc.so.6 >> mmap: 6015c000-60160000 rw-p 00128000 00:00 185 /lib/libc.so.6 >> mmap: 60160000-6016e000 rw-p 60160000 00:00 0 >> mmap: 70000000-700c2000 r-xp 00000000 00:00 28 /bin/busybox >> mmap: 700c2000-700c4000 r--p 000c0000 00:00 28 /bin/busybox >> mmap: 700c4000-700ca000 rw-p 000c2000 00:00 28 /bin/busybox > > No heap in this second call. Can you print mm->start_brk and mm->brk > please? Sure: mmap: start_brk: 700ca000, brk: 700ca000 > > The process memory layout is a little unusual (I would have expected the > binary to be mapped before the dynamic libraries, not after). Is that > expected on Coldfire, Greg? > > Cheers, > >     Michael > > >> mmap: bfb5a000-bfb7c000 rw-p bffde000 00:00 0 [stack] >> >> The first call generates the "ls" output, not the second one. >> The helper looks like: >> diff --git a/mm/mmap.c b/mm/mmap.c >> index 83b4682ec85c..14d861e9cba2 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -76,6 +76,87 @@ int mmap_rnd_compat_bits __read_mostly = >> CONFIG_ARCH_MMAP_RND_COMPAT_BITS; >>  static bool ignore_rlimit_data; >>  core_param(ignore_rlimit_data, ignore_rlimit_data, bool, 0644); >> >> +int dump_memory_map(struct task_struct *task) >> +{ >> +    struct mm_struct *mm = task->mm; >> +    struct vm_area_struct *vma; >> +    struct file *file; >> +    struct path *path; >> +    char *buf; >> +    char *pathname; >> + >> +       if (!mm) { >> +               return -ENOMEM; >> +       } >> + >> +       MA_STATE(mas, &mm->mm_mt, 0, -1); >> +    // Acquire the read lock for mmap_lock >> +    down_read(&mm->mmap_lock); >> +       mas_lock(&mas); >> +       for (vma = mas_find(&mas, ULONG_MAX); vma; vma = mas_find(&mas, >> ULONG_MAX)) { >> +               char perms[5] = "---p"; // Default permissions >> +               // Set permissions based on vm_flags >> +               if (vma->vm_flags & VM_READ) perms[0] = 'r'; >> +               if (vma->vm_flags & VM_WRITE) perms[1] = 'w'; >> +               if (vma->vm_flags & VM_EXEC) perms[2] = 'x'; >> +               if (vma->vm_flags & VM_MAYSHARE) perms[3] = 's'; >> + >> +               if (vma->vm_file) { // If there's an associated file >> +                       buf = (char *)__get_free_page(GFP_KERNEL); >> +                       if (!buf) { >> +                               continue; // Handle memory allocation >> failure >> +                       } >> + >> +                       file = vma->vm_file; >> +                       path = &file->f_path; >> +                       pathname = d_path(path, buf, PAGE_SIZE); >> +                       if (IS_ERR(pathname)) { >> +                               pathname = NULL; >> +                       } >> + >> +                       // Print memory area information with file path >> +                       pr_info("%08lx-%08lx %s %08lx %02x:%02x %lu >> %s\n", >> +                               vma->vm_start, vma->vm_end, >> +                               perms, >> +                               vma->vm_pgoff << PAGE_SHIFT, >> +                               MAJOR(file_inode(file)->i_rdev), >> +                               MINOR(file_inode(file)->i_rdev), >> +                               file_inode(file)->i_ino, >> +                               pathname ? pathname : ""); >> + >> +                       free_page((unsigned long)buf); >> +               } else { >> +                       char *special_area_name = NULL; >> + >> +                       // Check for heap >> +                       if (vma->vm_end > mm->start_brk && vma->vm_start >> < mm->brk) { >> +                               special_area_name = "[heap]"; >> +                       } >> +                       // Check for stack >> +                       else if (vma->vm_start <= mm->start_stack && >> vma->vm_end >= mm->start_stack) { >> +                               special_area_name = "[stack]"; >> +                       } >> +                       // Check for vdso >> +                       else if (vma->vm_flags & VM_EXEC && >> vma->vm_flags & VM_READ && !vma->vm_file) { >> +                               special_area_name = "[vdso]"; >> +                       } >> + >> +                       // Print memory area information without file >> path >> +                       pr_info("%08lx-%08lx %s %08lx 00:00 0 %s\n", >> +                               vma->vm_start, vma->vm_end, >> +                               perms, >> +                               vma->vm_pgoff << PAGE_SHIFT, >> +                               special_area_name ? special_area_name : >> "    "); >> +               } >> +       } >> +       mas_unlock(&mas); >> +    // Release the read lock for mmap_lock >> +    up_read(&mm->mmap_lock); >> + >> +    return 0; >> +} >> +EXPORT_SYMBOL(dump_memory_map); >> >> >> Thanks, >> JM