From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E46C71157 for ; Tue, 24 Jun 2025 14:05:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EBC36B00A1; Tue, 24 Jun 2025 10:05:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79B226B00C5; Tue, 24 Jun 2025 10:05:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6633E6B00C6; Tue, 24 Jun 2025 10:05:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 50D1D6B00A1 for ; Tue, 24 Jun 2025 10:05:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ECAC91A0960 for ; Tue, 24 Jun 2025 14:05:35 +0000 (UTC) X-FDA: 83590467030.04.A937EAF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 9510E1C0020 for ; Tue, 24 Jun 2025 14:05:33 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Tp/khox/"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750773933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MQW0eK7tbkiGyxI7eA1J0NuZ3Ps4H74rdH6AEE3ZoPo=; b=Hqh+IZZw7qh8OApiD3UjIntUoqWcOD7vBvqPVog2An5ENwTxnPG+bEx8qjC69h8g4mSpCq WfEsxkCVK8M7zcx5h8t0dA1iUcDdP/Vru5EtMHWL4+goSAPTuAWFejmBUk4t7a/R/Zk6JN RHgzu3RgJeidwg/CnkSvbAkPKK/vSrY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750773933; a=rsa-sha256; cv=none; b=xW0oRdO15mno2VCNq5CUJukm8VhFsr7nt2BxH5B0EWBZOlxE+Ze0SmPjQlA09YYPaQKbu4 5xJLmy2JOZq3NCkIwnsTGVgoHgStFB6TR8yqLzCJLGTf2/ayTf8JwtZcLfGViF06fQ1OA6 UDqBJYh5heLB/emouMNZcdYCJT/kTu0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Tp/khox/"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750773933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MQW0eK7tbkiGyxI7eA1J0NuZ3Ps4H74rdH6AEE3ZoPo=; b=Tp/khox/oZa19R/Lh0sn5cNGwNfumyzF6kUYMIansKfeCCxWj7eI6/uZBVe4+JxGj+33VN OCQjwGq5drb2g66U/kK/yZTXeCQURTFcxQGCsm9ZOHmcfCfSazsNsoBVGQ2beQR/P/T1Yi Nqytn6nY2lAmlR0Q9URMJ2h+t/VdrcI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-iAGSrB1FO5qHX09bBO4scw-1; Tue, 24 Jun 2025 10:05:31 -0400 X-MC-Unique: iAGSrB1FO5qHX09bBO4scw-1 X-Mimecast-MFC-AGG-ID: iAGSrB1FO5qHX09bBO4scw_1750773930 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45320bfc18dso25523105e9.1 for ; Tue, 24 Jun 2025 07:05:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750773930; x=1751378730; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MQW0eK7tbkiGyxI7eA1J0NuZ3Ps4H74rdH6AEE3ZoPo=; b=wiBFoTotg0Z+IGRWlX2Vx+bYG0RizrEUwpoBXNjSKDzXZMBjxt7iA3pRHQ2bPpVbLw +V5O/V4klU1O9Jw6F5Ri6n9aW3LgYOhuEXKq/oucbiMwb3gWJ6gJ5LCqOGACAiAXBuXa KB679cY2yXSiOhv+31mh3KSSzFnkBZ8jSEt6+CKEn5GuF5N/3rtKzTb0SvZ3HxIhG23K q+q0xG0eBThSRm3TisFaAr+WBnAuQ6ZegiNk5C0X/CUI8p3dr2IFJpfutxJYuINt93sy tics0SXIKB4iU/OmlmdzZBzDzjqEjpDj34uQXvTxxeVdJhywA0ZGarKyy5LNBcZLMtsk gizw== X-Gm-Message-State: AOJu0YzU1rX+yLrIIXIeByN4QdbRrlKCGmsniBEdGccGX5uwK3gBqKHk C/dwuON0EjS0I7d9Xhm9iaOrSR0O0yN/4Y0oT6vLENVxN2A/4C85gK7ScshF8Q6aKk2zD5uE9No I7uVUddJxouILqNcZR3IWg0gPW3UU6ErW5A3dOUhv53wo+dIhNfm+ X-Gm-Gg: ASbGncssQvAfMoUvG32mregLhZGdQ+bMUeLpiUbTntIhn9dsV3cN0TjSO6Dnf6sYq1Y 3tTh8GuBw9dqFirBKNWV0VVE2xfJ12JSWRclYgNXuprW3uMWn8fsF5xCjY8w8Ho+Q7/1StXn9M0 KfNzpeccVVOest6W1T/I5Fwzd85JD1Uk98/MoOOLbotIsSEQf86xifcFjbfvXCtMYzMFwtzjf/q 0frXR1xsSiu4cJ0vnHr19hLIxYCFTe1h37vUWudgq4MpVVl98TV3dUhO1HClQruIQa5bRcB2tfE 3dRDb/IvRJHBSfqYqAcgi6M7XOgZ31lH1NzxfRaTHwL8Iy1FJyZMUsU= X-Received: by 2002:a05:600c:3ac4:b0:453:79e8:e92d with SMTP id 5b1f17b1804b1-4537b73c382mr31459015e9.5.1750773930112; Tue, 24 Jun 2025 07:05:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrEIYWGGUY2XiJL8RsTY7jPeq9BLAiJ+iRwPOvCsahaMmy9zMudkVKGN36xyHiujmJ2yf6LQ== X-Received: by 2002:a05:600c:3ac4:b0:453:79e8:e92d with SMTP id 5b1f17b1804b1-4537b73c382mr31458225e9.5.1750773929267; Tue, 24 Jun 2025 07:05:29 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45372252583sm79847235e9.5.2025.06.24.07.05.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 07:05:27 -0700 (PDT) Message-ID: Date: Tue, 24 Jun 2025 16:05:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] mm, madvise: move madvise_set_anon_name() down the file To: Vlastimil Babka , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Colin Cross Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250624-anon_name_cleanup-v2-0-600075462a11@suse.cz> <20250624-anon_name_cleanup-v2-3-600075462a11@suse.cz> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250624-anon_name_cleanup-v2-3-600075462a11@suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QBEZNWZ1kIpt2K1p6RkuEn6Kp0wNrzRL9CmOuOzR_Ek_1750773930 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9510E1C0020 X-Stat-Signature: bp1165thqgj78nxgxkr7rn1qmjw87f8k X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750773933-563867 X-HE-Meta: U2FsdGVkX1+rs/jq9o44469kHPMSZEld21ai6mCJx6czJPbahbYXsO/eHEiOqeeMg1soJZzGgq2nlGNYyp+nKptcyfOkKOtV0qPw4bu3QtyMzdzkw09UuAZkp+91uy8o6/KxlqKQOXWFhyvrOddfe0zR8Ll+QkU1nfePpAkaV8OvyZ4UdelXndZM2abQ+uOnHgCpyhMQYeGmA5Tm7bQ7It/ZnMOKW1Q04+LriBbKYH0cqmkUEtlgouxSqmA9ISdxGbgRPjYcUnTJ4sMRbQrx3S7IiuUNro7BpmYvjnBmFD8uhlwniQLYOGq9gLb3dRjIrcp7OuzgbYN2kAR3KJeR8t4V/932Ewl8BzT0M6LmyY9V7Bx2CzbuUBjwpQLOsmWjKRn4HjAf7ykdrbkiHljqfG7SjVPAceOmjuc21ZWv1q1eOCTSBj4fjTJm44gUc/hbaCw6WhKTfu65WgH9oEy7XfVM/XeqjWl+N0ErUDQlgw16PTaXddTL29PD6Sk38mD05NfwQCbdmgDIGOXUCgTThFDgguZC0/e1RLq3se+kCQfGj/AdUr9nTWmWspbGp/65u4WNYnyrNyey9hKd8z1/5fL63oSG9aj6Cu0D81AboR5Iej5TOckznCt+LSm9mz4h3R1+nAUgrvHoyKXwZprFu2eP4mYhWOnm/f3F0qoLMIbYHhekvhxqwoeTxCpTMPqUKn8929jSfJ4+pV+6EDMZZRJBCrjJjJhxNhmJgm93wiGa9oXxaemimBo8yGrtLemBN/PwH4ZwzqS/2qLj3RoeFbULhAWfJjV9RxLVa5tk6WTwwX1uCZ07oyeNdS+JDV76+5l0ZulpXG38A6OpK4B5GDLnMIjv4eY62Pf8boTcO/ajd/UDhBzQPeSP60FdsdtLvJ1sQvc1EZJQbeezGxJHDlSSMFDCcRc2/9eaBymm8jUIPKNAWWSMmVTYcTs/Ci+olK4I6bJ7A0HjCSU+RC+ FghnDqVY FTzH2LvlLfdnCxBiJTeWgdV7K7vaPMN5PcOl++47JhWlfYhNnr0YEOrCMMDm1E7r9E9mtH5Z3kca7bn9XFZO8baY05NBtIQyURQXiTSMjCe5kvBLrIyGsZD9C3dUK9q2O9TFNVNbBug8hPfhANie3rAqrktk/Vv8qW29QhKYdAXYsv5UmJo3W1GjMO8+LsHPh2fc9/tWfFmbgm5d+0RIqqPAxztNqxCdi+a4ReY7ObUxIjwvgryd41hI4QUoW54BEQ/fODa/iFZz2LN1mPTVKVpR+lEjVzBMOfE1UR4btYyCi7zWqnJdlsw1PkNScmLsg7d36rvkZMUXF9YKR+ITu2rNAoLxXGPjGDmi3FLQmA7AKGOa9kHJIJCCKHDPZ1rJ1OQsQK959n2IDxry9wGmkz+hXj/fspKSfOQ5j46jOuLlhzGlG7158vtr6ZZHkJ5ZBDFRwKiiFthU2crwO5NofqNmqQkTI1evkxZAvLSajJbWeNz2nq7dqMJf3QA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 15:03, Vlastimil Babka wrote: > Preparatory change so that we can use madvise_lock()/unlock() in the > function without forward declarations or more thorough shuffling. > > Signed-off-by: Vlastimil Babka > --- > mm/madvise.c | 64 ++++++++++++++++++++++++++++++------------------------------ > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 7e8819b5e9a0f183213ffe19d7e52bd5fda5f49d..cae064479cdf908707c45b941bd03d43d095eab6 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -133,38 +133,6 @@ static int replace_anon_vma_name(struct vm_area_struct *vma, > > return 0; > } > - > -static int madvise_set_anon_name(struct mm_struct *mm, unsigned long start, > - unsigned long len_in, struct anon_vma_name *anon_name) > -{ > - unsigned long end; > - unsigned long len; > - struct madvise_behavior madv_behavior = { > - .mm = mm, > - .behavior = __MADV_SET_ANON_VMA_NAME, > - .lock_mode = MADVISE_MMAP_WRITE_LOCK, > - .anon_name = anon_name, > - }; > - > - if (start & ~PAGE_MASK) > - return -EINVAL; > - len = (len_in + ~PAGE_MASK) & PAGE_MASK; > - > - /* Check to see whether len was rounded up from small -ve to zero */ > - if (len_in && !len) > - return -EINVAL; > - > - end = start + len; > - if (end < start) > - return -EINVAL; > - > - if (end == start) > - return 0; > - > - madv_behavior.range.start = start; > - madv_behavior.range.end = end; > - return madvise_walk_vmas(&madv_behavior); > -} > #else /* CONFIG_ANON_VMA_NAME */ > static int replace_anon_vma_name(struct vm_area_struct *vma, > struct anon_vma_name *anon_name) > @@ -2109,6 +2077,38 @@ static inline bool is_valid_name_char(char ch) > !strchr(ANON_VMA_NAME_INVALID_CHARS, ch); > } > > +static int madvise_set_anon_name(struct mm_struct *mm, unsigned long start, > + unsigned long len_in, struct anon_vma_name *anon_name) > +{ > + unsigned long end; > + unsigned long len; > + struct madvise_behavior madv_behavior = { > + .mm = mm, > + .behavior = __MADV_SET_ANON_VMA_NAME, > + .lock_mode = MADVISE_MMAP_WRITE_LOCK, > + .anon_name = anon_name, > + }; > + > + if (start & ~PAGE_MASK) > + return -EINVAL; > + len = (len_in + ~PAGE_MASK) & PAGE_MASK; > + > + /* Check to see whether len was rounded up from small -ve to zero */ > + if (len_in && !len) > + return -EINVAL; > + > + end = start + len; > + if (end < start) > + return -EINVAL; > + > + if (end == start) > + return 0; > + > + madv_behavior.range.start = start; > + madv_behavior.range.end = end; > + return madvise_walk_vmas(&madv_behavior); > +} > + > int set_anon_vma_name(unsigned long addr, unsigned long size, > const char __user *uname) > { > Personally, I would squash that into #4, given that #4 is pretty small ;) Acked-by: David Hildenbrand -- Cheers, David / dhildenb