From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A805C433F5 for ; Wed, 20 Apr 2022 19:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BECC86B0073; Wed, 20 Apr 2022 15:34:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9C446B0074; Wed, 20 Apr 2022 15:34:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3DC16B0075; Wed, 20 Apr 2022 15:34:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 95C026B0073 for ; Wed, 20 Apr 2022 15:34:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6068326128 for ; Wed, 20 Apr 2022 19:34:37 +0000 (UTC) X-FDA: 79378259394.09.2E848B3 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf28.hostedemail.com (Postfix) with ESMTP id DC63AC001A for ; Wed, 20 Apr 2022 19:34:34 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id c15so3102901ljr.9 for ; Wed, 20 Apr 2022 12:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tjgtD5b88stSGfQKWtLEKZrrmLsw2qkBuwSeeJ0zuRk=; b=REQ3x7fKLP/EuTnv0GmQmMXaaniRwUtG/2NAsMQ0MKCDkm1I6tRznXQUJsItKuoTlm p2MF8iE5Zzu70G+Gasx2709mXA32PLi1wAASYvs9Q+xTSQ6+D9l0maFctJ2wOTMXGrai bXT3nA9aBaIPBAQsD2PONNhOJkMpkO0CtaImBZd91OqIgwwKnIukZKvAOeSfejYz+uoA pmSTmTrd9MKdpBJza5p0CZyEbb97EnQ4kmBNIyEBE9MjU3kxGEbL/vd8cAMOmYYBgV+E cM5GkendfRXfCHNQhG1krUj2XdXAt5aLy1IZPHTXMHM/5rGHWxU+ZYijqStV6BvlSlGD r2Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tjgtD5b88stSGfQKWtLEKZrrmLsw2qkBuwSeeJ0zuRk=; b=A4i/KOGvTROxJTUo1ACr3usME5aZq5kGdgDht547gw5+8iP1Q3ENUzVg2Hx1mGe1A4 5nDyHq8OK4FhlwWb0ZKlsPCgiWsiyyWP+inOOmkeJLRB+1TFLF6BPTOPrtXdgVxNkKgF s0v0CJ0ZlUKcu/ukSfNd3U7CjCeByQLyQn7DK6+iu7fDIZzvoibJqDxozMd62ha/EuL1 gZ7yuOC6H1FXqN8bCVctraSLgkAUHETusgD67qYrsb8yybG6NnW4NNhvmEq2Ed++CKgS UZEHUPAQaJAT/0Zj7s6WOoVNwo6zo9m2qistL1ucVBPr6zVp69NTcGBO9M5NRaH/WI43 uZsg== X-Gm-Message-State: AOAM533flVIckwmR9wMsSYVx6H2b0pW9VDrTvIiydEAUle7YiDkyl3LH 1e2rvG/n8IjG7kMlC1/ZEgs= X-Google-Smtp-Source: ABdhPJxsHjCQqq6WluovUBYdrQyV3jelbuozqG0OYcQa6CZdvrrYWe8QWnKWHKNYaNel51RNGyzwhg== X-Received: by 2002:a05:651c:905:b0:247:e451:48a5 with SMTP id e5-20020a05651c090500b00247e45148a5mr14529352ljq.313.1650483275515; Wed, 20 Apr 2022 12:34:35 -0700 (PDT) Received: from [192.168.1.38] (91-159-150-194.elisa-laajakaista.fi. [91.159.150.194]) by smtp.gmail.com with ESMTPSA id d14-20020a19f24e000000b00471a405963asm698679lfk.304.2022.04.20.12.34.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Apr 2022 12:34:35 -0700 (PDT) Message-ID: Date: Wed, 20 Apr 2022 22:34:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH RFC 0/4] mm, arm64: In-kernel support for memory-deny-write-execute (MDWE) Content-Language: en-US To: Catalin Marinas , Kees Cook Cc: Andrew Morton , Christoph Hellwig , Lennart Poettering , =?UTF-8?Q?Zbigniew_J=c4=99drzejewski-Szmek?= , Will Deacon , Alexander Viro , Eric Biederman , Szabolcs Nagy , Mark Brown , Jeremy Linton , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-abi-devel@lists.sourceforge.net, linux-hardening@vger.kernel.org, Jann Horn , Salvatore Mesoraca , Igor Zhbanov References: <20220413134946.2732468-1-catalin.marinas@arm.com> <202204141028.0482B08@keescook> From: Topi Miettinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: hdeeb985bwpc1pu77nzznbcwtoz7fanj X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=REQ3x7fK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of toiwoton@gmail.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=toiwoton@gmail.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DC63AC001A X-HE-Tag: 1650483274-637827 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.4.2022 16.01, Catalin Marinas wrote: > On Thu, Apr 14, 2022 at 11:52:17AM -0700, Kees Cook wrote: >> On Wed, Apr 13, 2022 at 02:49:42PM +0100, Catalin Marinas wrote: >>> The background to this is that systemd has a configuration option called >>> MemoryDenyWriteExecute [1], implemented as a SECCOMP BPF filter. Its aim >>> is to prevent a user task from inadvertently creating an executable >>> mapping that is (or was) writeable. Since such BPF filter is stateless, >>> it cannot detect mappings that were previously writeable but >>> subsequently changed to read-only. Therefore the filter simply rejects >>> any mprotect(PROT_EXEC). The side-effect is that on arm64 with BTI >>> support (Branch Target Identification), the dynamic loader cannot change >>> an ELF section from PROT_EXEC to PROT_EXEC|PROT_BTI using mprotect(). >>> For libraries, it can resort to unmapping and re-mapping but for the >>> main executable it does not have a file descriptor. The original bug >>> report in the Red Hat bugzilla - [2] - and subsequent glibc workaround >>> for libraries - [3]. >> >> Right, so, the systemd filter is a big hammer solution for the kernel >> not having a very easy way to provide W^X mapping protections to >> userspace. There's stuff in SELinux, and there have been several >> attempts[1] at other LSMs to do it too, but nothing stuck. >> >> Given the filter, and the implementation of how to enable BTI, I see two >> solutions: >> >> - provide a way to do W^X so systemd can implement the feature differently >> - provide a way to turn on BTI separate from mprotect to bypass the filter >> >> I would agree, the latter seems like the greater hack, > > We discussed such hacks in the past but they are just working around the > fundamental issue - systemd wants W^X but with BPF it can only achieve > it by preventing mprotect(PROT_EXEC) irrespective of whether the mapping > was already executable. If we find a better solution for W^X, we > wouldn't have to hack anything for mprotect(PROT_EXEC|PROT_BTI). > >> so I welcome >> this RFC, though I think it might need to explore a bit of the feature >> space exposed by other solutions[1] (i.e. see SARA and NAX), otherwise >> it risks being too narrowly implemented. For example, playing well with >> JITs should be part of the design, and will likely need some kind of >> ELF flags and/or "sealing" mode, and to handle the vma alias case as >> Jann Horn pointed out[2]. > > I agree we should look at what we want to cover, though trying to avoid > re-inventing SELinux. With this patchset I went for the minimum that > systemd MDWE does with BPF. > > I think JITs get around it using something like memfd with two separate > mappings to the same page. We could try to prevent such aliases but > allow it if an ELF note is detected (or get the JIT to issue a prctl()). > > Anyway, with a prctl() we can allow finer-grained control starting with > anonymous and file mappings and later extending to vma aliases, > writeable files etc. On top we can add a seal mask so that a process > cannot disable a control was set. Something like (I'm not good at > names): > > prctl(PR_MDWX_SET, flags, seal_mask); > prctl(PR_MDWX_GET); > > with flags like: > > PR_MDWX_MMAP - basics, should cover mmap() and mprotect() > PR_MDWX_ALIAS - vma aliases, allowed with an ELF note > PR_MDWX_WRITEABLE_FILE > > (needs some more thinking) > For systemd, feature compatibility with the BPF version is important so that we could automatically switch to the kernel version once available without regressions. So I think PR_MDWX_MMAP (or maybe PR_MDWX_COMPAT) should match exactly what MemoryDenyWriteExecute=yes as implemented with BPF has: only forbid mmap(PROT_EXEC|PROT_WRITE) and mprotect(PROT_EXEC). Like BPF, once installed there should be no way to escape and ELF flags should be also ignored. ARM BTI should be allowed though (allow PROT_EXEC|PROT_BTI if the old flags had PROT_EXEC). Then we could have improved versions (other PR_MDWX_ prctls) with lots more checks. This could be enabled with MemoryDenyWriteExecute=strict or so. Perhaps also more relaxed versions (like SARA) could be interesting (system service running Python with FFI, or perhaps JVM etc), enabled with for example MemoryDenyWriteExecute=trampolines. That way even those programs would get some protection (though there would be a gap in the defences). -Topi