From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CFBD49798 for ; Mon, 2 Dec 2024 03:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02DBF6B0088; Sun, 1 Dec 2024 22:32:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F03606B009A; Sun, 1 Dec 2024 22:32:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCABA6B009C; Sun, 1 Dec 2024 22:32:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BDB026B0098 for ; Sun, 1 Dec 2024 22:32:10 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 76E6C160BF3 for ; Mon, 2 Dec 2024 03:32:10 +0000 (UTC) X-FDA: 82848595326.15.C069C9D Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf12.hostedemail.com (Postfix) with ESMTP id 035094000C for ; Mon, 2 Dec 2024 03:32:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733110317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HfSCSaqhuY2KeMufqefno7JXy9/JFBmbr0Q3XEYlNp4=; b=Keq/dgrPcZ0tyRUYSm6ghU2FGFhbImwxgiTVhP6pSfvQT4H/I2R5/n90mM6hU+BWingiGZ wnBsOlMEtKuq3oL2wKHCiGUnO0X70ZYJOVpXXAggnwtjeOdCWc7hQvPPVPUmYjmsNv0sal KLtc3u7QtQQOAfsJ63d3oJtGYa6eCts= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733110317; a=rsa-sha256; cv=none; b=lOiIDjqqB50xQ230mak4vPKl08eh9YrgnADWOgTjeMc3aeTRQ5AnUoaswF9XcS6hu9b0AQ DVfD6p5lFWW6vspe7yujKzTPmpr3E9KFMcai4r/zjAVdnNwRYRcfUOCgwd5yq6/vyQq8A6 ljVfB1yx3s8b2a1AucZKXOSdnUsMUlw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Y1q6r2nT4z21mH6; Mon, 2 Dec 2024 11:30:28 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 2D67D1401F1; Mon, 2 Dec 2024 11:32:03 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 2 Dec 2024 11:32:02 +0800 Subject: Re: [PATCH] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory To: Andrew Morton CC: David Hildenbrand , , , References: <20240712064249.3882707-1-linmiaohe@huawei.com> <20240712140921.9aa90b18d22e67417d59dfc1@linux-foundation.org> <8fe349f9-d3d3-65ab-6045-da0bd19249ea@huawei.com> <00e18339-d911-4332-8732-e31bcecbf823@redhat.com> <5f8107e2-2b37-d899-f7f2-5a6093d8b089@huawei.com> <0519bf4b-49aa-6b81-a041-362a171b2a5e@huawei.com> <20241130225953.dbb95dbf5f6c785e931f45f7@linux-foundation.org> From: Miaohe Lin Message-ID: Date: Mon, 2 Dec 2024 11:32:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20241130225953.dbb95dbf5f6c785e931f45f7@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Queue-Id: 035094000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: dmyjydpos3wpxxqgktj9prrf1izrr3mc X-HE-Tag: 1733110322-425350 X-HE-Meta: U2FsdGVkX183Jlz1FUMmy0S7ol0PgMdPqjAywEDOhPAZnoCnJiF1SsFxarqLVsUjJy27c24PvISS+XDM8SvYzTYWb7gcMQ2T/cU1YPZobjYW8BRRZYOMln+b5m7Q9o+agIxZI2zmVuu9yupWNVCfDP4jbN7vmSKZCYlUKfEKn1YUDDog4UqPR83WinmflnxFuDbuDMC5nT7iUlx8FvZB/9SPR3MumnFwaRoMkNI3/oQaQ2/Xc7lVKaDom+NxKQhGN195Z48rfiqhKPF1I0eaZHUsF6Www0H46c0WBlZpFDa2BZuIsPylfXEsrhDUAlRQZT2QS5uTEtwCbd9g20uu6qSoGAx0yOebYRjAqtOnD7L7MCmvm+zRszA+kV1Yj29V1zPOTPnVwZCEVPa6W8mNC1FQF2v09s0OdRelgc2f+R0v+pc2QfXwNoil8EqnpCOdYyc1aUr7XXbkEHqJ8uAtDmb+mcbDoHTNPoDMKfhqMG+wy8MQioqxpcEE9bWV7qQaWBkqCgJko15L62pGzF+C+a4/6soSGfPGK0TkN5GxiB4ouQiG6qzDJcq6lFv01gyVWzbC9ZvyxZqsStN6fEnmU3CP6bphzHJZc92V1QV96dyY5hgDYXB+BWSRXOxEgvBKd2f7+mVH9kRoFjKQ2IGGx4F4Za/VdbufQEn5lmL6AQZBpSWT7SO2VpoKwbQoWlJ2ZFo8jnyu4zYKIpS78gqby2Xlo44amcyvDbADthguMT2RrX/gsUvlgZJqftDspIaEm8o0emsCEgvU5GdYVrvysiQyRLxDnYXymaPmPJ7ELr9hbDTcvsRKKoM43WO5Eqr0r9UTR7ramqWl5TQjseATj83SWRA4xe872BjVnqcF2f3TNrct86zbqg3q0ANM2U4jAD7iumIHWdypimypkL1VV2wKrqoQQFpeJQE0xirEmRMa6uvQWZT72kPJQ5qA2ne3tSH8T9947/N8jTaUcKL SnctEKRs j1Qr5uWwqlOoEg8EEe+tmWz8roEsgTFjMfacCM3HzRqCu7ZrLM+sBOdXAwtBQYj1ankAluvK+VV6Nl/0WW8Tl8VN8D2pNnYJgG3wfmA+a81BuQXLF3WVKMC138ovhNQ9gLx3edq3yPGxuXqlNa+i/OPHqjYL/YJEiDipCIxIcw58en9B0YGZjO2qAk74MuBJ1FYE8JHeHIpInNfn1Apf9Dst/JCbgYGNcCi+nK0aCU6aSB1Kjm7aeOkRPUgYKygXVotxAg5aIhtbt1tw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/1 14:59, Andrew Morton wrote: > On Mon, 5 Aug 2024 14:25:14 +0800 Miaohe Lin wrote: > >>>>>> Yup, this will be a good alternative. But will it be better to simply check PagePoisoned() instead? >>>>> >>>>> The memmap of offline memory sections shall not be touched, so .... don't touch it ;) >>>>> >>>>> Especially because that PagePoisoned() check is non-sensical without poisoining-during-memmap-init. You would still work with memory in offline sections. >>>>> >>>>> I think the code is even wrong in that regard: we allow for memory offlining to work with HWPoisoned pages, see __offline_isolated_pages(). Staring at unpoison_memory(), we might be putting these pages back to the buddy? Which is completely wrong. >>>> >>>> I agree with you. Thanks for detailed explanation. :) >>>> Thanks David. >>> >>> So ... I assume there will be a new patch? :) >> >> I was just back from my two-weeks holidays. ;) I will try to send a new version when possible. > > Maybe I missed the v2. I'll drop this v1 patch. Sorry about that but it slipped from my mind. Will send v2 when free. Thanks. .