From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D227C5475B for ; Fri, 1 Mar 2024 20:04:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 329706B009B; Fri, 1 Mar 2024 15:04:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D92E6B00A1; Fri, 1 Mar 2024 15:04:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17BF86B009C; Fri, 1 Mar 2024 15:04:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 006A16B00A1 for ; Fri, 1 Mar 2024 15:04:42 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 855041607F9 for ; Fri, 1 Mar 2024 20:04:42 +0000 (UTC) X-FDA: 81849548004.09.0389B48 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 9FBF34001F for ; Fri, 1 Mar 2024 20:04:40 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=A3CNMZt8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709323480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ul6pAsiH3Cf2VNyIM/Eaw82KrFx/wNv6iML+Aou3/Pg=; b=0bjww0NcoS7ynhfIO7RQsjkKNo43HbQuRhZ5n5EbFsBjNzHMdW7o7NXvBtfVMnR/mPbLj1 O8bhwGg4mEBCGkcIuKiN+S74wqGdavCiUh6uaisj4v3ZAAlNJClMc/2KkjGXtMjqMEsxn9 G5Vib3SMZUz64swIzmsJKhzgCM3XVqY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=A3CNMZt8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709323480; a=rsa-sha256; cv=none; b=y/MDATlg9ityNIiL6meWEE/BH7/X0mQzroE6dbbZL8rwc79ipVLjHp+g73U4/1w7TNiOWD Hx7VxmAANNTTBEppr73ed9I8wiPmSlqAyc8a42Y+SP+/tlJd0AwEqlaW3wCGtvBZZ5hGcj 4u2RcoNmo3e+Bw0RtFc18kHbeXnYEO8= Date: Fri, 1 Mar 2024 15:04:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709323478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ul6pAsiH3Cf2VNyIM/Eaw82KrFx/wNv6iML+Aou3/Pg=; b=A3CNMZt8ut4JztwS+Y5BGVeJ949fLchBZBLX+LjjOB9qhCB37l3Kv4Ia1etW8FyEJCLtbY FJSRMeGGOUTJ7Aicne+l2al3woE36zN1vkYYx6T/1gep55J7tlVJOzBCBgCtnG9kQWE6CI d6DCw1va/+qdTPCdgDZyZryyqthecmE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: "Pankaj Raghav (Samsung)" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, djwong@kernel.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, david@fromorbit.com, akpm@linux-foundation.org, gost.dev@samsung.com, linux-kernel@vger.kernel.org, chandan.babu@oracle.com, Pankaj Raghav Subject: Re: [PATCH v2 03/13] filemap: align the index to mapping_min_order in the page cache Message-ID: References: <20240301164444.3799288-1-kernel@pankajraghav.com> <20240301164444.3799288-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 6su8nwdasdaeww99813b4ss4xd586xdi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9FBF34001F X-HE-Tag: 1709323480-425755 X-HE-Meta: U2FsdGVkX18P+59mjLqVoTr+Ph0trknwG/fqmJOrEEdEGJH6CUlRSweffQqvexeD4FJ3p020pm4N7lFW/UMEAMDIptVmuGy2dXki4pGQa6x8WbfJPsJPpNVM+JBqvf2GUdtZBJcBzbANo60hv1leE9LIFlGbUnUJPWoD0qmtb9rhQWDLPSXAQg93LE13GFvGD8iHO8U/coxohIlOH4zjLrzZWl5W5kaePA8ZWqrtJpXiJfLbzybrhBsI9BDrq6zYc2OJy38VDh0SqWI8ug3rkElCJ3lLrybKYxQzdqBiez2QVxAANMbrCZ9+8IHRqqN6Zy/2Z/VXrZWOI/j4JNeR3E3Z63VtXvRZVFoiefhtNiDxx+ZuaQu8S2Rd41KOESCV71WBReGY2QiwCwGrJfigyQOtAAcSMRZDnDVSwNEfnGfDXPFhiopiYP88b7lR902pGekjjXEGFKYjPAgM91zPuGqkOUo+dyomuevhWdxMpEW+/z7KyUZFpObAGKazFMQwcOTpsRIaBw9ULNamKe9JzAMHIuEAwnkz2LDF9oEg9XYH2z1+lS1NKQCePCED/zhsXENmtRx2oBNdHtdhy5MHboVPyjdclm5E26o6lb1n4i1nxKluXYG6csKLhPvrGjJ4SOyRZMAiJfVbARtnOeD1j/NoowSo1TCYSAa979bIaeKqoSqDCpUfHtUANjfoIqdoPvko1fUeJd0eob6796ulZ3WGRyNMiVvKQQuc7/aWA5KlLRg1xCPY7KHZf7sAXCsmjvYgqO5af4nBLqoMVVt8W+M25EcXiG/nqeF7AhP07SdTwVQcwMDUeAaRJaKPhYD82892p80joZLlkuF+qzwakWeZlAGoDY6HpyBXXnh8WG0bTn7yHtGUrbmBk0I7/QlUpuBQVDg0tSBlaJ+xwnogq29Yi3TVDLv9bd4O8k/qogXkGeHTX9vd6/GfCRvdCgaCrGFI3qnkm7J6NHMMhVi V9sSq3BF WIUsYM2iNwN6K6Bk+f/fYa8zKM4UnFC5403SBMih1TBmBIa7cLMnc2PWnfMHZH+9hfiYKno5x4IQ5UP+A9fskljBW9EBzw6xgpfkEibhF5ZL/B5ButcYWlL1EjegEciZ0Lo0c X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 01, 2024 at 07:26:55PM +0000, Matthew Wilcox wrote: > On Fri, Mar 01, 2024 at 05:44:34PM +0100, Pankaj Raghav (Samsung) wrote: > > +#define DEFINE_READAHEAD_ALIGNED(ractl, f, r, m, i) \ > > + struct readahead_control ractl = { \ > > + .file = f, \ > > + .mapping = m, \ > > + .ra = r, \ > > + ._index = mapping_align_start_index(m, i), \ > > + } > > My point was that you didn't need to do any of this. > > Look, I've tried to give constructive review, but I feel like I'm going > to have to be blunt. There is no evidence of design or understanding > in these patches or their commit messages. You don't have a coherent > message about "These things have to be aligned; these things can be at > arbitrary alignment". If you have thought about it, it doesn't show. Don't you think you might be going off a bit much? I looked over these patches after we talked privately, and they looked pretty sensible to me... Yes, we _always_ want more thorough commit messages that properly explain the motivations for changes, but in my experience that's the thing that takes the longest to learn how to do well as an engineer... ease up abit. > So, let's start off: Is the index in ractl aligned or not, and why do > you believe that's the right approach? And review each of the patches > in this series with the answer to that question in mind because you are > currently inconsistent. ^ this is a real point though, DEFINE_READAHEAD_ALIGNED() feels off to me.