From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EFDC021B3 for ; Sat, 22 Feb 2025 00:18:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7084E6B0082; Fri, 21 Feb 2025 19:18:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B7D7280001; Fri, 21 Feb 2025 19:18:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A6A76B0099; Fri, 21 Feb 2025 19:18:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3ECF96B0082 for ; Fri, 21 Feb 2025 19:18:55 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B46C6160B37 for ; Sat, 22 Feb 2025 00:18:54 +0000 (UTC) X-FDA: 83145670188.26.2D1232E Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf15.hostedemail.com (Postfix) with ESMTP id D4F06A0008 for ; Sat, 22 Feb 2025 00:18:52 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qsXNdX9h; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740183533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k2DkFMFVwJio9H889cSd6PIdCJnBPZmSuOMV6zvFHRI=; b=E/7zJvI9nhtspg9tOHqT+ZPVKMNU0w80+QLcnMiufG4ErAd9MaIsz//kAJ2ZQHjNItXQ/6 CUMyITnnoOBmpECqK2mas71k9xdcjKjPcYvlENpS9hUZ+0qVKHxvwHOmuYT3FmD+opvswO Sju1X+VTe7lf7bHpqjzG8wfWxFHt2jo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740183533; a=rsa-sha256; cv=none; b=oyR5q63xqf25QrQs4b+DoNF3t5usjvseRuEkjWjALzXvZJdiVtcSkd6u27vrPcErnEnoPi dbX1YRgmTkzErg6qofmjc6vnXpX2nmaPA10j+ERtQ31iGOPRhFh4c0t2elpgQQZNeiYSWr b/+wdb1BlqQ3MwVHuT05GdUOCBnefPI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qsXNdX9h; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 21 Feb 2025 16:18:46 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740183530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k2DkFMFVwJio9H889cSd6PIdCJnBPZmSuOMV6zvFHRI=; b=qsXNdX9hxJpzedZf/7Gwc9bYV5MZjOPWTaO2Cmp1X58GzDU3rPCY829lFt5tRRrlEll9kh Ec80/VTW0cor/nWyjQaYq7mSSFpn80A6I907FGEF4c23vEeek1g+uXm1d11OKxvHkUqu/k mchWk/e1MolVzQAo0IQIwVZjjL+Tqp0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 08/11] cgroup: rstat cpu lock indirection Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-9-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-9-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: D4F06A0008 X-Rspamd-Server: rspam07 X-Stat-Signature: com8ioa7eyqysht6msbte73od9idiswp X-HE-Tag: 1740183532-956069 X-HE-Meta: U2FsdGVkX19xlynk2613GUnXSrxPMV83nascFbT6AbQibzwARjOuiShzpweTgxXBWCwvntHApzMsmkgdn1XA4bdN0luKRA3Hs0hixmfKFHXakVC0mX7kWt0S8JMhydhaB7H5Sx9hxVpGwdFyVWic5oHaFERP/Z1QmU8yZn0EwDwRuAeHHT/9KE0/zvSLIVwG3eED4dB1ygvXHA4w65EWDjWJkep8/7M+mTHkYH7VvxISD7e+WAUl+kRipgmuyj1PnnQv5e8pTR8wAGZ6kOvKLptBJVmYkCczr1WZVW3Tp3tR+bV8wjRp8d7QQhigfP1CQezjuGCOVUKroQmt6+sgiWOEkQUum8mxMUEvMLBpYel4SYNSsyvNqG6jFhPoC5uOwJf64I8JFeVlkLUhT509H4ZEKhXjyQoHfJuQ4W9oUMneO2pMjGe6QrngthsKNKITI06cwXHrArgFuglT9ZJXeprZqhtunKn6QKikiROTyn0XsHGa7VmlxZ7h8yjNMihnZVph0cEiK8CIB2nnd+7Fs/gaJHCCXFohmv9L4P7aSuHo1NlUOe5loTYV4t0boZWXcu7abT68l9l+aztYWCVK9K9fxp/4eLHLXpyiAY+H4DSxl7W3Gi8nKRPkVNJGtwf1jnHveZlTVsKTb7GFDSt0j/xHv7tR0THjjMa4ypQqTWBPaszCHeFklhPAMg9HjIH79Ig6etwsOIoPvOCJNlpXMkgPhfPbK5qpHW+qVN0S1kjUhbFueFR6ETsdY3lOvRmFRnCVejBhvOuotIhcpbzLjRl+cfpiogZ+63aJtkROMo18iL8hbTXD0F9BcxApA3PMtUriB6xKElfkRfylQ3s+mlf7x07cEAKiMafYqnIfDtOYa3BW4qHtTIB4Go9kt0lFb40d6UqRhPzEMxwgyhXEY8VDfaEjNfMfwtF1oBRS2EsX2BnptiMpkOyQolE3X2WEVGlWqUycqz+nDnByn+X +vVFodrh fhibzmoYKPTalQsHmyXkGLyVOK7uht34cOvOav/L7mP5kbNmS6RWvAy3QR1LuGxdUFjtlpzkC5c6tK4zYURYi0mZ/nO0qyRtdnKNWdvEHcVZkKpI9J9CmAm7JpNFCAzIavOcsa+EtWgGU7d7coinR6vWw+VeovuXNHikpPwD+zOzMCTj1Qs4iaAQp61U4JEe1nJf8SDRlJHdykCYRahMtmKZtKzDTdp/VqfbS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:45PM -0800, JP Kobryn wrote: > Where functions access the global per-cpu lock, change their signature > to accept the lock instead as a paremeter. Change the code within these > functions to only access the parameter. This indirection allows for > future code to accept different locks, increasing extensibity. For > example, a new lock could be added specifically for the bpf cgroups and > it would not contend with the existing lock. > > Signed-off-by: JP Kobryn Reviewed-by: Shakeel Butt