From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AB5C4345F for ; Thu, 2 May 2024 02:43:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 529706B007B; Wed, 1 May 2024 22:43:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1E76B0082; Wed, 1 May 2024 22:43:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 352EB6B0083; Wed, 1 May 2024 22:43:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1567A6B007B for ; Wed, 1 May 2024 22:43:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5E45B120D10 for ; Thu, 2 May 2024 02:43:22 +0000 (UTC) X-FDA: 82071909444.28.A4A3126 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 65048C0002 for ; Thu, 2 May 2024 02:43:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714617800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2cTSEMjpo0QHatw967vakzpCJ8owzlu9PzsCgfOJeBQ=; b=NodI4C1eTg2PRQXHoF31yaDFyjuKKWtAYhpLuw7bulyLFyLnF8nPOmahzP8KK+f9j4j89R xkJSqSVVpLumawIqP1CfyHTLg3Wia4nqS/rUbUtWgsHTt9bknmGIv9cA3pNt0VE1iO/9iB m6yxWawnnQJoMpWvXXD5XGeLKIFBXpk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714617800; a=rsa-sha256; cv=none; b=T/728K/qM9Uezi6x9gOxqp5wVFQAQpQgMlqUcu+4rnmT5eHH1Kzek1INv+HfJVpkTTm5MU S1D4jLsTYn1IWxFHOUwWMIBfVT/qARoAxNMPo2U8+ZNtZHYSPg29eq4739YiV1Nskx8a4t FcHFa/XtrwHEPyzlM0gVhAuR+RWnzLM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 201982F4; Wed, 1 May 2024 19:43:45 -0700 (PDT) Received: from [10.162.42.72] (unknown [10.162.42.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD2733F71E; Wed, 1 May 2024 19:43:17 -0700 (PDT) Message-ID: Date: Thu, 2 May 2024 08:13:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/debug_vm_pgtable: Test pmd_leaf() behavior with pmd_mkinvalid() Content-Language: en-US To: Ryan Roberts , Andrew Morton , Catalin Marinas Cc: linux-mm@kvack.org References: <20240501144439.1389048-1-ryan.roberts@arm.com> From: Anshuman Khandual In-Reply-To: <20240501144439.1389048-1-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 65048C0002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6hh99x5zb39dszfdpnifxwic1gu9qikr X-HE-Tag: 1714617800-543277 X-HE-Meta: U2FsdGVkX1+gjzyi72bFjWeju96+wEOEzIMztezq80wBAMO4s1KCI/bqtHvVWYHYDre8L/jdFsxo6g/+epq4PG9YWav4mrvO9Mj0O8zHHN8dmwjVcw+oa+6gdsp2bVZI5uttvQ5dOmO3evMdnkfc88wr3ugREQc0tOI/n+gjNHS4/yMF/Ca+QHe7yEtRvsIXGg66I1NLvRvtEeP69LFMDBPqZq+MawpPGyueqPpCx+iHnAizAV2njGgrGFVro4ow+IUEgDxqLKHpdi7E1ovWm+ak3ISqpsaOzaXOj4sA+DBlucbZhjy/XXJkrhWgEvOQofv9rcK8EufTwZ9sbFCY4nC4MbetIbSPYpn59CVYvHDgYbVs7C0sq2B8mTprar0IUa22nUnETRYx5jk5Va36a81YstujE/1+HjO9g0jiJNvRsYy7+B+JrSlgQ5W+j3QGNuofUYQcUTnT1ORkbxyUNduiRXgnVcwlwAz1nxlwnfPpPVJhmq4mkzXm4Qe7e+sKTlRa4r2BUW9A4nNJElPRJh72ciEPiRHiV095bCdL+7jkhyjgOHUJZtzKsUfinlMSuvm4cn4KfRpv5PHJp1zDaA0L5OhzYzo1dhTqgpD50G3B2OzXd7ps6EeJG4kdmMAW90pYcjDh0Mc049f14e9NYRupPCEE2KOnevizzN0QNaH9prg9L1nvds2N8Mp+k/Zul7xdTcNNGZqx64szqZARadKQjtmI9vcRm82ojPivxrnqjWkZyKAi4IzPp3z/OzKENV4my/ix7TMceW5lOjpwfRftAla1jS2cOWCgRsV56sUT0j2Fv/55yckVMFqDL04HIBR204toqDarfNS9A1PSD+K8YBuPFqhnmpAlmQXZz3i4Mg7yOeoH4nUc1bfkhGNsphzOf+W4827Q0jY1JUTtqd4KHy4Z9q/le5pcOtbj9jvsYxJzWpeqpO8bsOIdhGFxSGVBJjJOftd0887z428 uDYbnEOX XzWeCtKvb7HEVjf/NNMxNAZinlaYhI8jCOmxp+tgRIyONJQvm1Cf5EpZzGBo6Dv0GUUFcFIY2AEVmeCbH0Jzj0ZIq+fqvsCrRNVi17h/Ohgx7A81n1QpzJhRG3lGSlgukNg5kHu2tWszRD/4ex/JwfhGb0OYx3Yc+eqGkIGUwzgU13LSUGLekuMgynrneAuq9WEdqy0bu5TNPZb672h+guIb3RnyUCf3/08MWh/EGi7yNy3xaimwG/T1JjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Ryan, On 5/1/24 20:14, Ryan Roberts wrote: > An invalidated pmd should still cause pmd_leaf() to return true. Let's > test for that to ensure all arches remain consistent. This test definitely makes sense. > > Signed-off-by: Ryan Roberts > --- > > Hi Andrew, > > This applies on top of v6.9-rc5. It came out of a discussion with Catalin around > the pmd_mkinvalid() bug (the fix for which I just posted). I've run the new test > on both arm64 and x86_64. Right, works on arm64. > > Thanks, > Ryan > > mm/debug_vm_pgtable.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 65c19025da3d..57e9cb0820ab 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -981,6 +981,7 @@ static void __init pmd_thp_tests(struct pgtable_debug_args *args) > #ifndef __HAVE_ARCH_PMDP_INVALIDATE > WARN_ON(!pmd_trans_huge(pmd_mkinvalid(pmd_mkhuge(pmd)))); > WARN_ON(!pmd_present(pmd_mkinvalid(pmd_mkhuge(pmd)))); > + WARN_ON(!pmd_leaf(pmd_mkinvalid(pmd_mkhuge(pmd)))); > #endif /* __HAVE_ARCH_PMDP_INVALIDATE */ > } Should not we update descriptions in Documentation/mm/arch_pgtable_helpers.rst asserting that pmd_mkinvalid() also preserves pmd_leaf() ?