From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0430EB64D8 for ; Fri, 16 Jun 2023 11:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61CB66B0074; Fri, 16 Jun 2023 07:49:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CB496B0075; Fri, 16 Jun 2023 07:49:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46B3D8E0001; Fri, 16 Jun 2023 07:49:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 37DB36B0074 for ; Fri, 16 Jun 2023 07:49:51 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 07AFF1C8FA4 for ; Fri, 16 Jun 2023 11:49:51 +0000 (UTC) X-FDA: 80908441782.23.55E1F65 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf26.hostedemail.com (Postfix) with ESMTP id CFB2C14000C for ; Fri, 16 Jun 2023 11:49:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=j2jk7hnM; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=aLJq3EDO; dmarc=none; spf=pass (imf26.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686916189; a=rsa-sha256; cv=none; b=un0wBhAyke3aTgPzzzhx/lsMlf1w4J7A3YCLvRm7g7WT4Nmy+vGA40UC0R1C0S/nDmDX+A c1ZbOoC8MaeePycpGDra2yIlLnch4N+hEpcAeEwlQ5wIFiuDdI+aX0spwVSluXJknGsh4x sUl8D3AzTM4zBzucgTO+pFf7Zcy1tfU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=j2jk7hnM; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=aLJq3EDO; dmarc=none; spf=pass (imf26.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686916189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tsVaKnscihshn+XWUoAkmcthgbGHdIDlich8+0pF+Po=; b=0+m7b+NY6dd4MS/uTrvtMTU30zNDFU8VpRpM8nMNvddgGuzrKbzd+VLOzYFflSytgAYP53 JRWsS5LS+oTdbr2XAjhxnAWDb00c7L0IN++0Y/vnlQCAMK0zxpoSSkx4oxKWqSwWCPEXVB l39hHt0ohE+WnLPJaqSQaEGTEKStwDU= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E6E405C01E9; Fri, 16 Jun 2023 07:49:47 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 16 Jun 2023 07:49:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686916187; x=1687002587; bh=tsVaKnscihshn+XWUoAkmcthgbGHdIDlich 8+0pF+Po=; b=j2jk7hnMYxBOey5oHRkSD8gaeZTSCcobqv3aiWw+ab3rAa/D1BU 6lK5GIkx+HrTpmSn2pImxPRMQeJzcYjjT9eqMZEvwL9CQesssgoOEKXsQ+ljEMLB vTT+1VZzPjS1Vm71P2ZVdwSKSIGUbDd5kqUGH/JPtNY5ZIv/Bs96tNgFRgEsbdAZ Fj0ghQ4ji9YlzZ3Hb2fiRdh6A+vF0AxKhDIT6FLl6QzJKWTqBdqU+8qGKJt3gUmO 5Z8t5XA9hMEGsBjThGJWCyIz+cDD0tlO5y5KG+SJf5i1oyDOs8woSPvoiDh7l6Q9 x7/KLqhZFJlLSf5qI3XV6pOMfcvCkwP/P1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686916187; x=1687002587; bh=tsVaKnscihshn+XWUoAkmcthgbGHdIDlich 8+0pF+Po=; b=aLJq3EDO8qdzvIGcOCl1OJ+wpODOSNkEoOpSBAZHcCw2sYjASQA ng3wQ7jy0nTeQnK+dRUXiByYF5T40B5TlODGKNiIBVJevo3IJaP97pqVvWaEwBZd 3zql/G65FKhX4PCkMUzLfNBLQf6mYY4tW7mrmAj73z/Cc2SsARukKV3SO/HDohHe 4on6lXCa63WufHTFJSxzJsZEn/T6vI8bZ91Y4hs+edTp63UbXRmAj6w2blwB4Kz/ RHbHLjhB5LsUzTMZYU83+OtUHV+aYBupf8Tpe2imRcfmIldvlBqXuCdDOoqLge5I oQlDP9fUlIaDvH+6spFiHAqQHIAUdKckxMg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvgedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpefgkeeuleegieeghfduudeltdekfeffjeeuleehleefudettddtgfevueef feeigeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 99D64B60089; Fri, 16 Jun 2023 07:49:47 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-496-g8c46984af0-fm-20230615.001-g8c46984a Mime-Version: 1.0 Message-Id: In-Reply-To: <8bd6a1d8-a464-dc43-9ea3-a32c7f490bc1@collabora.com> References: <202306151506.goHEegOd-lkp@intel.com> <8bd6a1d8-a464-dc43-9ea3-a32c7f490bc1@collabora.com> Date: Fri, 16 Jun 2023 13:49:26 +0200 From: "Arnd Bergmann" To: "Benjamin Gaignard" , "kernel test robot" Cc: oe-kbuild-all@lists.linux.dev, "Linux Memory Management List" , "Mauro Carvalho Chehab" , linux-media@vger.kernel.org, "Nicolas Dufresne" , "Hans Verkuil" Subject: Re: [linux-next:master 7549/10326] drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:1022:1: warning: the frame size of 1112 bytes is larger than 1024 bytes Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CFB2C14000C X-Stat-Signature: yyt8ggeoi6x1fmnkyod4ucic35oq3gup X-HE-Tag: 1686916188-803599 X-HE-Meta: U2FsdGVkX1/d6zj77r34sg9dpf27Do53pWn3VestmgW8BVaQtidjs1TwMjwd8AphxFjkVKgBnE302p5FrmfM3uduIbW89TFO/CbeaxWLXO5nVPO3dpugmf00sPLj2c7LZNgLPncywaX1o48IqXq/CNs5QQ3DUDO9oXkGbqOWzimI2Ccm0DkUVi4YglR913808d1kAJiInBbXdhEiTsADV+pPk1q2toiBV/L0U0b+sn3c1Y2BYgqcL0cvJDDO4Ou1lR2FEhgGqBlURRX7oEtu7pLQByYikfgcf3iKGfM8rQrworIuKbHcNX95BkjHcOqHjFWfHUL/Pc32lL175gCuzhTRNwC6rVPCQ0rjygS8GO44DpzU2vqt0dPou7SrDViIauB/5kNRMA6kVA7/Lv3YOscC9H+u3ainrXLI5iJYxhq4OSJeLAqD5bG/RFoV0ttGoozHhuB7lD6wmszd0wUc/MJohwLBLzRXZCoPtreIQHCE1GYIIM95vyjDkKGtcftfOD16SjHkhA8i5hOcOu08VD4G7wU6Majc8jQ4COzAL5Rd9Ix1Hh5lP/kVVb4BkEBhFn5zLCBEeLwWBe+rFQqFotMGcOIr1NFV6/9KyLeuLEqkRzzOg0V23/ydcOmhu47Mi+i12wzYxZkPZM+j9lG7YwNWL1vBXBL9/fkV2UlQzA3N0u4zu1QUBwmT6uATkocUtEP4M1Il1dN5X1Ul0E8eTKG3dO9UQWJ0eTw5yXutdOBnUifsZZKXc8eRoTPJhsMA+iM9HuZiwSWhXRr0Gbq2EWWVFb6dhvDg+jpfMy/vS2M4F900t+We6tQKT6qXDccf9LLZhjbEPqv3WuS0Cw0P5itm7bkm66mGCwFHZVhrx6dA2oJubO3K2WyBNjC0Kp3ndM3vMPMPa615tzFIPO/4LUOfXOmRJGkxsW8UjBtGifvewaXFKLRTpmoNDc64UkZW0u836ZQvnMdgokrwDYZ P+eHxxGU laqGzYr/ujspYxTHWzOhoYnnBQJewgKczARY0n/DYEx2EKeyL3LWXOmai3VEH5AwNZGrDfxvCY33O+GGCyWFuReH7eJ3xLC7LUumn9oxhHBh1KZkB0RW+dqHXOekDwjLjsr7hhYMxQu+tILDP+d3kY8nk3LIRXb7GumBPP7r6gcjAe2gJvonLqMsXKKMJjvusYHHHGMMD3QIZtRkZ5DK7GBkZDZg4120VsyVnYTjG7c/zbexC/dXSMXO7HJ/X8qyl6ui9K1tBy8rluFpRGbDVSPw+9LcEIOwRy8VbowFvM2HPvlGvlwnUlmvQMNTX5Zm3aWyxXUaDMxhbVinYXIw8Lrk9pYFksI5ngF6vJERZbAd2J1WE9g0CqkudfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 15, 2023, at 10:46, Benjamin Gaignard wrote: > Le 15/06/2023 =C3=A0 09:35, kernel test robot a =C3=A9crit=C2=A0: >> >> If you fix the issue in a separate patch/commit (i.e. not just a new = version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202306151506.goHEegOd= -lkp@intel.com/ >> >> All warnings (new ones prefixed by >>): >> >> drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c: = In function 'rockchip_vpu981_av1_dec_set_segmentation': >>>> drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c:102= 2:1: warning: the frame size of 1112 bytes is larger than 1024 bytes [-W= frame-larger-than=3D] >> 1022 | } >> | ^ > > Arnd have alreaday send a patch to solve this gcc issue: > https://lore.kernel.org/lkml/20230601151832.3632525-1-arnd@kernel.org/ I just ran into the above issue with my workaround applied, so I think this is caused by something else. I can see one 256 byte variable that is a little too large to fit on the= stack, but that is not the main issue: u32 segval[V4L2_AV1_MAX_SEGMENTS][V4L2_AV1_SEG_LVL_MAX] ; The actual problem appears to be the construction of temporary arrays on the stack like #define AV1_DEC_REG(b, s, m) \ ((const struct hantro_reg) { \ .base =3D AV1_SWREG(b), \ .shift =3D s, \ .mask =3D m, \ }) #define av1_dec_out_ec_bypass AV1_DEC_REG(3, 8, 0x1) hantro_reg_write(vpu, &av1_dec_out_ec_bypass, 1); Each one of these adds 12 bytes to the stack, and there are a lot of them here. If KASAN_STACK is active, they cannot overlap, and there is an addition redzone around each one, but the case I saw does not use KASAN or UBSAN. I've tried a few things like removing the debug printf in each register access, but that did not help. Maybe you have some other idea for how to simplify this code. Arnd