From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520AEEB64D9 for ; Tue, 4 Jul 2023 15:11:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 510A3280084; Tue, 4 Jul 2023 11:11:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C10D280076; Tue, 4 Jul 2023 11:11:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38AAE280084; Tue, 4 Jul 2023 11:11:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2A233280076 for ; Tue, 4 Jul 2023 11:11:27 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BE14B1C8D3A for ; Tue, 4 Jul 2023 15:11:26 +0000 (UTC) X-FDA: 80974268172.18.31738A1 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf05.hostedemail.com (Postfix) with ESMTP id EB9A0100019 for ; Tue, 4 Jul 2023 15:11:23 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Hgm7cMwK; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688483484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mfwAeExHr+y1pYJrIRZuSm3ldW4dUztFq7/VB374kRE=; b=1PQ02x+iTOeX3ChIjpFJQSwBJBzHW/pkjcEHMu+10DZRe2BsFe/CJN/GLKNIINI2WniEK+ C4KhRepTD/aBjuHwwJ9PiWMqaILUwq95Ar2cKfgyqpLScqISTKAmFDtNDF2IAGgOhvfPEr cNsV+8/KlX0sMXWdvVmYsvNvq0u3QM8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Hgm7cMwK; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688483484; a=rsa-sha256; cv=none; b=gUSdcVFyzDYCwuCMEMocie8TzrZvTINon+EQ6KmW4/LveBcwqDYjrVWXCVdvaskLBIsTs4 Bx/G7KwVt7cFfX+T51HSHRglmbgeK4XBhH/UmtPL60mKfiTSUw3smPgjJFQ3dHmRRPxokh KloE7aLyW6c3Pv6HBEEPpQmB1yq+8EQ= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5577905ef38so2145675a12.0 for ; Tue, 04 Jul 2023 08:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1688483482; x=1691075482; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=mfwAeExHr+y1pYJrIRZuSm3ldW4dUztFq7/VB374kRE=; b=Hgm7cMwKS2E1aaVm4N2j15ZRGZeS5++jtefy5hLwxJBMqZdR2eZAiBCG7fH/pWo5/Z +Or2oafDAxsv54g5zDJsbcXVI+zkVT58kBPYKmGXDB7l6yD5YMha+39iqaZ5KkW7CLOB TMPiq2UJ4vd9OGze1qYwU7Hu+/6m4uyRd4mmMgNFc2wnwXgjxAbdMT45XQKdLGcPc421 V4q2JCY/dFgC0JbTxL5uAY3Px6fvyXB5en+Gwj65sPGZUClYy2MwkQbNzTZpl+Tl9Bym xgT3pVuyH66UTH2T/OqVTJP2f6MxdX42Ex1FddMPJc8t+2df4Tzfuekhm7W99lTwwH54 ZQUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688483482; x=1691075482; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mfwAeExHr+y1pYJrIRZuSm3ldW4dUztFq7/VB374kRE=; b=f3o3d7m5fpPh4OIe1wk4FWqZwUTKxgze4wjNQGiFm1/MjXm6VDR0iE/oxDcy+iEVBX HxFblRn7fgyFuNazMSJ6UDdMONskuc76dYFQlCG90ZoTwA9g8tpDLZIVx/uyZBUZaQTc R5BiFvQQ93ktE22mxIPC88afztOAnxl1pvCakSjUjLXECUQjYrKVogeRiMQnRcNNI0AK 0pd6+Ap+agZiptHcRRGheeAVbAZy8Dv/6e14kIMb1j/QyCnDmUVIXo5wjdj+B6b/tYLW AoWYfAK8ezYyC9tD9GYmQ6rw3PwT+8sHKsJMopbKxlHSNI5dMnJRRqJswI0U8Szc60xX FwyA== X-Gm-Message-State: AC+VfDyXiSHo9b55Ll/8DLQI9esXVhBaiK+dI67FTc8dbl467Haq+lVX 7yO3knM3r5F8OpqYANoR8q9KKQ== X-Google-Smtp-Source: ACHHUZ6lFU9RHatoa8CPtTUvL3I3VmS429+p4CCImxVgdfEnS0NnIkvpMK/ERbsPk9tKKuel9Z9Yjw== X-Received: by 2002:a05:6a20:5495:b0:125:a429:a19c with SMTP id i21-20020a056a20549500b00125a429a19cmr14123250pzk.48.1688483482403; Tue, 04 Jul 2023 08:11:22 -0700 (PDT) Received: from [10.254.70.13] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id t18-20020aa79392000000b0063d24fcc2b7sm9889956pfe.1.2023.07.04.08.11.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 08:11:21 -0700 (PDT) Message-ID: Date: Tue, 4 Jul 2023 23:11:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 33/35] maple_tree: Update testing code for mas_{next,prev,walk} To: Geert Uytterhoeven , "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" References: <20230518145544.1722059-1-Liam.Howlett@oracle.com> <20230518145544.1722059-34-Liam.Howlett@oracle.com> From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 8t4oyrbp4cjops6xcrru16ohix7pkhgk X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EB9A0100019 X-HE-Tag: 1688483483-833299 X-HE-Meta: U2FsdGVkX19zzif/CMNHYjb8HyONXkUcdzlR4AMZlICT51fwUcghfkVwEdfBcKotrI5k6zRVsm5B9toozNwCTrWXTuxBEmvapv2tTGwyyLUYIOU5P2+0PZ1K0AAgeLJedmisIl2DitfkfdSpP/523RXh6a5PTZmwSFHTq3FDHU4/o4AQqQpVM2Cx1T/pAfxfrfiys/3zsiNmmsp0+BhNdwoumEkkjMy4umYfPgqfDhWoCw3io1XLOOffj+VUM2nrnDCEm7u15P1SivngTf+zdpSB48t8jKXw7MoH2fNTu6sabo2Q//Y4qi2JRdN9PES0LyylnA5asnMEQXWCqVKxLMQZXhnQjyJEwVXNKvig45vzaCyhO9qULtwDcnUzHM26sYrolKDv2p68raZVoLAtWGY3PEDGqxjPcaSxTDI/Kv1RCG2p3z++BgzawyoFMB7Pd9YGIAlBiiZOnek4ejBi+9+sRcA4+xerhR1q9WvWj3RE5RDInJcaX63Rh2CthGS3IfxJw/lMneC4sLuqNhUPTYVqwWZVg9KMgs9KXhSQo6APTYn6AxoqIueulJvHJBsCZhTLxDWh+RMphQagDiCtN34NqKYWxkgDVog25YPQlv3WbgBJHVXRxhP5Tefl55GgBbwTLlBcpoSZP228Fgz5TMjLVHGt0zyZDOc9EiFkIsbN6FV0OAQF9wYaEnn7HXn9x/lWdXYKc1tUlFY9q6ll5iNJiULzw28Oe2VuUC8pTXrpbsYzMZACrZq7O+wbJAyGYSKlt/7pjxRVIeeygKXPaeoAqAs/8mQj42Qo2PlQBdk3MEx7SgoavWrK+8pvjop4WnZmWxipCby9i1+HwucvRgCxX6PvYRXSBNzMwwwwHN4TlFoyLdIVPcFPnRRoRsZkqOfB1d+1AgVbJDMtVd98DUsiN5kcrjnKCR1sxVElbwKVrTrm2JxpgVf5F+0u0o8FjZi4v938AZZ+LkoqY8z WWvigj6U Y7TEd1uNcmo5kMjklfvqJ4WyAgS7XC63gK5yzAw11o1cbyo/vCeYmz/6j77pSHQ29BCDW+16tgV4wCwUhHzhaejK5mlbLZUT9DITJHdq+waspfvzceSw6okHy4Z/E0X9UCjPfdC+lVgYyanxZkveLhkfS/A1J6EacaLxe7Eps80bTEvBRriPsI8b2NbQnTE010L8hfEMXKrvJD7ftj8lMRAuaAnr12dNj61BOomji1ksf3pkTIzz6DAr0dEdPPPcz2l9JNxFeSi+AIFARGrE84pHOB0pBbbRKO0ZBJBnUK/W09wqHpNgfebDT/HsbomEri3bfF9OKbOZvUo1yqaj8JBMkDqVRj0yO1UNmMGzt0fLHITxf/xoAO49au2KVWX1vljUNogghHOnxUo++fwI+4QfTF3XdIFEc7O7RdGQctsumkbRduMO9h899TEUeCHw6jRKDmAAIijA8emvocDcXbVNaEJRqiyCBoyvpHOlWlPZaRFE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/7/3 02:20, Geert Uytterhoeven 写道: > Hi Liam, > > On Thu, May 18, 2023 at 9:37 PM Liam R. Howlett wrote: >> Now that the functions have changed the limits, update the testing of >> the maple tree to test these new settings. >> >> Signed-off-by: Liam R. Howlett > > Thanks for your patch, which is now commit eb2e817f38cafbf7 > ("maple_tree: update testing code for mas_{next,prev,walk}") in > >> --- a/lib/test_maple_tree.c >> +++ b/lib/test_maple_tree.c >> @@ -2011,7 +2011,7 @@ static noinline void __init next_prev_test(struct maple_tree *mt) >> >> val = mas_next(&mas, ULONG_MAX); >> MT_BUG_ON(mt, val != NULL); >> - MT_BUG_ON(mt, mas.index != ULONG_MAX); >> + MT_BUG_ON(mt, mas.index != 0x7d6); > > On m68k (ARAnyM): > > TEST STARTING > > BUG at next_prev_test:2014 (1) > Pass: 3749128 Run:3749129 > > And after that it seems to hang[*]. > > After adding a debug print (thus shifting all line numbers by +1): > > next_prev_test:mas.index = 0x138e > BUG at next_prev_test:2015 (1) > > 0x138e = 5006, while the expected value is 0x7d6 = 2006. I took a look. The return value 5006 is correct while the expected value is wrong. This is a problem with the test, it is not compatible with 32-bit systems. > > I guess converting this test to the KUnit framework would make it a > bit easier to investigate failures... > > [*] Left the debug one running, and I got a few more: > > BUG at check_empty_area_window:2656 (1) > Pass: 3754275 Run:3754277 > BUG at check_empty_area_window:2657 (1) > Pass: 3754275 Run:3754278 > BUG at check_empty_area_window:2658 (1) > Pass: 3754275 Run:3754279 > BUG at check_empty_area_window:2662 (1) > Pass: 3754275 Run:3754280 > BUG at check_empty_area_window:2663 (1) > Pass: 3754275 Run:3754281 > maple_tree: 3804518 of 3804524 tests passed > > So the full test took more than 20 minutes... > >> MT_BUG_ON(mt, mas.last != ULONG_MAX); >> >> val = mas_prev(&mas, 0); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds