From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0A1C30658 for ; Tue, 2 Jul 2024 09:32:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3DD56B00C2; Tue, 2 Jul 2024 05:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EE6B6B00C5; Tue, 2 Jul 2024 05:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 867C06B00C7; Tue, 2 Jul 2024 05:32:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 682CE6B00C2 for ; Tue, 2 Jul 2024 05:32:37 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1B7ADC1BF9 for ; Tue, 2 Jul 2024 09:32:37 +0000 (UTC) X-FDA: 82294297554.03.C849D61 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id C09AB18000F for ; Tue, 2 Jul 2024 09:32:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0EsA7dUI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xRW+cxMU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0EsA7dUI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xRW+cxMU; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719912744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VgJdqxHI3LeL2gBXrYHszwbmdkgQKlj9QZ18FsFpoDc=; b=f37oaoG29rSCuCwGGjL+c3k/3cVcc9FGSmQJ53hhoi8+5gXZzVGxt31p/SLdgxEuzx0gPH bjzVD8Z0dZBkHfeqv1V+HqwaUYNP4dDiVFVh/knxUYOkaTV/PgZvjkMKHOEdTXDWdxk9gQ hEi58wjY2MTXJFOSCIi7N9m+qsqbKTs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0EsA7dUI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xRW+cxMU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0EsA7dUI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xRW+cxMU; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719912744; a=rsa-sha256; cv=none; b=wV99AswDq3WswyiRs/xu8VsYhq428Y3oSiArzCDzv4DMi2SjLPv0NMIN/aUvLXkov12J6X vV5FucForwDZJfUgMY2QW1xGVWTE9b/XwP5y6Q2Dx7C8h5sOG3UNNdkvrca0x7AEUHrbKq NUUDuP0ugbjnCnbYbHoEN4gkDaR9lfc= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3CE1B21B2D; Tue, 2 Jul 2024 09:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719912753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VgJdqxHI3LeL2gBXrYHszwbmdkgQKlj9QZ18FsFpoDc=; b=0EsA7dUIj9VueXO1zvC7R9tZSThwEmOiK23wpUCYDxuv2XqlwGliGzwtCT0TOjChC1zOyY yuHTbtqRSTqW+Xumbza3SeYCoXUyl4I6xYNRbtP5OHF1AoWSDYcr76OEOpWvwY3ENsOGFM O8DzwrMgrBgIbz6xrvK3UHdXAaaOngI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719912753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VgJdqxHI3LeL2gBXrYHszwbmdkgQKlj9QZ18FsFpoDc=; b=xRW+cxMUz8FwEWkbUd2NAEcGORXW6CHYmWBA+8bxu95kWvglSg0iUUr7S4gr0XfQXzF3GO M0ucAjPYrp70EfBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719912753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VgJdqxHI3LeL2gBXrYHszwbmdkgQKlj9QZ18FsFpoDc=; b=0EsA7dUIj9VueXO1zvC7R9tZSThwEmOiK23wpUCYDxuv2XqlwGliGzwtCT0TOjChC1zOyY yuHTbtqRSTqW+Xumbza3SeYCoXUyl4I6xYNRbtP5OHF1AoWSDYcr76OEOpWvwY3ENsOGFM O8DzwrMgrBgIbz6xrvK3UHdXAaaOngI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719912753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VgJdqxHI3LeL2gBXrYHszwbmdkgQKlj9QZ18FsFpoDc=; b=xRW+cxMUz8FwEWkbUd2NAEcGORXW6CHYmWBA+8bxu95kWvglSg0iUUr7S4gr0XfQXzF3GO M0ucAjPYrp70EfBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2878D1395F; Tue, 2 Jul 2024 09:32:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id y4iQCTHJg2ZwLwAAD6G6ig (envelope-from ); Tue, 02 Jul 2024 09:32:33 +0000 Message-ID: Date: Tue, 2 Jul 2024 11:32:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: handle profiling for fake memory allocations during compaction Content-Language: en-US To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240614230504.3849136-1-surenb@google.com> <2a0ee369-12f9-401a-9179-82bd659ae201@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: C09AB18000F X-Stat-Signature: 7rr8g76aabnunro69ysj68yh8ouofmju X-HE-Tag: 1719912754-719147 X-HE-Meta: U2FsdGVkX18CoeFMtclA3fKod48SqL/aY0fzPS6F8mJQRaOotD4FNMSQY3KJaKuUjuYiB1LBp1VsljaapQZ3RfyzRKMgpAx+6cajK2D07l1bG3O804zmiQ0zBVKXyRWH88s6EabkpMW7TJOZMDwJNb8b9bPfz40QGHAPz7MSYIG1TlqdyhVrgS8C12soD8xS/XM+8UTNPckRbMIf9m7gjVu9mqPbRu3t811/mnS/21I8a+q0+SgSZqeuFGtoJ9KMTcf3Q8WvGjnO1jYwqaQedf/H/4LhW4Lf9L/iTDD0NtfIYsHbKN7pDGMcd6WV+YHnQ/Sqa+uZ3kHsuIb0p5jPTpa906K9zC6HNAcqKXrDq+2z/RbOQ2VR6L/6qMW4QPtBgypZuxpjK3P8XAwY7ZQsL85N2FZBc93+RYtgemX6RIKKMi8pq5EV4W9Ef8t0LCXqpEc4LU2onc4C7DQwBjpbqpmYxyDon6PTh0caAP0i1mMIdFhXs05Zhy4vrYYVIfBB1rtoIzL6zviiQBWlQVcKqPbsV53b5rBNTriw92Cqr9Xsiiw/1T5d6dVEdp5qOs8izuscdzn4otF90GYE9NhJmwP5KSTRRSc76oiQ/ZpeK/dugO+qgC4lRYy/GxRwgvFCj1SVc/h3FBbyAFNrIimAqwu0OmBMiWwn3exko8HGDECssFcVgJ+dJrYrtCrxMZa/fO85gC8c/UQRDmuAltwp0AN8zZRwuvCbNvOT9zHSVblC1IUOz6M/2e7ilh0W9WjgLrjn/XUn1I5dNUTQWqHuoM03N0TO6L3ww2UDUdyf6B0dG7HzxHhJxZ2TAwT3Ggs9QdE2t/7mAqECW9ATnS4dCCyHpJOYz9uCHp82Q4j6x6uNeYk9BZkpufBpL02tRUfRHY00TEVBa+vd+Ns9XNJayhHI9wzXu64IVYlYfF0F34cMSvLWSKKvmrUbf3sH9PfxXcG0/zPRCJy+1KL+5xl 3PDkpghD eIXQYq5Ah5XLVfJ6al51Z3ZDv5SXFI+JohqqlcWtKZKwRNYXtDdqcQtZodpb+vsHaKfI75qoh+pQLb8/iu1mOKV8s94gK+AxALTLPq+NL6G1ayEQCIWfMPnkAPJZAreKvu+8NR/RM4KG0VFJBoUF+ipHws3BnbN16WIIrWQeHO9pxxjsRE6QETYv9HjfIMpDQ7UnEG577nTck60rNtk6DiBIkNLteC4ZANpGot2Gu0XyCTZBtU52dHnDVyPA8D+RE/5tcjye/k26ra2aGWlZ/3PM+ty5omLnbh5UT X-Bogosity: Ham, tests=bogofilter, spamicity=0.021154, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/30/24 9:17 PM, Suren Baghdasaryan wrote: > On Mon, Jun 17, 2024 at 1:33 AM Vlastimil Babka wrote: >> >> On 6/15/24 1:05 AM, Suren Baghdasaryan wrote: >> > During compaction isolated free pages are marked allocated so that they >> > can be split and/or freed. For that, post_alloc_hook() is used inside >> > split_map_pages() and release_free_list(). split_map_pages() marks free >> > pages allocated, splits the pages and then lets alloc_contig_range_noprof() >> > free those pages. release_free_list() marks free pages and immediately >> >> Well in case of split_map_pages() only some of them end up freed, but most >> should be used as migration targets. But we move the tags from the source >> page during migration and unaccount the ones from the target (i.e. from the >> instrumented post_alloc_hook() after this patch), right? So it should be ok, >> just the description here is incomplete. > > Sorry for the delay with replying, Vlastimil. > Yes, you are correct. Some of these pages are not immediately freed > but migrated and during migration the destination gets charged for > them. As a result these new counters should still read 0 most of the > time except for some intermediate states. > I can amend the description if this is considered important. The fix was merged to mainline already.