From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4381FEE645C for ; Fri, 15 Sep 2023 13:36:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1E1D6B036D; Fri, 15 Sep 2023 09:36:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACE126B036E; Fri, 15 Sep 2023 09:36:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9962B6B036F; Fri, 15 Sep 2023 09:36:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8CC346B036D for ; Fri, 15 Sep 2023 09:36:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5A4138070A for ; Fri, 15 Sep 2023 13:36:18 +0000 (UTC) X-FDA: 81238930836.17.E287018 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf20.hostedemail.com (Postfix) with ESMTP id 47E1F1C0034 for ; Fri, 15 Sep 2023 13:36:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Gsf1eUJ8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zf2vbx7B; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694784976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9rlrz3u2Vsb7vGlQTOlcmAup+cWeQZdVEYu0oGCHX8Q=; b=zHlcwYfKf+7YxDB0Dg3/AiowRb1MFkiTR1Hgcb5DQOisGd6aCtUPim1myjuohD5HDX50aY SAqPdIEw/tWexbyZ6MQXxhDfkYLixOKg3c2y5TkriCF/egO2uYCrZ5dzMZX0PzVKgQwh8+ 5bJzuAoIQICG09fJK7cOAvXFHvMyjik= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Gsf1eUJ8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zf2vbx7B; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694784976; a=rsa-sha256; cv=none; b=pFZjQszOi+AEMR+Pnt00jp+K9HWXZ0GHzaXW/TeFW6dqdZ912St9W40lUzS/OJfBcwn6p9 lF30+hn+gZpH7dFvOzwxu/x3LftwS3JViffEgxK5ZoYIP9VYp1q/DdnANwkE9AjvZtN01f uOGE1pe0XRMYCh9F5hIXyKySvCRa/XE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3A4BE218EC; Fri, 15 Sep 2023 13:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1694784974; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9rlrz3u2Vsb7vGlQTOlcmAup+cWeQZdVEYu0oGCHX8Q=; b=Gsf1eUJ8XcQyXAK6NTaBzs+N2+cdSyYIzeO1b/6RlP7vdDItVhbz80p8Qj3Qn8t4LxdmrR 5QEwjUPmp+6VQDd1NSictR5mbiGJEIqRpC3GmW7A37Q1qaei5tpPCFdsg0cWBZYiULZLVQ 3SWSGOBae2UIwjvy8R2KcUi+cAr2xgI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1694784974; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9rlrz3u2Vsb7vGlQTOlcmAup+cWeQZdVEYu0oGCHX8Q=; b=zf2vbx7BqDgGUZ4WxbsB6fugz/uSdeVGa7gqa3pSZsnTM9EHCeGeqr1PthyoSONkMRrj/1 pT32eXfikGMIKbDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F024E1358A; Fri, 15 Sep 2023 13:36:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VyDGOc1dBGUbYwAAMHmgww (envelope-from ); Fri, 15 Sep 2023 13:36:13 +0000 Message-ID: Date: Fri, 15 Sep 2023 15:36:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 4/4] mm/slub: refactor calculate_order() and calc_slab_order() To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-mm@kvack.org, David Rientjes , Christoph Lameter , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jay Patel , Roman Gushchin , Pekka Enberg , Joonsoo Kim , patches@lists.linux.dev, linux-kernel@vger.kernel.org References: <202309111340.f59c3f22-oliver.sang@intel.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <202309111340.f59c3f22-oliver.sang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: m5zo7cfze8u8bhicues3jhfnocqz9dfy X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 47E1F1C0034 X-HE-Tag: 1694784976-523526 X-HE-Meta: U2FsdGVkX1+T1AMr8cc1/syXFUS1Zcs6Gw/ryw0jIT71NWg5Vvx8bnCND4J3LfVcie56AoZQQCFA9V+1a+XCahY6xL4MWPzjEZAKWROQw/wjtPSUlkPqVBhYccaVZdaThqvA8gtNxQxIFja8QgeGae5ABbz7eK8vm6I5a9DjEnIc51HfTOtTXOyFU3CMaFZK4Y6PHXTl+AuXAIQyU326q1UGKe7bIF0kU1Dhhsh6QG+8Px+3wYm8fQWnbbiXMICo6rnZCq03wmJpFnC0YhhRuHPehXQgKvvwzRMGptItO0xdGTsz8Sc5pHLpL88bckhBFddTURPjSOPMk6aZNqfFKwMGapsd8DQuERmwcuS1kMx4JbnJ3VekyreN+VqjGQOXmAbGwf+a4f8wXmCP0c8Ry0YUD9rAm1WVpN2W4Coq8rnkx/B895EQ7P1UjM6CqePLtB8Qibcl1rVjeg492kvSdfGw/nYLKOmKYv5BLSG57Q4uxxpQlOBU3lk9M1psyleXCdd7WGdeDl/UkzyDFuyuQHq7G6nbsEkr1r2wfM+W7gjzFjci1OdhvnRiGZCd/5VMpa0SbK7yNTInjj00y5sCXjEnD5+J5ekrpoSYZsrVGT4HXA+tesmL1OVrBzbRvQeWEFKzTQl+K8rL7qIO27ekYT9FY9TvfGUDlhna/uNeynSZt8L7yC7a5LtDZx08DEZpKMb3OjlBKSu3vs/fDQYqVI4AxHdC4Yvbed0pjB6/EZaJEXbFuNnJgU/Q8NaMDbDu5M9NC/GfjH4IuQGYIdYqhVFLJXaHslFCaBehlMZmfrseaWdGvOTAFCX4hXiot0IJwMH+nXiGGeApbb0QkSkkuyjxwCWs0wJvt5hVb5iNxOXAkuB3ZBnTAp/c5BJ3/c3mLDFJgg2Z3G9KEZhU/NTwuNVQIaHemMIcN3HPDFDJaIFnUKe9IcZUQL0oTApPJFzNpIQ0ufwJ3K6QhCBRlqg nEGqdIOn JK1FWhJjE6PNHowDJ3vNk9prgzzirloJkwMtXQkTvQJ1a//UC7sqHYF80W27a7G5NT8WsMc9H7PHdGvovUlQ2kuBK0uY+9OPSkWFY8AfnjUZMUVU5gTnQTtGMTnM3fJh1Shk28wxTh0xeHdTGBzOwfK0/Vhs163ORRkQgjHrsruz+yANeCRPAb+8jvlmdv6bk7CniPtmKTDwj6Fmc0PKe2GoZYC4KXkFA0AoTO94DnY3hv0oG6MloFyYHxR/uCr8MSuUM4F3RiOLv2YKl+0A3FVMXeQjjvM6VOslaptPl2JasTaa7qz9zHjgDtWu/tucUxYkShDDb5e76P0SXVX+5x1XQ9hDyUM2+mOypIdsFso/Wi8jFDBTezo/c/0/juCCx4PC081E60fsjqceGIeXiK5FCTOMgsPVp1vLfCyDsiWtliR4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/11/23 07:56, kernel test robot wrote: > > > Hello, > > kernel test robot noticed "UBSAN:shift-out-of-bounds_in_mm/slub.c" on: > > commit: f04d441027621c16081803832a54f59272112cf5 ("[PATCH 4/4] mm/slub: refactor calculate_order() and calc_slab_order()") > url: https://github.com/intel-lab-lkp/linux/commits/Vlastimil-Babka/mm-slub-simplify-the-last-resort-slab-order-calculation/20230908-225506 > base: git://git.kernel.org/cgit/linux/kernel/git/vbabka/slab.git for-next > patch link: https://lore.kernel.org/all/20230908145302.30320-10-vbabka@suse.cz/ > patch subject: [PATCH 4/4] mm/slub: refactor calculate_order() and calc_slab_order() > > in testcase: boot > > compiler: clang-16 > test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > +-------------------------------------------------+------------+------------+ > | | a17847b835 | f04d441027 | > +-------------------------------------------------+------------+------------+ > | UBSAN:shift-out-of-bounds_in_mm/slub.c | 0 | 12 | > +-------------------------------------------------+------------+------------+ > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202309111340.f59c3f22-oliver.sang@intel.com > > > [ 0.901457][ T0] UBSAN: shift-out-of-bounds in mm/slub.c:463:34 > [ 0.902458][ T0] shift exponent 52 is too large for 32-bit type 'unsigned int' > [ 0.903477][ T0] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G T 6.5.0-rc1-00009-gf04d44102762 #1 > [ 0.904450][ T0] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 > [ 0.904450][ T0] Call Trace: > [ 0.904450][ T0] > [ 0.904450][ T0] dump_stack_lvl (lib/dump_stack.c:107) > [ 0.904450][ T0] dump_stack (lib/dump_stack.c:114) > [ 0.904450][ T0] ubsan_epilogue (lib/ubsan.c:218) > [ 0.904450][ T0] __ubsan_handle_shift_out_of_bounds (lib/ubsan.c:?) > [ 0.904450][ T0] ? tdx_handle_virt_exception (arch/x86/include/asm/shared/tdx.h:60 arch/x86/coco/tdx/tdx.c:375 arch/x86/coco/tdx/tdx.c:430 arch/x86/coco/tdx/tdx.c:650 arch/x86/coco/tdx/tdx.c:666) > [ 0.904450][ T0] ? kmemleak_alloc (mm/kmemleak.c:977) > [ 0.904450][ T0] __kmem_cache_create (mm/slub.c:? mm/slub.c:4159 mm/slub.c:4473 mm/slub.c:4507 mm/slub.c:5104) Oh thanks, fixing up: --- a/mm/slub.c +++ b/mm/slub.c @@ -4152,7 +4152,8 @@ static inline int calculate_order(unsigned int size) nr_cpus = nr_cpu_ids; min_objects = 4 * (fls(nr_cpus) + 1); } - max_objects = order_objects(slub_max_order, size); + /* min_objects can't be 0 because get_order(0) is undefined */ + max_objects = max(order_objects(slub_max_order, size), 1); min_objects = min(min_objects, max_objects); min_order = max(slub_min_order, (unsigned int)get_order(min_objects * size)); l