From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A265DC4332F for ; Tue, 12 Dec 2023 12:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F410D6B02C4; Tue, 12 Dec 2023 07:32:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EEFE36B02C5; Tue, 12 Dec 2023 07:32:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D69D26B02C6; Tue, 12 Dec 2023 07:32:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C55176B02C4 for ; Tue, 12 Dec 2023 07:32:57 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 80D1E1C127B for ; Tue, 12 Dec 2023 12:32:57 +0000 (UTC) X-FDA: 81558105594.28.37D2494 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 34D9E140026 for ; Tue, 12 Dec 2023 12:32:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SJe5RGZ9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702384375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xeDChy9xBCe/DtH9LHf9q1RxjNssQ6xDSe8NzYUud2A=; b=VpVgyGDNzJEhW+q+HrS/9pJTzWwjKhyN6PiThrnCbxorEaRZbANG4rf9/zuhFAx8z+bfwx 7RjZaPtmHy5/p+zWBPWrhYDJWEe1NNpfcjtJfDuu5jmOJ0eutG2YlDy3KsumHUFY1kypJI zuSiXm6IypBmLV98+vAxz4ozbOR3+9A= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SJe5RGZ9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702384375; a=rsa-sha256; cv=none; b=5Hd6rTNycpVp+7hek+gFu5ymzv3yqZ8lCo44NOjeHBJTLcBXE8EUPj19XQxQGLrPOFkr8q Uuh+dC44aWRDpsuFO1vxqSJYqq/rEqLh5TF6bG6rtIWdJnKFAr+e+9SrPLeiI3HTK6xbMQ sVviduouUzU6mfcvr/rmBLc4qNITMDo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702384374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xeDChy9xBCe/DtH9LHf9q1RxjNssQ6xDSe8NzYUud2A=; b=SJe5RGZ9ahCbQxQoyFeqXPsL9UYo2KGC7bcXwPNwVuEK7O4XzC+3u5X5g8m9bO+bX1SNl2 pOmXVm414kgogXoKyvDC3wI54hb2xqVL2O5a/Wcl6Mvzyr/JkQn5TFjPBGB0jwboL86ZU/ MIYrV3XsIAhM9jiIdY09DT+XXSu1IcY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-mShUwRLmP1qSS20ds7b63g-1; Tue, 12 Dec 2023 07:32:53 -0500 X-MC-Unique: mShUwRLmP1qSS20ds7b63g-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33608b14b3cso3860220f8f.0 for ; Tue, 12 Dec 2023 04:32:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702384372; x=1702989172; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xeDChy9xBCe/DtH9LHf9q1RxjNssQ6xDSe8NzYUud2A=; b=JeTvrXOIPUKgQrQlbqCovG9b/QAzP6IJa4l2isDcEpCOSb3hORxGDSUvJve7Ut4B+f YhNqBmjytrCpCcOmZRi+CybAo6C5QcYz7LjEYU9Yax/F0lHibFiaEstSy0pwYOZ5a569 7PTXrAlIU8ECnPZU8kZN82Z+sKNJoT7UHOsCkLHeKwoKmRC70KcVzSmnfhCoqGxLD1Gp R8YGNasODwhed+CNmUy9hamKSyc7TeHgrCrk29KJm1cNiksaIxKkdRaa8ijz1VODINfR RT7Uq9eDo/GkGQBnZ6LbiNMmiW7kQJA5XW93WjVWEi6GcNpItt+wEy0mk5GikDogMfxv qr0w== X-Gm-Message-State: AOJu0YyEsLIvIieQw4o+gpCKWOY08jDJoKn+EKv95Z7G1Kaw9j9NrHCY e0HcQedWgt8zvFgMgJzXHsnpoC5mu0MNxd4x19s6y6Q+H2hZjOxChQ7Aba3UEN6m1xNS9FmfkE1 WzqaiLPq9U7WoO3s2MVQ= X-Received: by 2002:adf:e34d:0:b0:333:4255:7aec with SMTP id n13-20020adfe34d000000b0033342557aecmr3077215wrj.43.1702384371915; Tue, 12 Dec 2023 04:32:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+ceWKbTgFhxsoXMBnuWHZSaEtDNSlQLRiLkL4Ev5/RZB5sKk8xmvSYLv30/mld+vTWxS0MA== X-Received: by 2002:adf:e34d:0:b0:333:4255:7aec with SMTP id n13-20020adfe34d000000b0033342557aecmr3077208wrj.43.1702384371470; Tue, 12 Dec 2023 04:32:51 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id j1-20020a5d5641000000b00333dbecdce3sm10726587wrw.62.2023.12.12.04.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 04:32:51 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 13:32:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] mm: Convert ksm_might_need_to_copy() to work on folios To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20231211162214.2146080-1-willy@infradead.org> <20231211162214.2146080-2-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231211162214.2146080-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: yb33aqacf7u3xkx15uz9azs1ytojax5b X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 34D9E140026 X-HE-Tag: 1702384374-940716 X-HE-Meta: U2FsdGVkX1+R4ibXoK1GbNDLvce53nZoTnLi8RF+jgadnZP8pi/FuguDhFqAw0Btitfd4+bZ1UsjrrcH2FNblUHICdd3o4EdtNwzq4JyZc96X2cqSrofxEt3G3UorfcLDBgW+d/R7DVgW3rt9nfO0f2A/P5uKVU7HHLdYelDrn05Hz1wCN265U1yU0pIPxirXqCHnnahtQm8HD/CuxMkLhL2ptXHc9HwUXR2dq10q0n7YwBaYVRqe3ag2cr6YHO0kOfsUciIE+G9k2opnmgdKXOJP5kOazJPBJNKyQFWFeroFuLwapAY4+dN7GXa+kYGDgIxTxcKI0jwnFyxoHl8dkZ03XXUaLM6gE07GfGVx5zQ0X38MjIa5+0yzCP+tCF0WLaxoOt3uXMnzZCVSCBU+Ohz6LCFhG0qQJBWnUieFBzWDlrDzgCFkkKimvaaK+9KcR8wAI2uiw2RgJDtBSv03fPXF8N4Fd1N3ELHGF8CUAWKUtNcZbtgcSU63bCC1o5pGT11oFennmlwdtnaOauYZRGEF2dFmoh5moa4ZN58yleC6LQRSkqiWqXXzZiXwpxqtmYbiX4dB9Ff1ztJgh/TKY/a6CBrcVAVyn/rd8JpU4+h+ifb+R8R72uHxBin4/uu1KN/20BJ99ssdpjy3bJsNauExA3OlIhH0gn0UfquPryPIe/sVtoEv2jthrAWHwwmjkd0KBPyNKHY7NRksb51y9lPdHBK1YkHbH/G0naEZQjDR/99hrMgpia47v1FA7EWQy28NCI+4J/6gnvLuXZDxcGDgDHIbOti4l5GTF19dW4yJIRk6y7ZuzRRHKH98JivRiWp6Sw0DY1/4SvZW4sa7cpj/A99Dj4usmN0naWu1gKczyMfdiaI0X3FN2AH+FJW2C2zGeF4CbroBJINK9nYggoj0BB/pHZ6LVbCXmjUDuO5FMxNTr/hU7Ke0IhziAXm4/mxqIlpIJYpZRXhQ2t kAWuXknd kF7CPc5ODDoGf+4/6lk52SOYUZcL8SstMs1SsrnLSFkxfcnWwolzF0cOFiYOIywGo0RzcDE7nOJJEoVEsGOCqjubvsUABZ0Oapq/HaoDRmF6lqfw8dK9BtNeYXLlAo9hL8qtu8MIi7JWbDhJDCN5QnXT2LYJ9Mw/KaDXdXjewSCPiPfy9RjYPQDpWN9S/qi5RQHUpHRXRK2C4UmV+sgf49gWgxl0h3RReiEu2CsPZeC8ZfznsCqApxKTgTA/foZuu193fzDrK4dAebym0Z9V1IdR2GB9fUN06lFGaii2T+8ma+CYdjXBXXnc7x7tAy0kGJPNQHcN699IeOYaYcnlgJr/BdjCQehioD4YhlVMMQnA8W0wk87ffcjFu0NEYZQ+mWXHOyd3cRC8NPoy/+Ug4W8ZhC7YMsHcga7Nsl4iYhfnS2hyURa+e/7PQcXgbajh5uHTtlNTCxpMrWNG73rtUuXm/SA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +++ b/mm/swapfile.c > @@ -1749,11 +1749,13 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, > int ret = 1; > > swapcache = page; > - page = ksm_might_need_to_copy(page, vma, addr); > - if (unlikely(!page)) > + folio = ksm_might_need_to_copy(folio, vma, addr); > + if (unlikely(!folio)) > return -ENOMEM; > - else if (unlikely(PTR_ERR(page) == -EHWPOISON)) > + else if (unlikely(folio == ERR_PTR(-EHWPOISON))) > hwpoisoned = true; > + else > + page = folio_file_page(folio, swp_offset(entry)); Just to double-check: assuming ksm_might_need_to_copy() in fact allocated a fresh (order-0) folio, folio_file_page() will simply translate to "folio_page(folio, 0)" and should be fine. -- Cheers, David / dhildenb