From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5931EC28B28 for ; Wed, 12 Mar 2025 12:06:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D92F3280003; Wed, 12 Mar 2025 08:06:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2735280001; Wed, 12 Mar 2025 08:06:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9748280003; Wed, 12 Mar 2025 08:06:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6E0E0280001 for ; Wed, 12 Mar 2025 08:06:03 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 75F1B8102E for ; Wed, 12 Mar 2025 12:06:04 +0000 (UTC) X-FDA: 83212770648.02.EEF695B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf05.hostedemail.com (Postfix) with ESMTP id 933B510000E for ; Wed, 12 Mar 2025 12:06:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741781162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yY9yUaPPoPxebJ0yuTVmLrSLhe88mIGDenMpZM7HhSA=; b=NBL67hPHiouvd54oekTgMsNyd6jvd5/GDafcUnXFGJcUPhLRHr1qfL3kC5Lu2UgfXSPPFp WEswU67uGMhMBRnd2IYjYEfrEcpHFvkzH0ZMI8qzaYy2xUiHUkE82PD9B5WIi8PqpJLtg2 W+1Y2ZakOpCCNz1Z8+fIGQBfomwN3Nk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741781162; a=rsa-sha256; cv=none; b=JagD7bXnpkWjg39HjYLa4GF1ClbmdrLDd+RkvJGcjgOyoaOQrPUqHCm/GCRqf7VNE73P8D P/buVcVDlFfdXhXIlLZtbOXY2K+AESQNV5ATvD4p2FfMATDZbRJaKGKYkFHfl1dLxPJ95X ciGqdIvNrx4/UE8j8g53FtazeilI+c0= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4ZCTl019PpzvWs0; Wed, 12 Mar 2025 20:02:04 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id BAA7A1401F1; Wed, 12 Mar 2025 20:05:54 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 12 Mar 2025 20:05:51 +0800 Message-ID: Date: Wed, 12 Mar 2025 20:05:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements To: Gao Xiang , NeilBrown CC: Yunsheng Lin , Dave Chinner , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Olga Kornievskaia , Dai Ngo , Tom Talpey , Luiz Capitulino , Mel Gorman , , , , , , , , , References: <> <316d62c1-0e56-4b11-aacf-86235fba808d@linux.alibaba.com> <174173371062.33508.12685894810362310394@noble.neil.brown.name> <14ef70cc-beba-4abb-b206-e9fb29381023@linux.alibaba.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: <14ef70cc-beba-4abb-b206-e9fb29381023@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspam-User: X-Rspamd-Queue-Id: 933B510000E X-Rspamd-Server: rspam03 X-Stat-Signature: imphhy8ccfjnhuemi8yj91a7ppqkybk8 X-HE-Tag: 1741781161-817943 X-HE-Meta: U2FsdGVkX1/ldIDDj30IT2CJh3YBmxfyYgl+avqFpM8PIZZed4aPbSd6tQYWUKHvEI4mzZn/1CBRRkXQ3axGaS/V3hj2FJ5iC7n6nBjeQOIp/b6F+BaKlzKPyM995I1tE4hYTnbdf19hQwwrfR+ymCJ7TbK6efOMMYgiR908a07qRiIGzhdrgFkONKuMgiQptEo0ctjI/8PoH8WsOtnfJVX9GZhmtudI3kQwepDNp7P69SlRlT98B5XwuEqAMKZmQXEz/EAt3V6kZV4FOMBCTGLaWKLdU9QM+yARN+xYpz7jWwjHmVQ2KHciWtXxxZc929zfYmWLgbsY0CT34cpk4Y5+9LompMyxDvvbLcdOuP5RkbpPNU9o3nbOd9S6ytcR+9UDmF4VT6HF80gSR7Kpzd3d9grbJrDg/QiZNzKYL2JvQNH5CcCCEYDGJQDsnQl1qT0IfqbojZsxNYbmIZxvGIkhxhy5Ts9/w+effNhW/7KOlG2rJMydd9YPEggWcPbF6l6WlGM4UJtTGa3HygxF16sVdTPa6a6chr/VAxVgZwglsjB76gOqE1W4m6wj9liuH5cSz/fce9BdcZ6lXfHVJn9Ph4OCHGfanZ5RAjKJTQi9+Ys/YQUq3HmSo0M5bvjyz/OK47xKna77JyBNWHGC0ZgIE//3PSnG8fQhGVhetP62ecg7aZzZnyf76X0YSrwtsNbnYXbswbZmyRN2L4T7v62N6qwptaZ4vyF3t5akR1HSKs8Hpo/d8c+UyRA4v0ZUtLxRIGm0prcDSMyFeazUt4vU/s01hrEuJHSxXOtylLUifAjvg4KMzDolhSlXTNiKwNQDbcaCmYBMyDuvf/MmbMmeCKlCDJwBJcB6yuVXC+v+QgokDW5XMPkJROMkeCs516+HQn+zRb5KLVez6sRXeABfYbhAVrXIQzYA6Llg5gQv8M0DiZ+hnzS3Sdk5OVPtonn5u0Dv3Cg5jm12fS7 H5X3GBER xxZy+tWll6Bxm5jCe2mw3KrxV3IYScwMoJmTdq0QnhCix9RwdS53mgwpYPmqYbTEgY1z+4qCnWPgJWS3/L/HWcZRiQN5lamTIGGAsVhsHUMC+QPI4hYilDHJ+CjCjLRyrjJw8dtBjI/Qlf1NVqkTL82wQ+5710bxfhXFsB38cSmSmI5cFhlV5baPmUk6uHcTpD1TkTJAIOzdCnCzVTXASHkN05kAiT+e5+0GP89K1m+sU2qzp+/jEKeXZoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/12 9:45, Gao Xiang wrote: > > > On 2025/3/12 06:55, NeilBrown wrote: >> On Mon, 10 Mar 2025, Gao Xiang wrote: >>> >>>    - Your new api covers narrow cases compared to the existing >>>      api, although all in-tree callers may be converted >>>      properly, but it increases mental burden of all users. >>>      And maybe complicate future potential users again which >>>      really have to "check NULL elements in the middle of page >>>      bulk allocating" again. >> >> I think that the current API adds a mental burden for most users.  For >> most users, their code would be much cleaner if the interface accepted >> an uninitialised array with length, and were told how many pages had >> been stored in that array.> A (very) few users benefit from the complexity.  So having two >> interfaces, one simple and one full-featured, makes sense. Thanks for the above clear summarization. > > Ok, I think for this part, diferrent people has different > perference on API since there is no absolutely right and > wrong in the API design area. > > But I have no interest to follow this for now. Just to be clearer, as erofs seems to be able to be changed to use a simple interface, do you prefer to keep using the full-featured interface or change to use the simple interface? > > Thanks, > Gao Xiang