From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F98C77B75 for ; Tue, 23 May 2023 09:58:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37E7C900003; Tue, 23 May 2023 05:58:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32D97900002; Tue, 23 May 2023 05:58:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21DC4900003; Tue, 23 May 2023 05:58:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 13B69900002 for ; Tue, 23 May 2023 05:58:35 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D9C12A029A for ; Tue, 23 May 2023 09:58:34 +0000 (UTC) X-FDA: 80821070148.10.27C45AB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id A7BDBA0015 for ; Tue, 23 May 2023 09:58:32 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L+GEH1rn; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684835912; a=rsa-sha256; cv=none; b=4VapjJWbiNRfOy+sNIEGdvZB8ydKzJ7GMKl3Wx85cz1bZVug1KvcLxHgqoY2RzvFSjPpWp knMFrRBuj9uJd6PWdQC5xqzqFzvwLWPEGyBEVuYgDhAPbJ/Vv+OyejNiZalFvfhTgQy2zA hq2M5jlE+M/euDxwkvAizmcxhJ3BmCY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L+GEH1rn; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684835912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LycqLutbVGXtzw5AEhsRYxd5JCdHFjpO4IqicwMpPiE=; b=tAnilD0+pKTpUpFMM6r0oOOMDCx6vOYlohQQe03K5FbZuAPYNB2kdQ9YbvrTRjP/SYu9rL EucZHEuk5dsoVvvlXIgO9B1yLt7Iz4rFa5DVUR7zvM930Cr2ZNOO58Bj6vofUT1/g0xcuz HNP7UsLOyf6QQc5qY+5rIDLPr8jrXQk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684835911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LycqLutbVGXtzw5AEhsRYxd5JCdHFjpO4IqicwMpPiE=; b=L+GEH1rn7el4RTHpf12vlhdG59KKS4FNmSbrkQDw7CUMHquBNlIgqecD7PkQUebKMa659o U2BEBjilOBm5K+29lea8SufrHMm9bX9WZG0hnOdxODaNBsdReKpFI5NMa9kuEbZbbVsSzj gRndqIO7daQKsBUG8oWUXvdF8GtRpec= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-hiu44JtfM2WxSAFf8iE7EA-1; Tue, 23 May 2023 05:58:28 -0400 X-MC-Unique: hiu44JtfM2WxSAFf8iE7EA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f4dd7f13d0so27938895e9.3 for ; Tue, 23 May 2023 02:58:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684835907; x=1687427907; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LycqLutbVGXtzw5AEhsRYxd5JCdHFjpO4IqicwMpPiE=; b=CcRCQtSUWzIQb4KDB9e7XZwGaHy7DzWU+BzuXdlVUJUM5WdEbyymYjI922D+mkobLW a9wAEkIgU+Ox2FmZycNdVl1CMMVBwtK3edr639MzUG4GkjymOIdsirhvvp5cJOElPsqH +UotWlpHeL1O1SBU3NlMXsESkuyqNnBitTjoKjPn9hci9VSftwGP/c2oWailbbHbjK1o NMmP8op7u3bnt1z0vSql8axR3NBFJg+O5unZBF2dvqCy/EZl2eU3pXb1ZD3YvEHQFxP+ XIC4LJFlwSBBfgUEpKc5TNsZXfSUfbY4yIWjhp8Pglvsh6FAl/hnlTWa8ysA0qF11Wz+ 7AxQ== X-Gm-Message-State: AC+VfDzCrQZCba9lSd1g/cyAHMnQE1VNibSyMUeF8joM56RJ1zHv/2bl bifhl1ofO2QKJooAqIBbvVijM6cOC0XG9O3hd9q0RuvQvfAj8vX+wlD4jQdvdYYKa1yREYFnXov aNsHov6zGY92a9G+UrFk= X-Received: by 2002:a7b:cd0c:0:b0:3f6:7e6:44ea with SMTP id f12-20020a7bcd0c000000b003f607e644eamr2709753wmj.18.1684835907591; Tue, 23 May 2023 02:58:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6hjKhVvi0v/UN/aZgYax0Co+JEyAE7nJ1dTzFPofNOgN9OvKla7Znm3Ia5nTZjnlstS94TIQ== X-Received: by 2002:a7b:cd0c:0:b0:3f6:7e6:44ea with SMTP id f12-20020a7bcd0c000000b003f607e644eamr2709740wmj.18.1684835907260; Tue, 23 May 2023 02:58:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd? (p200300cbc74cb4005c8ba0b2f57ee1cd.dip0.t-ipconnect.de. [2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd]) by smtp.gmail.com with ESMTPSA id y21-20020a1c4b15000000b003f60119ee08sm8876670wma.43.2023.05.23.02.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 02:58:26 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 11:58:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v8 4/6] ksm: add documentation for ksm zero pages To: Yang Yang , akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn References: <202305221842587200002@zte.com.cn> <20230522105335.4176-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230522105335.4176-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A7BDBA0015 X-Stat-Signature: jbh6rdyr5zgfgz9hz864t3fdr3qfnir5 X-Rspam-User: X-HE-Tag: 1684835912-509988 X-HE-Meta: U2FsdGVkX188Irjw9/HE4LVqb+VnO3F0N21Rv435/SQDMpquFtRXwylbAhTzIvhKayNhvDanVEmAduu/IJ0RWM96lFqSPc4xIHPgZjt1J0325/VGOb62qnmoWneWTMmYJioERVDtQeO/pSTCwGFKBwtRX5uMd/A4kG8/bU6A/r7sksx9SyJlNssB0IwoFe+NKbNvPV5jQTnwew98E+aDNE3X6bwRxeLc5XUdS5uI3unjAp/+zy5GoR2dv3di0MTZ5jyXQWN9fXR7DyJSoVTbWvSznwhEIZ+hiYHiUcSqQH6HJ1rMimP0u5latSMFcRbO2xY1AFwfxhnW26lNVPz731l1gtRZx5zPl3TVn/g3gOmSXB9dCLSVEAbgArZnz+eDd++xImVP4fm5TVJgYP8SGsVLPAHlUHjOBfVYKDy2pxEFbKEST8SAG5fmohlbKfZIDq6y7qEXnfLg6MBcS+NwzMOrCMZ1WrXI6/6KWyvG+4mjulxRzZCACgbq61C/6V/cZQRJzwBeNWTrLvCBTNqyrNhduWwrdSHTZyGqcvv7AGhYXqU8uUiAHBBAf3lMdS94RE1pnSO/9NiDSoKStleSgZfv1JqBfK43mL5si0d8BJ9FoN2zC4W+Xg69fXySbqFGrXKwz6IYG/VMpq4PgeXjH/zjSBMJIbDEcASlb7YaTsW9x70NkSbUSsSiP55a12mrx2NFebYyOL6UTTDnuXxekffqGHndSC6KQGK1Xk/lhE/iYX1/a18X7vGhyi8gkUiz3YdqfpPHMJzahY1HVQREYe43YVpJjiPN3J4r6AGDXhHB0peTFzgEF/+E8PidqdtCvjScaKlcQqZECLCnt8GfVVvn2V5MIOlq7dFFOkSKGmA3nIS4pdKkX2Bcutxn7jQwi+8qlEpIDyE4hNCeHlfPtPYtKSWEl26VKk+Lz6yX56OA3LFUuIg/vZL0li6UfXkaA24B5Lg2lW7MBbPtmeb Nnly2hj7 R3cDavEZUIl55BwcYRBWPp5x57C/3J63h3i/i0fzzS/74Scp7ZgKJ9c3AyxNbR0m28XgsUZujoZFKPIuCyUlSSdXIzDZiM3JYqOEmwZT8OaKuHDXpJ9tpY82pzbcApU5uyslG+KPjrIQE0BznIMFw6SmhtAUyLiaqglIKOfh+yljBxuKWDZXHqMyJhYA43udfxNfYH3Kdwwtj+yMg+jPUfmgGilRrGs8Puef2Yy3EodpEqRH0JFf9TthVvVwc+p7P65Uds0lWWRSyZ4YFsoEooir/5laL3YpKMmmHDjo2fCAzGBo1odahALREmgFhlcQagIq4xBKyJ8JEUl7Kt8bfGlMFoZkj55GyIU5Nv3WOPPRZ3bHl5jaytTSdU2cwONGsUZviOwFKlviN7veg0MH1gMye0aaNBclWgm6pxEqLqmpwUMSwGYxypO36NKKlOMaciuoyZv3usmihRQAwk9ltQOlZL5dow8tx9iDg/dqb/fuXTS7P1sLnCou4Da9cHYPQ3L6VVzII9wIuQEIw1rdTcBy2w6W/ZRXe07ZcqBICxBRKTwQIfzy9vWk64w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.05.23 12:53, Yang Yang wrote: > From: xu xin > > Add the description of ksm_zero_pages. > > When use_zero_pages is enabled, pages_sharing cannot represent how > much memory saved actually by KSM, but the sum of ksm_zero_pages + > pages_sharing does. > > Signed-off-by: xu xin > Cc: Xiaokai Ran > Cc: Yang Yang > Cc: Jiang Xuexin > Cc: Claudio Imbrenda > Cc: David Hildenbrand > --- > Documentation/admin-guide/mm/ksm.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst > index 7626392fe82c..019dc40a0d3c 100644 > --- a/Documentation/admin-guide/mm/ksm.rst > +++ b/Documentation/admin-guide/mm/ksm.rst > @@ -173,6 +173,14 @@ stable_node_chains > the number of KSM pages that hit the ``max_page_sharing`` limit > stable_node_dups > number of duplicated KSM pages > +ksm_zero_pages > + how many empty pages are sharing the kernel zero page(s) instead > + of other user pages as it would happen normally. Only meaningful > + when ``use_zero_pages`` is/was enabled. "empty pages" is misleading. You can probably drop the last comment, because you repeat that afterwards. how many zero pages that are still mapped into processes were mapped by KSM when deduplicating. I suggest squashing this patch into #3. -- Thanks, David / dhildenb