From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CB1C433F5 for ; Fri, 25 Feb 2022 09:01:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 419C08D0002; Fri, 25 Feb 2022 04:01:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA248D0001; Fri, 25 Feb 2022 04:01:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26AF38D0002; Fri, 25 Feb 2022 04:01:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 1492F8D0001 for ; Fri, 25 Feb 2022 04:01:59 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C9F8823614 for ; Fri, 25 Feb 2022 09:01:58 +0000 (UTC) X-FDA: 79180709916.03.635302F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id E0607C0010 for ; Fri, 25 Feb 2022 09:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645779717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1WIKnGoWFyTndm5TrLW00J+i5t/iVoIUx93nUmuDOHc=; b=eo2G9Kz42/CA6kur0toCrFGu2eXX8qRkGpirFcekZgfkpFrS/gH8301pNQ2FzKTVqIm0X9 8PzPv/sxE+Qp37k12fdvi5ZkNytJakEfgYikQh52+aMxvqtsStv/ewn3/l3/YhtkFlMZuv bqKsyo8fI5Dyg/T+VQtqZ2WHgfGFCuQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-CCrdPzdSMqmUfEqdmkOXJQ-1; Fri, 25 Feb 2022 04:01:56 -0500 X-MC-Unique: CCrdPzdSMqmUfEqdmkOXJQ-1 Received: by mail-wm1-f70.google.com with SMTP id 187-20020a1c19c4000000b0037cc0d56524so1273641wmz.2 for ; Fri, 25 Feb 2022 01:01:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=1WIKnGoWFyTndm5TrLW00J+i5t/iVoIUx93nUmuDOHc=; b=IbluFxrK8EKm0WFw0McKZ3HL5j4p1gqD0F2sagVEXwW9ddblQOjRurjrmGcwclYLvQ wL1HgvHEhQrm5V8gL01OVRCrGJFOSGHVCcx/YgWsFawN8lm+XG/P1aS7zPm5KoJjow3H bwOwvRsiMLJFUVmDAfvIw9XQMs3ZL/TdOJssUpL1oZQLkzJ9UfCkwe50SXvNYSfNrKYL wJsGhp7AXbJRtJbbqpg3hVqQLEqpcxHtYWbDTJRogQSmq7eZqkLEQRWdqbHOSerP+yt8 4gFqU3YC9ZANjdvKLtJ1yqTCA6g5Q9POlKWOKTtmrlxZsN3RrnuYwR91vvWfnhEuKSC2 Em9A== X-Gm-Message-State: AOAM532+eo1+PcK5u8FZkVLUNuI5VR8r5d/+X9EDCsrMWA820sj/1TZZ GUBH1kKydZo6ZYi99ILBODajaHxYKAR8d7WERtI0uuSGP+Nu+y6a1Q4b5NSiqWCKQlz+5TJNBXb ft0521aWia4w= X-Received: by 2002:a05:600c:48a:b0:380:3f3a:e08e with SMTP id d10-20020a05600c048a00b003803f3ae08emr1769667wme.1.1645779714887; Fri, 25 Feb 2022 01:01:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDy1KgcWpVNdM33QEotT9nlakyx3ll+DkMH6nzYwAtc/XVtP6ENwJ5ePrhSbMpW4nc7Aoc8g== X-Received: by 2002:a05:600c:48a:b0:380:3f3a:e08e with SMTP id d10-20020a05600c048a00b003803f3ae08emr1769625wme.1.1645779714630; Fri, 25 Feb 2022 01:01:54 -0800 (PST) Received: from ?IPV6:2003:cb:c706:1900:f2f7:d2ad:80d9:218f? (p200300cbc7061900f2f7d2ad80d9218f.dip0.t-ipconnect.de. [2003:cb:c706:1900:f2f7:d2ad:80d9:218f]) by smtp.gmail.com with ESMTPSA id v25-20020a05600c215900b0038117f41728sm3695546wml.43.2022.02.25.01.01.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 01:01:54 -0800 (PST) Message-ID: Date: Fri, 25 Feb 2022 10:01:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH RFC 05/13] mm/rmap: remove do_page_add_anon_rmap() To: Linus Torvalds Cc: Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Linux-MM References: <20220224122614.94921-1-david@redhat.com> <20220224122614.94921-6-david@redhat.com> <064ba776-e6c6-a430-7d74-0b691123e2a9@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E0607C0010 X-Stat-Signature: u7uz8t6hzd9treqk8fq59yetbhqr3x9u Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eo2G9Kz4; spf=none (imf22.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1645779717-273370 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.02.22 18:48, Linus Torvalds wrote: > On Thu, Feb 24, 2022 at 9:41 AM David Hildenbrand wrote: >> >> Actually, I thought about doing it similarly to what I did in >> page_alloc.c with fpi_t: >> >> typedef int __bitwise fpi_t; >> >> #define FPI_NONE ((__force fpi_t)0) >> >> I can do something similar here. > > Yeah, that looks good. And then the relevant function declarations and > definitions also have that explicit type there instead of 'int', which > adds a bit more documentation for people grepping for use. > While at it already, I'll also add a patch to drop the "bool compound" parameter from page_add_new_anon_rmap() (description only) Author: David Hildenbrand Date: Fri Feb 25 09:38:11 2022 +0100 mm/rmap: drop "compound" parameter from page_add_new_anon_rmap() New anonymous pages are always mapped natively: only THP/khugepagd code maps a new compound anonymous page and passes "true". Otherwise, we're just dealing with simple, non-compound pages. Let's give the interface clearer semantics and document these. Signed-off-by: David Hildenbrand -- Thanks, David / dhildenb