From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCB9CDB466 for ; Wed, 11 Oct 2023 17:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E98488E000F; Wed, 11 Oct 2023 13:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E47118D0050; Wed, 11 Oct 2023 13:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0E208E000F; Wed, 11 Oct 2023 13:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BEFB98D0050 for ; Wed, 11 Oct 2023 13:26:47 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9841F1CAB40 for ; Wed, 11 Oct 2023 17:26:47 +0000 (UTC) X-FDA: 81333860454.17.E219290 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf24.hostedemail.com (Postfix) with ESMTP id 246FA18003F for ; Wed, 11 Oct 2023 17:26:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Vsci5D9i; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf24.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697045205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=4YUXMjptMxqquRHS9MTgrETZRVkLs5a0l4ILdlb0TDQ=; b=S7AK6vsUutxPLBRcKXFQ9bcE7SLmMuVJf7I3o9yaUeN6Q5g7yLwN8I4GfiAmP2rSglBskB 4lKSMcR4WSI+XQgNXEf9ygGtQjpRwNNZGK2kB1Djg8UxJEq1AM4uETZcOhebVXR3VgPRod 7D0aRVZt715zLyqE4yeHMX66IBEI8gM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Vsci5D9i; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf24.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697045205; a=rsa-sha256; cv=none; b=Cpi5fymi43CHnco1vD6CBIQ/1YWNj2zJL2mJLWT7AcT78uIqZh+yEMLkw8GNLUT6aYkEQT aD/JQq9HXyIOyWgHSLKanh78crKqkTcbukVKYmFFyXvuc8qa8dwOPgyBO7wgzRCEz5AFtO gHP7sLXyrX5xB6g81w56ktl5aeE0AdI= Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-32d80ae19f8so46802f8f.2 for ; Wed, 11 Oct 2023 10:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697045203; x=1697650003; darn=kvack.org; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4YUXMjptMxqquRHS9MTgrETZRVkLs5a0l4ILdlb0TDQ=; b=Vsci5D9i0j0K53fQjCNEK2n4UMNfox7H4VT89WFIY2zhPItsBIl8kV8lsP3zRhijMa V5suC0lQ6XCTrGL/YPHaunovuzvcHQrM+HuSi/NMFAKJLQXB/ZZpf0W3LXF28BNVdoKm 5fUGBOlT9GHelQp/jLrNw1pMBYX0PqTQVEN1ZFxd+zVlza+bufzeImfVzbyMpbOCYUl1 h66L94BvJBFLQcit8y9fG292YQfLbheD7kMmiV224+xLt/8wRSfQ4XJpAdHoAN0KktNk f2ylI8SqBy5TFiBQj1SqZ/ZrE/eOkDJa1hX4dIRohWIkSoFdcxbfo4iG6fMtqAftFZu6 Mp0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697045203; x=1697650003; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4YUXMjptMxqquRHS9MTgrETZRVkLs5a0l4ILdlb0TDQ=; b=RvSzjVIeTDjp1YHx3J59tS7ztwkgRPkztmvkkELQRWAi/rFBnNhSJmE6SMpOUuvT1m d2yDChyKMlYZclD/CfTZWvhK93slz/stuFZNum5amjPdbhnaZdSr8iegjwc7g97xpjTL 1AD2H/3JfJZ2qvS8z1xeUs3Y5tD/yukqJjpRYbCY+8QIu+eMPc9O8mPdArD+dE7y+U5q A4Lhlw5g2mw4Zk1+5FtNptVCF9wCo381P2KPJWHxzvo4DwZpTBGC9dI7tAF8hQv1qTxO seCoHCWe8y+kCr1g2oTI0jWove8P0SdCB7feq3DarJqVuzvCnEmL2HslP3/SSngM2jL2 akEw== X-Gm-Message-State: AOJu0YxDi288B63JCjDfuaOkvOHRvJsdNNsfkLN79ZSwYEGtaknOKKJX otrtcoBol5eFTmFqbfC56qK2Ug== X-Google-Smtp-Source: AGHT+IEW+I3tetIW54AUPeMeWYw8s2uXbVgQ84gKeWkNp5+Qarh4v1jZOH5IhnRwwSndHgb1i5DO0A== X-Received: by 2002:adf:9dcb:0:b0:32d:87df:6ded with SMTP id q11-20020adf9dcb000000b0032d87df6dedmr1892009wre.27.1697045203216; Wed, 11 Oct 2023 10:26:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id r18-20020adfe692000000b0031912c0ffebsm16045713wrm.23.2023.10.11.10.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 10:26:42 -0700 (PDT) Date: Wed, 11 Oct 2023 20:26:39 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Arnd Bergmann Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Luiz Augusto von Dentz , Kees Cook Subject: [linux-next:master 10943/11428] net/bluetooth/hci_event.c:3276 hci_conn_request_evt() warn: variable dereferenced before check 'hdev' (see line 3266) Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 246FA18003F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: edfxxdmpoitaifq9psywbs1694crbeut X-HE-Tag: 1697045204-449317 X-HE-Meta: U2FsdGVkX1+ZqDwI0V0grmUqjwf48agMwL9WgGCeTXMoX/yzl8hfuKDoYWLjQCAfb+WUeT7wDHCJGVqi41yQbZlrS4vnPQSzxcyavpS4t+u+fRKInbF5JuyInKz27TN47hMpe6plfQn4t+OFsbzQWAyV5I7hEqf/wL/mYa9OHoVK7EwIl9dlYEusa0/43MXkE4h2zzy138V+F6+IwdQQMb8NcdKtSP4OvzwgCjcZV9EaGEtyKCDGIADsP4ej6tuy4CoY6eRJKKm65PlaU3QfCdMlAHc8wjHR2CZOhDxfjsCrFGd80mury3cYB011K6qO+x/rMTCj0LLXJokVNTEajCcANNmTvu6vLBLVR0QsSXvdhJAzOmIXXawGnltn3TaDFClEEjPXWW1uhwprbzIWjPa2SC3PGLtNVMMEjsrSVoDOmJPC10Zvu7BVKysBhA6P7BINXVxH7FB7l0VMLDuYkaL++axlTIQpuDXDBrbq3xSQwTXqJpVSeDF2WrDZj0jhpp0MqZawzZbnzSSKn9xmzIz56TzjoqYpWD4TPdcb4u8ezkopwU6m8baZDDBAbXY5mc+kSsNElq5FbRuxAhBNSkYScoH4oTdV6z/dJz+xyWi3D9NUF+QpnLnzTxF/qsde4V6gnEAEpR5zo0K/h+v4DBMjdx0N+cj+eMIrQCEoM0XtndIj7YMsOoNU/imnpcTHfCesCRCXK+HEeNj+6LtmDf2Tloecmg3YBppezfypubAa+6WWzMAPwQJTAJX6YnY23IzgpkdPuBJOB39wWbBaLM2SN+pcnPGCRr+9J4JyLpcCj2c/Po07SQhbKIkVpmAKmo1k/OG8hFgDeAcYO/l6RoW7Gts1RqcPWv/69rqJBWnAnHh3adAYD1IUNc3XuGhPvrpmerRdu1u1sdVe4YW0y9MpUVsOqFN2IDKcJFoglnVqINAOjXo4TYEXUIeCFeqOy8OKHx2q560QhOkfueI 8x0PGqql FlPT7R7DvYcfzw87OH7ozeQyduaE5b4U6GR4PsrYEGNWmj0KAhB4nw9NPQ4N6iYS4rxu5xXT0+elcs51AO4XgZ0eQ321V0+1GUzVKFgZleG82QptcSukKwMlWPL7pjbgy9ZGCOuIxZtsnaErOL0F6wlwsAjadqNAha4N+i96sw/riFLdyRUo7j8A7J8bo61DqmzQQWJfv+wk3clcxECicWJItJFPEb9kaHV4mEllLLlDX7o7nHUO1kDsKHcRHp3fBFtLN2QsBjseN4GeFBM3cX/rhp4YOTFPuOz96KkE5HvYp029+RyYzde6ahX8QXpaTd3ZcX/pVvRGN4xNKYRry52Eu4p5XTRv61Lroj+k3u/Kqiyq2HlJ+pY3mPyXay/iKL7a4SuSKTd0c+cuFcAlDCi7Qz/1I57pOWWKwvIlCfKoc4Bg4H9nmA1hxa+dJf+0smNRu436SE0/7GjYk/7r9Mgc0RDKLs5DrBu6Bd4KcvYPH8/HSpZh73Qw9MuMakiCcO/wQrc7DajiQPLsvV6liyCU6AH53jIGUTqTyMkGm6THHSFi09W8dZ/TVy10VegraJ1xH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 2933a1156742d8c47550493a77af8e2d81cf3c84 commit: b8ba8e65e84b99d58e278900b4261ef17a20eb27 [10943/11428] Bluetooth: avoid memcmp() out of bounds warning config: i386-randconfig-141-20231011 (https://download.01.org/0day-ci/archive/20231012/202310120031.J3PSRP8D-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231012/202310120031.J3PSRP8D-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202310120031.J3PSRP8D-lkp@intel.com/ smatch warnings: net/bluetooth/hci_event.c:3276 hci_conn_request_evt() warn: variable dereferenced before check 'hdev' (see line 3266) vim +/hdev +3276 net/bluetooth/hci_event.c 3e54c5890c87a3 Luiz Augusto von Dentz 2021-12-01 3262 static void hci_conn_request_evt(struct hci_dev *hdev, void *data, 3e54c5890c87a3 Luiz Augusto von Dentz 2021-12-01 3263 struct sk_buff *skb) ^1da177e4c3f41 Linus Torvalds 2005-04-16 3264 { 3e54c5890c87a3 Luiz Augusto von Dentz 2021-12-01 3265 struct hci_ev_conn_request *ev = data; a9de9248064bfc Marcel Holtmann 2007-10-20 @3266 int mask = hdev->link_mode; ^^^^^^^^^^^^^^^ Dereference 70c464256310e1 Johan Hedberg 2014-07-09 3267 struct inquiry_entry *ie; 70c464256310e1 Johan Hedberg 2014-07-09 3268 struct hci_conn *conn; 20714bfef84d3e Frédéric Dalleau 2012-11-21 3269 __u8 flags = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 3270 3e54c5890c87a3 Luiz Augusto von Dentz 2021-12-01 3271 bt_dev_dbg(hdev, "bdaddr %pMR type 0x%x", &ev->bdaddr, ev->link_type); ^1da177e4c3f41 Linus Torvalds 2005-04-16 3272 d70e44fef8621a Lee, Chun-Yi 2023-10-01 3273 /* Reject incoming connection from device with same BD ADDR against d70e44fef8621a Lee, Chun-Yi 2023-10-01 3274 * CVE-2020-26555 d70e44fef8621a Lee, Chun-Yi 2023-10-01 3275 */ b8ba8e65e84b99 Arnd Bergmann 2023-10-09 @3276 if (hdev && !bacmp(&hdev->bdaddr, &ev->bdaddr)) { ^^^^ Checked too late d70e44fef8621a Lee, Chun-Yi 2023-10-01 3277 bt_dev_dbg(hdev, "Reject connection with same BD_ADDR %pMR\n", d70e44fef8621a Lee, Chun-Yi 2023-10-01 3278 &ev->bdaddr); d70e44fef8621a Lee, Chun-Yi 2023-10-01 3279 hci_reject_conn(hdev, &ev->bdaddr); d70e44fef8621a Lee, Chun-Yi 2023-10-01 3280 return; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki