From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762E6C433EF for ; Tue, 14 Jun 2022 13:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEB4D6B0071; Tue, 14 Jun 2022 09:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A99F26B0072; Tue, 14 Jun 2022 09:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 939916B0073; Tue, 14 Jun 2022 09:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 81FC86B0071 for ; Tue, 14 Jun 2022 09:05:32 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4F53DBF7 for ; Tue, 14 Jun 2022 13:05:32 +0000 (UTC) X-FDA: 79576862904.26.5C5B128 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id B87161C0096 for ; Tue, 14 Jun 2022 13:05:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 72EE11F899; Tue, 14 Jun 2022 13:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655211928; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l5MLiLIewYAuhnoSSewDxITeaWh65ALzvG8g23+AsnQ=; b=XAKIbySfJeZlWAUb4XvzTdwWr6jaBJyunR3aCj3Y4AJ3reNnXfUYIorazWg7V8/i2MYkhk iIbCg4DHno/OCqGLwq+dC209Rmk5BL4cBYpHxZ7V/pwsbDFl3+2Xrk9TZ7Rc6mrz5FST7a bm2bb65Fpi13BVw9qfJtSuTXQWTwZO8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655211928; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l5MLiLIewYAuhnoSSewDxITeaWh65ALzvG8g23+AsnQ=; b=bAtm/E8qWNtDo8C7WiG6NK/GYLAXvmm0ue8eoR0TEXWBPVNt/rgE2p4uliOiJq0J0dCUmM i/OUR1TH97ND+WDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 487851361C; Tue, 14 Jun 2022 13:05:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qBrrEJiHqGKeHgAAMHmgww (envelope-from ); Tue, 14 Jun 2022 13:05:28 +0000 Message-ID: Date: Tue, 14 Jun 2022 15:05:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/3] mm/slab: delete cache_alloc_debugcheck_before() Content-Language: en-US To: Daniel Vetter , LKML Cc: DRI Development , Daniel Vetter , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> <20220605152539.3196045-2-daniel.vetter@ffwll.ch> From: Vlastimil Babka In-Reply-To: <20220605152539.3196045-2-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655211929; a=rsa-sha256; cv=none; b=U4ROo+EUsSoahWMlznwmI9sItOaTwfpYX/s8Lgfpv0B0E1HPhFxsgYzCE/gRbrwIdpWQq+ YDdJ19QP29wbdK3vYQWy1GccmarMR8+aYyJ7gFlY1syQaGKoum4sVn8kyI771olm9+v5O8 V5OZPKaCnBqmPziCTJ2Ni4pdCir2Tws= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XAKIbySf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bAtm/E8q"; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655211929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l5MLiLIewYAuhnoSSewDxITeaWh65ALzvG8g23+AsnQ=; b=EvWKpsqt7lPB16u1bwbetZlWcsssxuTR50415wevKqDjziBisRnOu9FMFAy0ITO7xCJQd4 dd9W+HhnXBQK30FK0v/QeGh6/wHbyODl/IGGjJK578b0KEl/GxrpMjNjhI6tAwZpgxBgU+ zGRj9YWQTOfqAG84+yNtmUFX+wHqMNk= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XAKIbySf; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bAtm/E8q"; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-Stat-Signature: mzthrgdhojw4q65nupimfb9amh38ygji X-Rspamd-Queue-Id: B87161C0096 X-Rspamd-Server: rspam08 X-HE-Tag: 1655211929-389781 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/5/22 17:25, Daniel Vetter wrote: > It only does a might_sleep_if(GFP_RECLAIM) check, which is already > covered by the might_alloc() in slab_pre_alloc_hook(). And all callers > of cache_alloc_debugcheck_before() call that beforehand already. > > Signed-off-by: Daniel Vetter > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Roman Gushchin > Cc: linux-mm@kvack.org Thanks, added to slab/for-5.20/cleanup as it's slab-specific and independent from 1/3 and 3/3. > --- > mm/slab.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index b04e40078bdf..75779ac5f5ba 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -2973,12 +2973,6 @@ static void *cache_alloc_refill(struct kmem_cache *cachep, gfp_t flags) > return ac->entry[--ac->avail]; > } > > -static inline void cache_alloc_debugcheck_before(struct kmem_cache *cachep, > - gfp_t flags) > -{ > - might_sleep_if(gfpflags_allow_blocking(flags)); > -} > - > #if DEBUG > static void *cache_alloc_debugcheck_after(struct kmem_cache *cachep, > gfp_t flags, void *objp, unsigned long caller) > @@ -3219,7 +3213,6 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_ > if (unlikely(ptr)) > goto out_hooks; > > - cache_alloc_debugcheck_before(cachep, flags); > local_irq_save(save_flags); > > if (nodeid == NUMA_NO_NODE) > @@ -3304,7 +3297,6 @@ slab_alloc(struct kmem_cache *cachep, struct list_lru *lru, gfp_t flags, > if (unlikely(objp)) > goto out; > > - cache_alloc_debugcheck_before(cachep, flags); > local_irq_save(save_flags); > objp = __do_cache_alloc(cachep, flags); > local_irq_restore(save_flags); > @@ -3541,8 +3533,6 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > if (!s) > return 0; > > - cache_alloc_debugcheck_before(s, flags); > - > local_irq_disable(); > for (i = 0; i < size; i++) { > void *objp = kfence_alloc(s, s->object_size, flags) ?: __do_cache_alloc(s, flags);