From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF28EB64DC for ; Fri, 14 Jul 2023 14:27:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EDAC8E0002; Fri, 14 Jul 2023 10:27:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69C538D0005; Fri, 14 Jul 2023 10:27:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 565458E0002; Fri, 14 Jul 2023 10:27:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4719F8D0005 for ; Fri, 14 Jul 2023 10:27:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 046BA160273 for ; Fri, 14 Jul 2023 14:27:13 +0000 (UTC) X-FDA: 81010444788.01.D217CC9 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by imf26.hostedemail.com (Postfix) with ESMTP id 68F9614000E for ; Fri, 14 Jul 2023 14:27:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=NVDxZZVQ; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=coRg7x1p; spf=pass (imf26.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.20 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689344831; a=rsa-sha256; cv=none; b=2J6f8/YxeI/cO7uOmurXbPzg65sNkpsFySOxB2P/fcChnOo70dAzsIyHe0hV6lumhQ5AsL QuscudyfbJJ3ytn9oz9I3YtK97EECUDIHRhx7cdvgMW8Me2qu76uTUj7qP2p/bzuzAAIio Tgql4AU8OSVW/ZSZYZ0mKBBye4sJrN4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=NVDxZZVQ; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=coRg7x1p; spf=pass (imf26.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.20 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689344831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u5ipAH4K0NlmFos4pkZwsy4Cy+qhc8YEhRBvZpa54NA=; b=fZbn8AZ8/bfdTnQsVBenGGwiDezI9001GYe70/wOoSU/6cRdIuqrgdfw8XIAZmwHhsDHyQ rEYsj3OcpCBqXduLrAVki6ykwFmZVxgY8xb6e/iST74HNXgNU5HORxyAhKEnp83rBu5Lk0 B/vDlp7uHleId/wlz26GSEBOtzMHUh8= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 05934320094C; Fri, 14 Jul 2023 10:27:07 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 14 Jul 2023 10:27:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1689344827; x=1689431227; bh=u5 ipAH4K0NlmFos4pkZwsy4Cy+qhc8YEhRBvZpa54NA=; b=NVDxZZVQVdpDVPqMKF 5D21skUCKYkBUX497oLptmP4rm9ICbEKrL3/5o+aefL42+DszscNov6Sfg1O1oO+ HyZcRFc2l0D9E8L2ljfTyZEC0je25cILkj/SbcX9sec1bZzujiS/c/qUpKVt2Hxv 6VGve5GLs5640rZYzr1+XX2nqpAE6TumggKWqyPPibpMRqEaogZ4u6jTEr3tsR0R ZcCd8h54KnIXnVlbnFxbbx6itIuJ7NLVXgIkBVJGQ/MTe3L2FwyAUDrWcq8jvABZ nclMpn0mHQMre0DfXOAm5IudfTcgMdLYhcsx28XlTakAQFXYCCiJ9QaMPdI4Bzp0 KVPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689344827; x=1689431227; bh=u5ipAH4K0NlmF os4pkZwsy4Cy+qhc8YEhRBvZpa54NA=; b=coRg7x1pxfRs2SC9fY5YA59F+siDT 6kOl1drANxJlueREdmaiFWHCiyyvyhzXlj9NiaIHH2Tt6876pe5/xvWRUbr2JIhv Ur8Y0fDRofH+vFA3ILQuRieNJ77P4KrjpL7i9HHwV4rOHmReGS6AhrxnRAFHQHde 4Q+BCBTOykfF94B/+2za0O+96x+Xkc6GZRkHgfQsuUtC6i8KFDyFi37rV+SxsLjI eQ0GbaFsfeFFALg59LnFlGWGyBgWgiqHVjP6qefjUz7p2Vrt333mCwi2y4NXk43n nDY4Dtm8i3tjIPs263JDEWZlpObxB1G7iYlM0wFH3Kf0sEMPQHvWLD8uA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfeeigdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9F37AB60092; Fri, 14 Jul 2023 10:27:06 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230714141218.879715585@infradead.org> References: <20230714133859.305719029@infradead.org> <20230714141218.879715585@infradead.org> Date: Fri, 14 Jul 2023 16:26:45 +0200 From: "Arnd Bergmann" To: "Peter Zijlstra" , "Thomas Gleixner" , "Jens Axboe" Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" , "Darren Hart" , dave@stgolabs.net, andrealmeid@igalia.com, "Andrew Morton" , urezki@gmail.com, "Christoph Hellwig" , "Lorenzo Stoakes" , linux-api@vger.kernel.org, linux-mm@kvack.org, Linux-Arch , malteskarupke@web.de Subject: Re: [RFC][PATCH 04/10] futex: Add sys_futex_wake() Content-Type: text/plain X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 68F9614000E X-Stat-Signature: z3rhbfmy5bihyesb8hp4c6tfxjae6ybt X-Rspam-User: X-HE-Tag: 1689344831-455846 X-HE-Meta: U2FsdGVkX1+PAoPRl2Nr/Lvc0ky1JMp37L/7uWROYFDp6WkUKlsw1nHLFi0U74RnciZVNs9iZIZPTkzECKIkwBwkO4rIqI60fQD3stiqDklf28tQIKbHFbgm3HZhpIxuz08XjCdv2kRE14KPbPRR3VBlfhjaYdPiq6rU92O1V5OZhDtXur9pUPtkRFMJLf2GTNZPpAgjoO6B84Djj+TFVTJ7EhFfQ8eOF3UlTKoRNBHU82YcsXMI4kjGDk4UrGfe+Cu/XetTr9ggIEJEwWthZ68qyjU/ACtPq42UGg/WPrcU2hI6UNo3N/+nroaX17w7+Me7DOjks94qWcvVbHmSzPrKbUbYcf9h5d1qJCO31pEjxOetqiWEB01yNHxRGJB7HcxVupJvyH4AJzbeejqfjKnkAC9kEYgwSaUw6yvOx4mK+7+ytsBzfukRde/+W1eRG6i6eWhZCHuK+J/C7shyg0uBi6q9nIPfG0lb94uv/vnYIOf9UYqgmyg5jrdqtIrEbKTNZl8kmP0XHek6pu01r/CU0HZ1fnCOn8yYhyxgCyGKsGNC9OaOL1i19fQGHlLdYCJbH9iPIeNBX01oZmqXWhis/qAku5BXCLDq7COVXnJXY8WDuY3K7InjBv0WR6AdyEiSQ9BDtxHRzrhum/2ebxfykbkJb/v8/7MxuUqnVkv8tIcJeKH1ODdW52895+sJ5vRQ9j472SH0JN9aX1ogiKzmtm6Jt5MqLAw0uZblsXofxgylC4PxzR3jK8pdilAFaJPEVw5LTigA2pk7LU9V14tFRgMTUgf1Yfgf0BA7V/dfvyBoOr0QMrx0HHPr2HJzpyP5t+tNIIKbxuCP/b5JY3plQpBlqmUeHIS7XLjK1sDxjodGViZmSEqSXOSLb1UFNREsxWU4ds6cKCAmFiSotxBUsw8vhRRUodF9toHS51FRP0edybxrWOgQcSAyKgWrtLZywk8mnHI6PjqG2E7 eF+41ipi IiIGIgzSDMbCZqQSKgMSX+wtMEdC7qDJVdHwgPpcj8YQXryhgp6PA3UURfhwXOlnw/u8OSj5dRRzDYE9em40nnVqRjXuQx2nfUgg83LWK/d2Io+sXqJ6bB0AonkEXz1fRgHz3PtSBxk75mQgugAPgKvPDg31MkSi1oOBNwGFTz+90+dzPFAxALhZNmkdLXubzst1DyK3WMgqKgzsY66Cx7VqJuP6aX/scZ+Gh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023, at 15:39, Peter Zijlstra wrote: > > +++ b/include/linux/syscalls.h > @@ -563,6 +563,9 @@ asmlinkage long sys_set_robust_list(stru > asmlinkage long sys_futex_waitv(struct futex_waitv *waiters, > unsigned int nr_futexes, unsigned int flags, > struct __kernel_timespec __user *timeout, clockid_t clockid); > + > +asmlinkage long sys_futex_wake(void __user *uaddr, int nr, unsigned > int flags, u64 mask); > + You can't really use 'u64' arguments in portable syscalls, it causes a couple of problems, both with defining the user space wrappers, and with compat mode. Variants that would work include: - using 'unsigned long' instead of 'u64' - passing 'mask' by reference, as in splice() - passing the mask in two u32-bit arguments like in llseek() Not sure if any of the above work for you. Arnd