From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63101C3ABAA for ; Mon, 5 May 2025 13:43:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51C1D6B008A; Mon, 5 May 2025 09:43:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A4946B008C; Mon, 5 May 2025 09:43:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F8AA6B0092; Mon, 5 May 2025 09:43:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0CFF66B008A for ; Mon, 5 May 2025 09:43:40 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CBA5512071E for ; Mon, 5 May 2025 13:43:40 +0000 (UTC) X-FDA: 83408971800.23.0051D9B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 6B2E2100002 for ; Mon, 5 May 2025 13:43:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NhAp3hao; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=etM7WbHd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NhAp3hao; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=etM7WbHd; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746452618; a=rsa-sha256; cv=none; b=r7u9gYakH81uinKqo0S0GeQ31w4rrfKRTzl+BYeNuK6pvwtBugZ9HY38v6fR+BPL+eemvo INp98/wRlvf3BHYFj/50kGgv2dxPhhx6ms9ogITeSdbhnsMmQFpg3uVkAzCxj47sRPrFBB BANHml/m7LdQMvUH1SmHbQxQOMCwczo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NhAp3hao; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=etM7WbHd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NhAp3hao; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=etM7WbHd; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746452618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PP8n/I9c2HpK3CnIVwDPh7bDQ61AQFRol0vbEOVCU/E=; b=DZAsaSD+O1/XJzMOxFWfh0jpnwh7khDQ88oh6puYE/vm84voEJOcYmdEu8P6rF0z/lWJw2 Sn3sczYnX866b0eHiyFXAKrLJqxAJR1PZyvxP3aWz+AK8U397VVJGZxTaq3S5CfEzmQZ4d W38tG0qOFfLMUgvyrUHyHOyt+7m34nM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 883341F79C; Mon, 5 May 2025 13:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746452616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PP8n/I9c2HpK3CnIVwDPh7bDQ61AQFRol0vbEOVCU/E=; b=NhAp3haovTppDhz1ZgJVSTRoq9Cx1hp63I6YHUypl1os/L9WzRoOatMCwIM9QNrCfoTiF1 D6xbCKtROUqWipKc4xhr1TKB7ZeIpa07CIyLWCnMXZxtdMwjmjVezIhNXGZGMV4QXen0CD n1T8njYL8klQ7PgI4ndnQsQUMCIU+T0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746452616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PP8n/I9c2HpK3CnIVwDPh7bDQ61AQFRol0vbEOVCU/E=; b=etM7WbHd96MRE+tNykIDJQ856Bdm3saxpZz7SMYz8leDIjPSQNws6UHUcfag7XvP+F8jwd 3l7ewVIBtff5tYDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746452616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PP8n/I9c2HpK3CnIVwDPh7bDQ61AQFRol0vbEOVCU/E=; b=NhAp3haovTppDhz1ZgJVSTRoq9Cx1hp63I6YHUypl1os/L9WzRoOatMCwIM9QNrCfoTiF1 D6xbCKtROUqWipKc4xhr1TKB7ZeIpa07CIyLWCnMXZxtdMwjmjVezIhNXGZGMV4QXen0CD n1T8njYL8klQ7PgI4ndnQsQUMCIU+T0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746452616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PP8n/I9c2HpK3CnIVwDPh7bDQ61AQFRol0vbEOVCU/E=; b=etM7WbHd96MRE+tNykIDJQ856Bdm3saxpZz7SMYz8leDIjPSQNws6UHUcfag7XvP+F8jwd 3l7ewVIBtff5tYDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7505413883; Mon, 5 May 2025 13:43:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kji+GojAGGgBOQAAD6G6ig (envelope-from ); Mon, 05 May 2025 13:43:36 +0000 Message-ID: Date: Mon, 5 May 2025 15:43:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jonathan Cameron , Rakie Kim References: <20250502083624.49849-1-osalvador@suse.de> <20250502083624.49849-2-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: <20250502083624.49849-2-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6B2E2100002 X-Stat-Signature: 33ckhwfgbny3h7ktkgbrdcwew44dxe9i X-HE-Tag: 1746452618-380840 X-HE-Meta: U2FsdGVkX1933OhN3GfyY/nhvRMyc4JpooxkZHmE/6RZuEfp/2RizNeLTkem2hQDYLBrpFEeQIrt3/WISVd9nFHWew+FFFnSTvcX96UESHnEjjnoy6yV56AviLgQjBBqK+3iQPj1icfSSQTfTqagjDpgndNDcEuQ5D1YmMG9OrlllKZJEk2PhwASJ7JQmC+aHcq4P7oQhv8zAGV38d4M1OUBBTP4Zq4xjBtHBUwOP9eQ4ziSqi8efrv+DMx9fy/VyHgQ1tESlRubnsFpR8G97YaizQDT7xX1NKf6VlcjzDPKtjK3blt4OO5jlfcz7g52py3y/CSwm3A0+0gW6auOfwt7Hit3CtHH6P78SQc0WTPj3DUMI29MgoyjJ6ZboKmpoIYL+X0IBzt7p6cPZjGN9udbk9nylcrsVzSO/GNOyAomQLSN1RCW0A4EeOS2p0IlLXMUBeqNankuw10mr+BDH4pdliiF5jfZrxOG+iczuPG4gg7P/wnPGcO+COovM3Hs6XBJEy6FNzW8UNqsmkAWlYUSedNricxkjPY99wLQagcczlFa4dVcZo1zFBu03jhDsJpae5ABz4sfbOH02n9Plxr+ubGE80bDzIIaJfy5KQUp5fJgQq9GbXAZnk9lLED2Tzoy+sbEwN0mYiaDqwqLlCZ75Y4rAU4ni3RmY1sk6JuXFWfYx+Vxq1l9rbQa8zgkymqu/R5DobnlUNuRcTqrNyGwpQ8OBEF8hYytVv5TnkaY7VSRSS6+Y7JkQaM1+qDeCiX8nxW+EAj3mfwgKL1taiK5W+mhceFTzwyAU/Zwd+Lq6OVaAegqFFDSOofQVcvPuUDQDmm/09x76P1hC3vjI3U4bmhTRtITM1GtHgfQAZnRwHdXhsMbWHEmJWREmU2VLtrNQ6g1GlPk2sInLFckWhetRBlswbfcLyjClnJgY/JYmzdfgX/fVK+URaEsE6o9uiaaTqA1E3Ksb+WxhYW CbWEcevl 09Z9lSOjfPRNfjutIpW7QmBF1sndq5GLSuI1KgnP9Bwv1qMODViaQ+qZWd4NJz6rMyuiVVho36niKYNzT//nZFGgOsVF5KTa5ZjBpAoYdFYNOj/JLSqlvC0JRvwFrinsqnFTc9H0es6tbtDK7xMc7DZaq4k3lQVcTHtdNb43vUa4CSLiro7l38pym7bj9j4eBfObFXKCzB/A+tDckvU3Gz+XQGAY6IdWfTVXuK0P/DW1trw40KJ+VLvE3Qq+m5WXlZG/3zLGJRhd/E398tebXYWBypGiRvwseXLOQZrt0wRu2d2asxuRs9jBMkwvPJ6mTytj/qjDegGTxQ9o16NEtO/knIYCKJji8HpKw2HK/vvqEK2D7dcViGE8H7itn0R5a5dePhifv1uiAbopqrO5tqY91GkBMtjHc6Bd43eTup2HJYk0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/2/25 10:36, Oscar Salvador wrote: > Currently, slab_mem_going_going_callback() checks whether the node has > N_NORMAL memory in order to be set in slab_nodes. > While it is true that gettind rid of that enforcing would mean > ending up with movables nodes in slab_nodes, the memory waste that comes > with that is negligible. > > So stop checking for status_change_nid_normal and just use status_change_nid > instead which works for both types of memory. > > Also, once we allocate the kmem_cache_node cache for the node in ^ object? instance? > slab_mem_online_callback(), we never deallocate it in > slab_mem_off_callback() when the node goes memoryless, so we can just > get rid of it. > > The only side effect is that we will stop clearing the node from slab_nodes. Technically, another effect is that also any newly created kmem caches after node hotremove will now allocate their kmem_cache_node for the node(s) that was hotremoved. But that should be even more negligible waste than from using N_MEMORY. > Suggested-by: David Hildenbrand > Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka