From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94139C4332F for ; Fri, 9 Dec 2022 01:15:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDF238E0003; Thu, 8 Dec 2022 20:15:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8F4A8E0001; Thu, 8 Dec 2022 20:15:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7EFC8E0003; Thu, 8 Dec 2022 20:15:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CC1FA8E0001 for ; Thu, 8 Dec 2022 20:15:50 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 86FBB1A067C for ; Fri, 9 Dec 2022 01:15:49 +0000 (UTC) X-FDA: 80221000818.24.0C87BC4 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf28.hostedemail.com (Postfix) with ESMTP id E63C3C0002 for ; Fri, 9 Dec 2022 01:15:45 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670548548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JmgShuDwvuBL2FuVEZW+dw1jaZKhlHBvOfBoZY7nATc=; b=7EyxXPF15k3kjzJdByigFGxus3xm0tJp6RrNLZDz08RKh12TMav75HvY2ZSD4azMCocHt5 mBJBKduqaeLkP911e98BnTFtoInv9/Z+QgWlz1D4cAtpzSOZM5OPovzEOQ4Upbx5cOpgR8 xJNhio/3LCMjDznl3N2XcNq3ivPIrMk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670548548; a=rsa-sha256; cv=none; b=Coc65A+1hfURnBCcFWbjfnOWqfnoGUX+318HheLWnGxUwjr17w7uUT8tUBg+oboeHS3eTf 9PZsEOOaM65Fotw6fVIUjUUBBXPsNtV+UKX5E+13yrNwmJxhqkvmvWJ6nXkh0/2pQ/jNO9 +pdchPVl1lAXOw0HNUs4BjXd3jU0DjM= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NStJb3B1TzqSxZ; Fri, 9 Dec 2022 09:11:27 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Dec 2022 09:15:38 +0800 Message-ID: Date: Fri, 9 Dec 2022 09:15:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/2] mm: swap: Convert mark_page_lazyfree() to mark_folio_lazyfree() Content-Language: en-US To: Vishal Moola CC: , Andrew Morton , "Matthew Wilcox (Oracle)" , References: <20221207023431.151008-1-wangkefeng.wang@huawei.com> <20221207023431.151008-2-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E63C3C0002 X-Rspam-User: X-Stat-Signature: 7q51kqfygxjtdfzo3g8do8nwz1jocxwb X-HE-Tag: 1670548545-914552 X-HE-Meta: U2FsdGVkX1+tgeS4JlT6uI0JeeRRIf/9tYZCFx9LHl76XyU/cmlJfIvHfkjEbfxz+ge97Ch50CWpz/ff3IGW0JDeBoYCHDVc54nzRyt3DY6UgXUQncDCUVXwOl0zUi2M2vz+Zwp7CHd9RtSFOLdJ3ydwjCQjbtXBpe2SihZWQVr1+cD6CCWK4urT3w6CAlnGRTYX53CN9BerYy0CKNMk/e7cJ+vXB4zzHIT0Yvdek1KlF6iuNtzRN1dxpssdIlCTTE9nAxgAJEwM30Mdyh3qSUp3svMkmhtXDb887uDQvwYG0ath2oIlp5wPXPXbPr9nPyDE0L9s5nvsSXGsnVYm43vOTRU/HtivOQmeKoKqMfmT+qqnideuliXMToOf0jVar3v91oSIMsGgyYKKr24MqvexPnGz8fdUHMq+jt2+OjhXyDxuqaWISP30y58mNqTjLiMLYrSQhNYKyyqLVXBF7x8hdtvVZa7zHAHHGbMWpvHQZLyXk41Rehq3Dp03kEnRLhGadH2ZOFdZTryDUegeJBNGsCOqU0kNVkp+Ya0MznRpFqLQhovpGARKfIwwaXg7hrTo/eHegFnx4bqjEvMRoKY/1wouJ3VXA+yn19NUIP108OFAa6ABXmFzDMGW2cvTris/fpi+0KG5oANutiMn63gqfL0X43ER5MAqSUv18I0llxqz8T9tbkRDfEdQpFKFl24gHgPud8pdHltgjevoKnQ19akal/CQBfXq3xvSmOYdeA+RpUcH+dQZuD5zL9WXKvZdywUMSpoXqnh2giDSNhQD78ir4xDMRuFT1rBdPJu7Xc1cd5P45q44innXsSfW30xXu7bSKylbDfBzMeEpHpdhrOpj2ZYsMRchpgAR1VsZE75j1c5mshWCuZD6qStHSRsLTClLThczqg5SEKmTJw2MJZcQ9N7m5xCf7YrlZM6mCUa395WFPzCeNNHTJmhB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/9 5:32, Vishal Moola wrote: > On Wed, Dec 07, 2022 at 10:34:31AM +0800, Kefeng Wang wrote: >> @@ -402,7 +402,7 @@ extern void lru_add_drain_cpu(int cpu); >> extern void lru_add_drain_cpu_zone(struct zone *zone); >> extern void lru_add_drain_all(void); >> extern void deactivate_page(struct page *page); >> -extern void mark_page_lazyfree(struct page *page); >> +extern void mark_folio_lazyfree(struct folio *folio); >> extern void swap_setup(void); > Can we rename this function to folio_mark_lazyfree() instead so it's more > consistent with other the folio functions. Also I believe we can get rid of > the 'extern' keyword. ok, will change, thanks