linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
	Pedro Falcato <pfalcato@suse.de>, Kees Cook <kees@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vma: use vmg->target to specify target VMA for new VMA merge
Date: Thu, 19 Jun 2025 15:36:03 +0100	[thread overview]
Message-ID: <c54f45e3-a6ac-4749-93c0-cc9e3080ee37@lucifer.local> (raw)
In-Reply-To: <20250613184807.108089-1-lorenzo.stoakes@oracle.com>

Hi Andrew,

Small fix-patch to correct a comment here as per Vlastimil's feedback.

Thanks, Lorenzo

----8<----
From 0a84d237b05e6cf801933267488c8353ced7913b Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Date: Thu, 19 Jun 2025 15:32:57 +0100
Subject: [PATCH] mm: make comment consistent in vma_expand()

The VMA merge structure contains a pointer to mm_struct so we don't need to
determine it from an input VMA's vm_mm field. Update the comment to reflect
this and make it consistent with vma_merge_new_range() and
vma_merge_existing_range().

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 mm/vma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vma.c b/mm/vma.c
index 13794a0ac5fe..4abed296d882 100644
--- a/mm/vma.c
+++ b/mm/vma.c
@@ -1094,7 +1094,7 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg)
  * Returns: 0 on success.
  *
  * ASSUMPTIONS:
- * - The caller must hold a WRITE lock on vmg->target->mm->mmap_lock.
+ * - The caller must hold a WRITE lock on the mm_struct->mmap_lock.
  * - The caller must have set @vmg->target and @vmg->next.
  */
 int vma_expand(struct vma_merge_struct *vmg)
--
2.49.0


      parent reply	other threads:[~2025-06-19 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 18:48 Lorenzo Stoakes
2025-06-19 13:44 ` Vlastimil Babka
2025-06-19 14:24   ` Lorenzo Stoakes
2025-06-19 14:36 ` Lorenzo Stoakes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c54f45e3-a6ac-4749-93c0-cc9e3080ee37@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jannh@google.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pfalcato@suse.de \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox