From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F179CF318A for ; Wed, 2 Oct 2024 01:40:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5F944016A; Tue, 1 Oct 2024 21:40:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A55B440168; Tue, 1 Oct 2024 21:40:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7456F44016A; Tue, 1 Oct 2024 21:40:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 47A5C440168 for ; Tue, 1 Oct 2024 21:40:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D688D1217C4 for ; Wed, 2 Oct 2024 01:40:50 +0000 (UTC) X-FDA: 82626958260.16.486978F Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf14.hostedemail.com (Postfix) with ESMTP id C8014100008 for ; Wed, 2 Oct 2024 01:40:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=WHMuCLRv; spf=pass (imf14.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727833121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F2Ynh9330ndz09vKD3bfokDXM+kkK4ocaOTAo8EIolc=; b=zvEvsAJmQF2/34AwA4RQPa2QVG5pWq88DAv5SFyNnXc/7siHw6AszHf2qNwZUMJpeDQa9R dkw4ITZUH84h934XyRJBZrHX+GuRUmXA9XhsHVlyIqu+70o/T+yRdBC1H0I+9xh1TrVQXz HORDfaiIllnqzmkrcxRXHG8EUuFbvJE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727833121; a=rsa-sha256; cv=none; b=IeXsSKoJYZtbNgkEvD1IA7iIUunXqTgoILvVX74kUT78P3sarZcAZUdmFDXY1G1fqeHVvI TvLcfI65WnQsQLgLZZtBCY8RZN7aitCR4I/Dr70qXCg7Md40qVg9X8ClyOySenXCXob0/E Z9b+QmpgmakBieuvmLBbHhan54VfApw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=WHMuCLRv; spf=pass (imf14.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com; dmarc=pass (policy=none) header.from=igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F2Ynh9330ndz09vKD3bfokDXM+kkK4ocaOTAo8EIolc=; b=WHMuCLRvFXEcXlePXfpP78nSoI pdIzaVDUO+kp6ZgucZEMn7zoZ/xPZIg0VPDELJ74APoMSCD2SlvxyBYkOV8Vf0cB6QWDb2+uSMsqB 0vCQ6tUBa59spE7md5TZyC8sVAyvOL32Wwh56bqCFkc/VeshQwBhd+IfKv1SzewMLFNAPo4kzXhik URDqsN7PQ3W5uFMcMQX9wzLujs61Z3oxAhAGYgDYO4Yu+f6+0qSZFsc1d9wC5FTwYlWoDJ0zTZNLV Za/ngr7RwWHMJCgS/BIA13Xx5wXRxH1fXpyf3/IAz4kfByIhz0QZEOmLJE7LIEJjCSXFJdMB8UMPW xoR7vesQ==; Received: from [187.57.199.212] (helo=[192.168.15.100]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1svoLq-003eIM-0u; Wed, 02 Oct 2024 03:40:26 +0200 Message-ID: Date: Tue, 1 Oct 2024 22:40:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 07/10] tmpfs: Add casefold lookup support To: Gabriel Krisman Bertazi Cc: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig , Theodore Ts'o References: <20240911144502.115260-1-andrealmeid@igalia.com> <20240911144502.115260-8-andrealmeid@igalia.com> <87ed5olmmc.fsf@mailhost.krisman.be> Content-Language: en-US From: =?UTF-8?Q?Andr=C3=A9_Almeida?= In-Reply-To: <87ed5olmmc.fsf@mailhost.krisman.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C8014100008 X-Stat-Signature: xeyk3cnmxqh6pb73bmqg13pxnysk58jr X-HE-Tag: 1727833248-604858 X-HE-Meta: U2FsdGVkX19ouzS7tRUaRelQZPxxOXH5aHlMl+3z+L7LQZ3rMcW5D+eybZXXejKHnNYC3kW46i6pdBxZybTyFV0gTiOJ72ga5u/IZTNcsqCka9pfBbmlRZqojV4lV9wP3w3BbL6CF3lI0NpRoWNrF6e8+J523uEm/1/NydX5neh4+0H3PHaAsYh+QpwwslgacKLRs8H2VpbQEFPtaac1wcu/JuViC5ZwCVVx4+aRaDo6NFHc9i+mwT6tJrFggLUzoU+QaDV4GZAvrpW+gWVT0m5AP88gt8tdOsk8SouCAob1QFwFK2wD/AteSQA1qKdQqnHRhqMty7RHzIFvfBgpgQImjRR0jZ4ppAOYQ73WoUye4d+7Bcms05D0exSLhpugSd4idl4V/EVKFcVvwcZLzOUjT8QLekPh//WoPWg8Vj3Br5YTgyYYSdicYITzGT/eHSkzRximTW2z1yVD9pZLYPQPWp6ax2kRDYzNP6RETUDr6r8rJDerKuypgOWH7EC3hUYBvemQzWw9uGH31DVnJ7cdM79ldc2LdO+T/21h5hzQXmzqHW/ohoeOsjs3jqXeC82WcZoyD8PViWYR9+HsnKLrSvGkNzrKzpTtFqLwfyyzRveGLBR+vXzkKaso78JPj+shnFRQXNXqRz2+OrKKHbHa3wx+P+Q51A0PO8i94Fut1XLLolgBFpBj1kjX8xbiRZJ3re3B75k+7k0zDa3Eov66jAI+bZDEE112qknzg9hYH+LvcKUIPaKP4vptQRANlFNChCRZ0RBA/D27ILPOvoRMUiSP4hIa5MC68AQEHm10cYXcayLgIQjYRGaRUjGyMogB5FePwiu3GGyWaFQXLbY/urAEh6zd7r8kMRHnXektYvludjJUEpsKSVatd6B88DSpFU3mkvugEVOq7l31dLdmpjPNGuj3elRHM/ONZ37bB9cO6ulleB3ENhg9YzIW9Sr78J5wUceOzipXAJK JLw75lPx KasM+wLC28CIj7ot+wNjtkDJtQ60srw4f2mowxQaQS335+qTJ75ssu8Y+/Y1K1ewmgb6UKpbLfIjjqrWfCGi3Xi1KxYNChgpWvVtDFEpm5PqzHyqkDsHXPSiNekLMHv5wOr9Oz7Ezq3Bsl65lOQu0zvaSChc3/CgEUT0LweXZjrTKGmBwHWEKx3X5QmyP9UWc+oCJFyOc1OBz2ny55rUSIYMhdpb7mSGqP9hBpv6kYipqKF3nTLWnUrL3u6bTvhWZgYw1aG0y/Z94oOuMRYzNRd5XV88UsjVbN0zYcvNY5esKK1NBPWvC5dy25PP4RejfSXv0PhurpnVVBS2NLHNvkYE55tl2TFyEbwjtuxj7XHf6lKaz4j7goCm6Mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Krisman, Em 12/09/2024 16:04, Gabriel Krisman Bertazi escreveu: > André Almeida writes: > [...] >> +#if IS_ENABLED(CONFIG_UNICODE) >> + if (ctx->encoding) { >> + sb->s_encoding = ctx->encoding; >> + sb->s_d_op = &shmem_ci_dentry_ops; >> + if (ctx->strict_encoding) >> + sb->s_encoding_flags = SB_ENC_STRICT_MODE_FL; >> + } >> #else >> - sb->s_flags |= SB_NOUSER; >> + sb->s_d_op = &simple_dentry_operations; > > Moving simple_dentry_operations to be set at s_d_op should be a separate > patch. > > It is a change that has non-obvious side effects (i.e. the way we > treat the root dentry) so it needs proper review by itself. It is > also not related to the rest of the case-insensitive patch. > The idea of setting simple_dentry_operations come from my previous approach of having our own shmem_lookup(), replacing simple_lookup(). Now that we are settled to keep with simple_lookup() anyway (that already sets simple_dentry_operations), I think we don't need this change anymore, right? This will be set for every dentry that doesn't have a dentry->d_sb->s_d_op. Case-insensitive mount points will have this set, so we don't risk overwriting it.