From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD23D4922E for ; Mon, 18 Nov 2024 14:50:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A09F6B00AC; Mon, 18 Nov 2024 09:50:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 650516B00AD; Mon, 18 Nov 2024 09:50:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 518456B00AE; Mon, 18 Nov 2024 09:50:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 353DF6B00AC for ; Mon, 18 Nov 2024 09:50:04 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D946B1401A9 for ; Mon, 18 Nov 2024 14:50:03 +0000 (UTC) X-FDA: 82799497956.09.C4D544D Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by imf30.hostedemail.com (Postfix) with ESMTP id E38D280003 for ; Mon, 18 Nov 2024 14:48:28 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Cg+XWwM4; spf=pass (imf30.hostedemail.com: domain of axboe@kernel.dk designates 209.85.160.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731941159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=64rV6XVBsSRZD9lz1azW3sqQ1KWaD6KRPC47/eG5qsA=; b=s0Pa5rUL2kwENwrJEsyohRGlH7CQBFvuZJsahRSh4eIxdsDNU+Bun7Eg1HRCfDRSFQQJsa 4tvhAhs9/1qvV0JHBIvn2gNTGE3s1zk+3tAK2N36bHmhAIJdoVsbsl5pIrhLOsQkQMkJgx RoHW7zpDHR8qDK+mnvvucKqpiH1bfyw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Cg+XWwM4; spf=pass (imf30.hostedemail.com: domain of axboe@kernel.dk designates 209.85.160.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731941159; a=rsa-sha256; cv=none; b=0SovwcfnEFxiacNpuBeo4GmG1syM/xaxjsIHcIvj+2cGVGfP3Ov455lv6nQTAs7WzIgQWZ +ss5qlUyiT1TvOQCBxXCpk1VeYWCcWt1MdYQur/aCwn4L9RwIOUDoRkZR3tVjwyBZVqJud J8vfEsxOMDkOC9Bjmk9xmBfX1rTfE88= Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-296252514c2so2730267fac.3 for ; Mon, 18 Nov 2024 06:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731941400; x=1732546200; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=64rV6XVBsSRZD9lz1azW3sqQ1KWaD6KRPC47/eG5qsA=; b=Cg+XWwM4P7pwTyUqjO3zp/l37uYPpU9K3qK4hHE0Q4dKnSHwZL3bnR22E4XBBp4id4 8DIGOtxZmQ2q6kQlVJzJUBta8cdjlVEmE4U93nLFbziaPO4nQuSWVB+zd+NNRyqDL7eU Ca2nnyPPSQUQ4nBrh1kHpjCt3bsl9BUQzjLEyzVuohIFkmNBZvW7z2YAUgab+DmicD9P 3Wyy4wBPwjH/xJCTPBdarRC3YblREIKH207+99f3RT4Wft7Ca+vfWc26mixsbKGFsppw WuicmREgI0s1sRC0oOkwbh2StoX6eszh9PvXzQewxwiwzD1H2Gjlr2OsegsmgXBJkODt UNMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731941400; x=1732546200; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=64rV6XVBsSRZD9lz1azW3sqQ1KWaD6KRPC47/eG5qsA=; b=KiMCmUWNsye9mqv8l0bcPZNBiA0MRgLmf4HdsJk6vJL7VvOBrLwuuRCDB63R4+wKrc JEVKVvUZy2u9uPTXWIFtvEAAlzlD4d7fbCqxTGu0aDjHX/FFFqsVJc/ZpVzPBa7bE9ui DAvxbI1HJHNmfUpdILNuv5stqx1C51nppYqE8xdgq/LLgIf1gHRNKBguaHHgJzPxrLqk 0MqJIJ05cEyD9de19uUMctHWWHfT8DbHKmI4PolE/hd8pEx7dNLWXjIiZcufY7+f8SKT q38genQhPqynNn8CY4R0eA054DuYXl3w4bcbh/RLPOq84q7NoVujStGIMNMA/963Vx2P zYjA== X-Forwarded-Encrypted: i=1; AJvYcCUghGrO2gIvrN/HF84zjNT6pE3ReZ7HF83f/916G5Zw/6nmC/ndiG1AsbeCgkNZlhOPig70l1QfMA==@kvack.org X-Gm-Message-State: AOJu0YzX4Yb+dRznw37ebHwIs0SWyFKRdWK69rs/gf/7z/fo6YTWR4n+ TulbIWvyc7SGDhS1NrpNvxxAhrJC6zmmYblj9zecM2zWEUb/WC8YwSIpFerTg6w= X-Google-Smtp-Source: AGHT+IF4SYJY9kdWkwrKjlAiH5Z+Bn8SZkqEPmKpcyMndgMPRn4H9T8dbqU6Hyt3/gFfCCmMTdbpdA== X-Received: by 2002:a05:6870:ab0b:b0:287:1b05:297d with SMTP id 586e51a60fabf-2962e01ad0dmr10557378fac.33.1731941400385; Mon, 18 Nov 2024 06:50:00 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-29651852c27sm2626597fac.2.2024.11.18.06.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Nov 2024 06:49:59 -0800 (PST) Message-ID: Date: Mon, 18 Nov 2024 07:49:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/17] mm/filemap: make buffered writes work with RWF_UNCACHED To: Baokun Li Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, bfoster@redhat.com, Yang Erkun References: <20241114152743.2381672-2-axboe@kernel.dk> <20241114152743.2381672-12-axboe@kernel.dk> <01fadf73-6b0f-44ff-9325-515fae37d968@huawei.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <01fadf73-6b0f-44ff-9325-515fae37d968@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E38D280003 X-Stat-Signature: x8mnzgq3haixxcy8j9wgwgftcjuscucx X-Rspam-User: X-HE-Tag: 1731941308-433493 X-HE-Meta: U2FsdGVkX19x9BkMTQvLZvZcr8WbEQ2dwLiC/qpPec/Qe+YVytVX574yJr+6cglUeegBn8bpJIGDHQMo4gaZf62HuPmNPsRStvp6EoaUJ7zO/gKZCsCk8Sdrh+rAxtksBO9TFuUK+KrL3VSJ0cl3cS1ESQYxwr8q89drSRNeS+CuWbRM24IwrgFoI0MEQGewCtubmOLXYEdCEfNOt9gRqJxRUkGXVbwpDTIRK9bOChfQw1PLKZ1j9mv6HBkHOJ10A39Sk6vLO2eabc/7Jy1U+yp6DI1HAkLIIdMISTsrkqqilL5+d/iPn+/aRx93wJ1HpXfNGy6csoBtuOpHElCCoQorDq3d6ZHnG8+tMdpjROsdvPe7wqwWHJqaTlpD1Qs8BnhBBM8d+ZrMe4maABMHB/CjBwFQEEQRnJcQxw0dGn8d9zWn4cyubA/0S+i6429hLlbqkW+x6yN3473XM8KLmgOO7h5S/7OHK7DhIH44gYGuiouciIPOkAaLiwgVkrXoA7UJZCw4a6NpoqMwVbw54zUHxm/8upDEWbhz+xp/8CKty7HjukiaclRrkDUFW/SR8vzglcCuaAwO/+LWODkTulv+foW3kIG/s1EF+NOwN9HRLi+a1Q4GNpYW+Jkpixyxpf57ZZulC+srlg2DBJCP1gayEePM1IoV+bpZpurFDJlTmQstKZvb4XC/yC+0grd14LPc4Zwu0PWGtMCjEjvNFENHscXbbzHjWQZ8u0OpvwZ4C3rOeACBsgLrrXiZMxNatUKzxOzYZYyPQ9PcH5nFiXLcu6AK1CHX6fSXFLAtV0rLaFgUOti5bslVjaP3nPxLJ3+JXbKE1jaaI1wA8fkS776wLrpEYLE+QddYyxUNh5msxkY6nCHvgw6NyQsHwtdqHU3LTVfNaW5iVqFRAb70MFS/7cv+dI5D2Hs/lsoOYqHonsPo97H/EVqGSACkvwVrYgJksaSkaHO1CD53RZo fl7MYdtP RJfN6+56d8EuqBL6wluk99C1K/Heuyvn+PfbyTVFxzrG4xDLGym6RGEZdP9p3zwy/PZ46Bj9WwbGPcD3w5xskJrm9K/vrSA5J/2jbpTOKdXgmLugXxSIGbP68WG07/7BsMKi3aUsIzUbQ1GEDMmKsRCaHcsVPVSIXhRxaVB8XyvNs+LA15lYROqNxlFyH13+wBkdCINM29kCT0mP14vvCCKYrQeNAdmmRXui1ERWllE9VxfT4Y1uw9ga6luECoTcU0cLfykyBYLfRH22RSzT6hjzh7n0bcbJotNd1LOOtt5QRAdjA71x2CJPg4J0c8gnT3ABvKgOTfAA7ebyTFJ0S4e71ZaRdzH1nwOklqcG8jgF4OHUKUSeok+8aK0hJp6uoSdE2vWD4W0HERLXLTX2dlURkYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000332, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/18/24 1:42 AM, Baokun Li wrote: >> diff --git a/include/linux/fs.h b/include/linux/fs.h >> index 45510d0b8de0..122ae821989f 100644 >> --- a/include/linux/fs.h >> +++ b/include/linux/fs.h >> @@ -2877,6 +2877,11 @@ static inline ssize_t generic_write_sync(struct kiocb *iocb, ssize_t count) >> (iocb->ki_flags & IOCB_SYNC) ? 0 : 1); >> if (ret) >> return ret; >> + } else if (iocb->ki_flags & IOCB_UNCACHED) { >> + struct address_space *mapping = iocb->ki_filp->f_mapping; >> + >> + filemap_fdatawrite_range_kick(mapping, iocb->ki_pos, >> + iocb->ki_pos + count); >> } >> > > Hi Jens, > > The filemap_fdatawrite_range_kick() helper function is not added until > the next patch, so you should swap the order of patch 10 and patch 11. Ah thanks, not sure how I missed that. I'll swap them for the next posting, and also do a basic bisection test just to ensure I did't do more of those... -- Jens Axboe