From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53CC4C433DB for ; Mon, 11 Jan 2021 16:45:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CCA742242A for ; Mon, 11 Jan 2021 16:45:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCA742242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36BBE8D0049; Mon, 11 Jan 2021 11:45:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31BD78D0041; Mon, 11 Jan 2021 11:45:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2317D8D0049; Mon, 11 Jan 2021 11:45:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 0BBC18D0041 for ; Mon, 11 Jan 2021 11:45:01 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C2046181AEF10 for ; Mon, 11 Jan 2021 16:45:00 +0000 (UTC) X-FDA: 77694068760.30.humor01_5e108472750e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 47948180B3C94 for ; Mon, 11 Jan 2021 16:45:00 +0000 (UTC) X-HE-Tag: humor01_5e108472750e X-Filterd-Recvd-Size: 3082 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 16:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610383498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jfWDa25Akh5OH/pweDQ3fJnM+dfnZCEUX8OjvCsiZ/E=; b=bP9veL9ouL8rMJv1ckn9+a+5JNFkaQYzZ4KY6a8R3zNHpHKi9zlU01sl2/Y0Lu2KtlRQiu Jy5BRTNfYwTKZcp6debvqEOAADs0ZELI2R1EvXQZfK3d1k8dGKqqohm5G5QEbwiU7J5Nmi dQRENPuchFi7RIS6Vp1bh7PkTJgSGho= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333-ULda1Ar_Pm688wQ0kVuMcw-1; Mon, 11 Jan 2021 11:44:55 -0500 X-MC-Unique: ULda1Ar_Pm688wQ0kVuMcw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A7C711823E41; Mon, 11 Jan 2021 16:44:53 +0000 (UTC) Received: from [10.36.115.103] (ovpn-115-103.ams2.redhat.com [10.36.115.103]) by smtp.corp.redhat.com (Postfix) with ESMTP id 815EC60C6E; Mon, 11 Jan 2021 16:44:51 +0000 (UTC) Subject: Re: [PATCH] mm/compaction: Remove duplicated VM_BUG_ON_PAGE !PageLocked To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210109081420.46030-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Mon, 11 Jan 2021 17:44:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210109081420.46030-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.01.21 09:14, Miaohe Lin wrote: > The VM_BUG_ON_PAGE(!PageLocked(page), page) is also done in PageMovable. > Remove this explicitly one. > > Signed-off-by: Miaohe Lin > --- > mm/compaction.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 02af220fb992..6d316eb99913 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -137,7 +137,6 @@ EXPORT_SYMBOL(__SetPageMovable); > > void __ClearPageMovable(struct page *page) > { > - VM_BUG_ON_PAGE(!PageLocked(page), page); > VM_BUG_ON_PAGE(!PageMovable(page), page); > /* > * Clear registered address_space val with keeping PAGE_MAPPING_MOVABLE > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb