From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC444C48BDF for ; Fri, 18 Jun 2021 19:32:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 57EDA61264 for ; Fri, 18 Jun 2021 19:32:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57EDA61264 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E31BD6B006C; Fri, 18 Jun 2021 15:32:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB9556B006E; Fri, 18 Jun 2021 15:32:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0C316B0072; Fri, 18 Jun 2021 15:32:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 8B93F6B006C for ; Fri, 18 Jun 2021 15:32:57 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 14240181AEF15 for ; Fri, 18 Jun 2021 19:32:57 +0000 (UTC) X-FDA: 78267842394.15.D431139 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf21.hostedemail.com (Postfix) with ESMTP id C5C56E000265 for ; Fri, 18 Jun 2021 19:32:56 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id u18so3091507pfk.11 for ; Fri, 18 Jun 2021 12:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=9CauSEz6HxLbbaFiGe9BJb3XkCTojZuIQZ6pJCmdamk=; b=kbqqelvA5GagoUTjV2Hj39sC5YL1E+IXyGv4rHbi/6Ghd1iWgCjRhK2hrVE31va7Qb YW7+RFRVKdSj5OuBhweEINiTaVXZVVMYcQ8nmo/FTm73N3+nKmMu4vME7llEaOUpiZnu j2a7oj+qdKwSwzo1Z4vtAzEa1xWu1ThhexzCBP9oaQoJ1x1m0N2Cympz425esovFpqyT mj7dqrgOPkVDPAK+6ErUTh40c3PDeNItiQc1OzW6MrOvkON1Z9XfDKrUDqbnN2Kq94iL 5g4oi2r6iA6+G1KbKqzNTKwU3Y+SR79Blp2TwZORdwBoH0qDEUxwRQTA2IzFht3sYyLb x0SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=9CauSEz6HxLbbaFiGe9BJb3XkCTojZuIQZ6pJCmdamk=; b=PttOEpv13z+XZEAC/Oxka36gqQldX+LmYlKjWmX7u13OsvQVGJUdgSsegoZMK3GcbR KcJwbgQZI9b9F1fKtmIXpyMkatpNAECGgbT5dImqGaCoKioZGwPAMzIjdQMAce9PBsY3 +Zxlr5eOx9ooqWHH9p6Mt3oAfGx7wOir+jcpvwJieGMEuElPeZEhThtAsBlkJLH5XOrM oIcB9DdriMpKFBxRaN2OQrs4iZJRcEadvPbBGFNe3ZwAG6U+cybBT1FzHBTxUY8CpUya Mby7eA4e/nCZh5MMMO3Bo4kfMvYDbVhxHUdAFYnTKrlLnRoyiqx/DbIi0r4C1ionYc/T d5Tg== X-Gm-Message-State: AOAM531oU39owJNns3UUoqYNMpWtdPJt2Ms4s+e3Q/DNtQZSVOGBlNIu hYFtvD32tdhLjmkRwNOUiPGlAQ== X-Google-Smtp-Source: ABdhPJwSqAPmwRB1YfSPHcy5nlQxpe4LdC2pC/eNINKTTeoYgbqQh899TSAqh9P+Lvu5/6c4oYdgKg== X-Received: by 2002:a62:5444:0:b029:2e9:c69d:dc64 with SMTP id i65-20020a6254440000b02902e9c69ddc64mr6579262pfb.32.1624044775553; Fri, 18 Jun 2021 12:32:55 -0700 (PDT) Received: from [2620:15c:17:3:3a6:a5d0:1984:a150] ([2620:15c:17:3:3a6:a5d0:1984:a150]) by smtp.gmail.com with ESMTPSA id r8sm2009077pjr.37.2021.06.18.12.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 12:32:54 -0700 (PDT) Date: Fri, 18 Jun 2021 12:32:53 -0700 (PDT) From: David Rientjes To: Lukas Bulwahn cc: gumingtao , cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, Andrew Morton , Vlastimil Babka , Nathan Chancellor , Nick Desaulniers , Linux-MM , Linux Kernel Mailing List , clang-built-linux , gumingtao Subject: Re: [PATCH] slab: Use %s instead of function name In-Reply-To: Message-ID: References: <1624013943-13935-1-git-send-email-gumingtao@xiaomi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=kbqqelvA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=rientjes@google.com X-Rspamd-Server: rspam02 X-Stat-Signature: jxoazbkkio4qxjmdenrs3rqib93e1bbz X-Rspamd-Queue-Id: C5C56E000265 X-HE-Tag: 1624044776-163146 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Jun 2021, Lukas Bulwahn wrote: > > It is better to replace the function name with %s. > > > > Signed-off-by: gumingtao > > --- > > mm/slab_common.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > index a4a5714..36127dc 100644 > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -381,8 +381,8 @@ kmem_cache_create_usercopy(const char *name, > > panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n", > > I am just wondering: > > Can you also make that refactoring change for the panic() call as well? > > How about checking the whole file for such patterns and doing that > change for all occurrences? > Yeah, that would be ideal if gumingtao is willing to do it. These are some instances where the function name actually mismatches. gumingtao, would you be willing to do this?